[Bug 25334] New: Add generic 'phone' message transport type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Bug ID: 25334 Summary: Add generic 'phone' message transport type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org As bug 25333 changed the 'phone' transport type to 'talkingtech', we can now re-add 'phone' as a transport type again, and allow it to behave and support the same notices as the email transport type. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25333 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 [Bug 25333] Change message transport type for Talking Tech from "phone" to "talkingtech" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104050&action=edit Bug 25334: Add generic 'phone' message transport type As bug 25333 changed the 'phone' transport type to 'talkingtech', we can now re-add 'phone' as a transport type again, and allow it to behave and support the same notices as the email transport type. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104050|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104076&action=edit Bug 25334: Add generic 'phone' message transport type As bug 25333 changed the 'phone' transport type to 'talkingtech', we can now re-add 'phone' as a transport type again, and allow it to behave and support the same notices as the email transport type. Test Plan; 1) Apply this patch 2) Run updatedatabase 3) Restart all the things! 4) Disable TalkingTechItivaPhoneNotificationi if enabled 5) Enable new PhoneNotification system preference 6) Go to a patron's messaging preferences, not you can select the 'phone' option for all the same notices as the 'email' option 7) Enable the phone option for all the message types 8) Browser to the Notices and slips editor 9) Add a phone notice version for each notice you wish to test 10) Test some notices ( CHECKIN, CHECKOUT, etc ) 11) Notices should show in the patron's messages as 'phone' notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104076|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104885&action=edit Bug 25334: Add generic 'phone' message transport type As bug 25333 changed the 'phone' transport type to 'talkingtech', we can now re-add 'phone' as a transport type again, and allow it to behave and support the same notices as the email transport type. Test Plan; 1) Apply this patch 2) Run updatedatabase 3) Restart all the things! 4) Disable TalkingTechItivaPhoneNotificationi if enabled 5) Enable new PhoneNotification system preference 6) Go to a patron's messaging preferences, not you can select the 'phone' option for all the same notices as the 'email' option 7) Enable the phone option for all the message types 8) Browser to the Notices and slips editor 9) Add a phone notice version for each notice you wish to test 10) Test some notices ( CHECKIN, CHECKOUT, etc ) 11) Notices should show in the patron's messages as 'phone' notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104885|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104886&action=edit Bug 25334: Add generic 'phone' message transport type As bug 25333 changed the 'phone' transport type to 'talkingtech', we can now re-add 'phone' as a transport type again, and allow it to behave and support the same notices as the email transport type. Test Plan; 1) Apply this patch 2) Run updatedatabase 3) Restart all the things! 4) Disable TalkingTechItivaPhoneNotificationi if enabled 5) Enable new PhoneNotification system preference 6) Go to a patron's messaging preferences, not you can select the 'phone' option for all the same notices as the 'email' option 7) Enable the phone option for all the message types 8) Browser to the Notices and slips editor 9) Add a phone notice version for each notice you wish to test 10) Test some notices ( CHECKIN, CHECKOUT, etc ) 11) Notices should show in the patron's messages as 'phone' notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Needs rebasing. 25333 applied fine, though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Needs rebasing. 25333 applied fine, though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104886|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 112101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112101&action=edit Bug 25334: Add generic 'phone' message transport type As bug 25333 changed the 'phone' transport type to 'talkingtech', we can now re-add 'phone' as a transport type again, and allow it to behave and support the same notices as the email transport type. Test Plan; 1) Apply this patch 2) Run updatedatabase 3) Restart all the things! 4) Disable TalkingTechItivaPhoneNotificationi if enabled 5) Enable new PhoneNotification system preference 6) Go to a patron's messaging preferences, not you can select the 'phone' option for all the same notices as the 'email' option 7) Enable the phone option for all the message types 8) Browser to the Notices and slips editor 9) Add a phone notice version for each notice you wish to test 10) Test some notices ( CHECKIN, CHECKOUT, etc ) 11) Notices should show in the patron's messages as 'phone' notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112101|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 112119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112119&action=edit Bug 25334: Add generic 'phone' message transport type As bug 25333 changed the 'phone' transport type to 'talkingtech', we can now re-add 'phone' as a transport type again, and allow it to behave and support the same notices as the email transport type. Test Plan; 1) Apply this patch 2) Run updatedatabase 3) Restart all the things! 4) Disable TalkingTechItivaPhoneNotificationi if enabled 5) Enable new PhoneNotification system preference 6) Go to a patron's messaging preferences, not you can select the 'phone' option for all the same notices as the 'email' option 7) Enable the phone option for all the message types 8) Browser to the Notices and slips editor 9) Add a phone notice version for each notice you wish to test 10) Test some notices ( CHECKIN, CHECKOUT, etc ) 11) Notices should show in the patron's messages as 'phone' notices Signed-off-by: Christopher Zorn <Christofer.Zorn@ajaxlibrary.ca> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112137&action=edit Bug 25333: Change message transport type for Talking Tech from "phone" to "itiva"
From its inception, phone notices via Talking Tech have not behaved like other notices. Instead of reading notices generated by Koha, the Talking Tech scripts largely generate their own notices.
We would like to pave the way to having "generic" phone notices that can be processed by plugins to support arbitrary telephony vendors ( we will be targeting Twilio initially ). To that end, it seems sensible to begin by changing the messaage transport type for Talking Tech from 'phone' to 'itiva' to highlight its specificity and difference from standard message transports. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Test Talking Tech outbound script 5) Note no changes in functionality Signed-off-by: Christopher Zorn <Christofer.Zorn@ajaxlibrary.ca> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I think we are missing changes for the OPAC and overdue notice trigger templates here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112119|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 112946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112946&action=edit Bug 25334: Add generic 'phone' message transport type As bug 25333 changed the 'phone' transport type to 'talkingtech', we can now re-add 'phone' as a transport type again, and allow it to behave and support the same notices as the email transport type. Test Plan; 1) Apply this patch 2) Run updatedatabase 3) Restart all the things! 4) Disable TalkingTechItivaPhoneNotificationi if enabled 5) Enable new PhoneNotification system preference 6) Go to a patron's messaging preferences, not you can select the 'phone' option for all the same notices as the 'email' option 7) Enable the phone option for all the message types 8) Browser to the Notices and slips editor 9) Add a phone notice version for each notice you wish to test 10) Test some notices ( CHECKIN, CHECKOUT, etc ) 11) Notices should show in the patron's messages as 'phone' notices Signed-off-by: Christopher Zorn <Christofer.Zorn@ajaxlibrary.ca> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 112947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112947&action=edit Bug 25334: (QA follow-up) Update opac messaging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 112948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112948&action=edit Bug 25334: (QA follow-up) Update overduerules.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112947|0 |1 is obsolete| | Attachment #112948|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113059&action=edit Bug 25334: (QA follow-up) Update opac messaging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113060&action=edit Bug 25334: (QA follow-up) Update overduerules.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Fixed patch author. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113103&action=edit Bug 25334: MTT is itiva not talkingtech -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112946|0 |1 is obsolete| | Attachment #113059|0 |1 is obsolete| | Attachment #113060|0 |1 is obsolete| | Attachment #113103|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113104&action=edit Bug 25334: Add generic 'phone' message transport type As bug 25333 changed the 'phone' transport type to 'talkingtech', we can now re-add 'phone' as a transport type again, and allow it to behave and support the same notices as the email transport type. Test Plan; 1) Apply this patch 2) Run updatedatabase 3) Restart all the things! 4) Disable TalkingTechItivaPhoneNotificationi if enabled 5) Enable new PhoneNotification system preference 6) Go to a patron's messaging preferences, not you can select the 'phone' option for all the same notices as the 'email' option 7) Enable the phone option for all the message types 8) Browser to the Notices and slips editor 9) Add a phone notice version for each notice you wish to test 10) Test some notices ( CHECKIN, CHECKOUT, etc ) 11) Notices should show in the patron's messages as 'phone' notices Signed-off-by: Christopher Zorn <Christofer.Zorn@ajaxlibrary.ca> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113105&action=edit Bug 25334: (QA follow-up) Update opac messaging Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113106&action=edit Bug 25334: (QA follow-up) Update overduerules.tt Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113107&action=edit Bug 25334: MTT is itiva not talkingtech -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Added missing signed-off-by line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Previously the 'phone' release notes| |message transport in Koha | |was tied to itiva and was | |not adaptable to other | |vendors. In this version | |that transport is renamed | |'itiva' and we add a new | |'phone' type that can | |operate more generically. CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Previously the 'phone' |Previously the 'phone' release notes|message transport in Koha |message transport in Koha |was tied to itiva and was |was tied to itiva and was |not adaptable to other |not adaptable to other |vendors. In this version |vendors. In this version |that transport is renamed |that transport is renamed |'itiva' and we add a new |'itiva' and we add a new |'phone' type that can |'phone' type that generates |operate more generically. |notices in the same manner | |as email, sms and print | |notices. Koha on it's own | |will not do anything with | |these notices. Instead, you | |will need a plugin such as | |https://github.com/bywaters | |olutions/koha-plugin-twilio | |-voice to handle making the | |phone calls and updating | |the notice status. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org