[Bug 14998] New: Remove C4::Dates from install and maintenance folder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Bug ID: 14998 Summary: Remove C4::Dates from install and maintenance folder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org This patch removes C4::Dates from files: - installer/data/mysql/updatedatabase.pl - misc/maintenance/fix_accountlines_date.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove C4::Dates from |Remove C4::Dates from |install and maintenance |installer and maintenance |folder |folders -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 43316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43316&action=edit Bug 14998 - Remove C4::Dates from installer and maintenance folders - installer/data/mysql/updatedatabase.pl - misc/maintenance/fix_accountlines_date.pl To test for updatedatabase.pl - perl installer/data/mysql/updatedatabase.pl - review code. Difficult to test, because the code affects $DBversion = '3.03.00.035' To test for misc/maintenance/fix_accountlines_date.pl - review code - The file seems to be a file used for an update, could it be obsolete? If yes, remove it in a follow-up -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #2 from Marc Véron <veron@veron.ch> --- Still applies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 44092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44092&action=edit Bug 14998 - (followup) Remove file fix_accountlines_date.pl This patch removes the file misc/maintenance/fix_accountlines_date.pl To test: - Verify that the file is no longer used - Apply patch - Verify that the file vanished -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Marc Véron from comment #3)
- Verify that the file is no longer used
While it isn't used as far as I can tell. Does a date get placed in description still? If so, this script may still be handy to keep. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #5 from Marc Véron <veron@veron.ch> --- (In reply to M. Tompsett from comment #4)
(In reply to Marc Véron from comment #3)
- Verify that the file is no longer used
While it isn't used as far as I can tell. Does a date get placed in description still? If so, this script may still be handy to keep.
In the first patch I removed C4::Dates from misc/maintenance/fix_accountlines_date.pl So it does no harm to keep the file. I obsolete the second patch and open a new bug for removing. That can be discussed later. The main thing now bring the C4::Dates removal to an end. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44092|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15076 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43316|0 |1 is obsolete| | --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44415&action=edit Bug 14998 - Remove C4::Dates from installer and maintenance folders - installer/data/mysql/updatedatabase.pl - misc/maintenance/fix_accountlines_date.pl To test for updatedatabase.pl - perl installer/data/mysql/updatedatabase.pl - review code. Difficult to test, because the code affects $DBversion = '3.03.00.035' To test for misc/maintenance/fix_accountlines_date.pl - review code - The file seems to be a file used for an update, could it be obsolete? If yes, remove it in a follow-up Signed-off-by: Frederic Demians <f.demians@tamil.fr> Code OK. Tested updatedatabase.pl with an old DB backup: OK. fix_accountlines_date.pl still working after the patch. Could be removed from master IMO. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't want to spent too much time on this script, but I don't think it will work as before. C4::Dates->new($1, 'us')->output() and output_pref( { dt => dt_from_string( $1 ), dateonly => 1, dateformat => 'us' } are different I think, it should be output_pref( { dt => dt_from_string( $1, 'us' ), dateonly => 1 } I would prefer to see this script deleted :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #8 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #7)
I don't want to spent too much time on this script, but I don't think it will work as before.
C4::Dates->new($1, 'us')->output() and output_pref( { dt => dt_from_string( $1 ), dateonly => 1, dateformat => 'us' } are different I think, it should be output_pref( { dt => dt_from_string( $1, 'us' ), dateonly => 1 }
I would prefer to see this script deleted :)
Delete +1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #9 from Marc Véron <veron@veron.ch> --- See Bug 15076 - Remove file misc/maintenance/fix_accountlines_date.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44415|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44745&action=edit Bug 14998 - Remove C4::Dates from installer and maintenance folders - installer/data/mysql/updatedatabase.pl - misc/maintenance/fix_accountlines_date.pl To test for updatedatabase.pl - perl installer/data/mysql/updatedatabase.pl - review code. Difficult to test, because the code affects $DBversion = '3.03.00.035' To test for misc/maintenance/fix_accountlines_date.pl - review code - The file seems to be a file used for an update, could it be obsolete? If yes, remove it in a follow-up Signed-off-by: Frederic Demians <f.demians@tamil.fr> Code OK. Tested updatedatabase.pl with an old DB backup: OK. fix_accountlines_date.pl still working after the patch. Could be removed from master IMO. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44746&action=edit Bug 14998: Restore previous behavior We want to convert a us or metric date formatted to the format defined in the pref. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15076 | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Continue without waiting for 15076. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org