[Bug 17964] New: TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Bug ID: 17964 Summary: TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59436&action=edit Bug 17964: TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
From the CHECKIN and CHECKOUT templates you should be able to access the following information: item, biblio, biblioitem, patron and library
Test plan: Define CHECKIN and CHECKOUT notice templates. You should be able to define them using the TT syntax to produce the same generated notice messages as with the historical syntax. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59437&action=edit Bug 17964: Add old_issues If it's a CHECKIN, C4::Circulation::SendCirculationAlert set a "old_issues" key instead of "issues". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59438&action=edit Bug 17964: Support date formatting Using the KohaDates plugin will allow us to format dates as we want, using the same filters as the ones defined in the KohaDates TT plugin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 [Bug 17963] TT syntax for notices - Prove that AR_* are compatible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59436|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59540&action=edit Bug 17964: TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
From the CHECKIN and CHECKOUT templates you should be able to access the following information: item, biblio, biblioitem, patron and library
Test plan: Define CHECKIN and CHECKOUT notice templates. You should be able to define them using the TT syntax to produce the same generated notice messages as with the historical syntax. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59437|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59541&action=edit Bug 17964: Add old_issues If it's a CHECKIN, C4::Circulation::SendCirculationAlert set a "old_issues" key instead of "issues". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59438|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59542&action=edit Bug 17964: Support date formatting Using the KohaDates plugin will allow us to format dates as we want, using the same filters as the ones defined in the KohaDates TT plugin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59540|0 |1 is obsolete| | Attachment #59541|0 |1 is obsolete| | Attachment #59542|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60403&action=edit Bug 17964: TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
From the CHECKIN and CHECKOUT templates you should be able to access the following information: item, biblio, biblioitem, patron and library
Test plan: Define CHECKIN and CHECKOUT notice templates. You should be able to define them using the TT syntax to produce the same generated notice messages as with the historical syntax. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60404&action=edit Bug 17964: Add old_issues If it's a CHECKIN, C4::Circulation::SendCirculationAlert set a "old_issues" key instead of "issues". Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60405&action=edit Bug 17964: Support date formatting Using the KohaDates plugin will allow us to format dates as we want, using the same filters as the ones defined in the KohaDates TT plugin. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|--- |Small patch --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + module => 'Koha::Old::Checkouts', Hope that we will rename that one.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 61595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61595&action=edit Bug 17964: [QA Follow-up] Test descriptions, typo Typo: have been checkin => checked. And five test descriptions ;) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- In the interface I used this checkin notice: The following items have been checked in: ---- [% biblio.title %] [% old_issues.returndate %] [% old_issues.issue_id %] ---- Thank you. And it does not show me the old issues information. No date and no id. === If I look at sub _get_tt_params, I am having doubts if the correct old issues record would be found when just using itemnumber as a foreign key. Note that I repeatedly checked in and out the same item. Looking at the code, I would expect the wrong old issue record found. Should you not look at the last one instead of the first one? The "historical" code uses: ORDER BY timestamp DESC in _parseletter_sth.. Another question: How do you use plural in _get_tt_params ? If we are not using it, why add it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- And as a side note: Is this code in get_tt_params really correct: else { # $ref eq 'ARRAY' my $object; if ( @{ $tables->{$table} } == 1 ) { # Param is a single key $object = $module->search( { $pk => $tables->{$table} } )->next(); } else { # Params are mutliple foreign keys croak "Multiple foreign keys (table $table) should be passed using an hashref"; } I was thinking that I could pass a few primary keys in an array (see historical code). But this code croaks on "multiple fk's". Plus a typo :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #13)
In the interface I used this checkin notice:
The following items have been checked in: ---- [% biblio.title %] [% old_issues.returndate %] [% old_issues.issue_id %] ---- Thank you.
And it does not show me the old issues information. No date and no id.
I will take a look.
If I look at sub _get_tt_params, I am having doubts if the correct old issues record would be found when just using itemnumber as a foreign key. Note that I repeatedly checked in and out the same item. Looking at the code, I would expect the wrong old issue record found. Should you not look at the last one instead of the first one? The "historical" code uses: ORDER BY timestamp DESC in _parseletter_sth..
Same.
Another question: How do you use plural in _get_tt_params ? If we are not using it, why add it?
You should take a look at the whole enhancement, tree of dependencies. If you take a look bug 17981, which is almost the top of the tree, you will see all the deps. There is a remote branch to see all patches applied. I think it's important to have this overview in mind before QAing separately the different bug reports. It is hard to make a such big tree and trying to reflect what you are trying to do on all the different steps. (In reply to Marcel de Rooy from comment #14)
And as a side note: Is this code in get_tt_params really correct: else { # $ref eq 'ARRAY' my $object; if ( @{ $tables->{$table} } == 1 ) { # Param is a single key $object = $module->search( { $pk => $tables->{$table} } )->next(); } else { # Params are mutliple foreign keys croak "Multiple foreign keys (table $table) should be passed using an hashref"; } I was thinking that I could pass a few primary keys in an array (see historical code). But this code croaks on "multiple fk's". Plus a typo :)
That could be implement later, I just implemented what I used. During the whole process I did not need it. Maybe later? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #15)
(In reply to Marcel de Rooy from comment #13)
In the interface I used this checkin notice:
The following items have been checked in: ---- [% biblio.title %] [% old_issues.returndate %] [% old_issues.issue_id %]
TT syntax uses old_checkouts. Take a look at unit tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #16)
(In reply to Jonathan Druart from comment #15)
(In reply to Marcel de Rooy from comment #13)
In the interface I used this checkin notice:
The following items have been checked in: ---- [% biblio.title %] [% old_issues.returndate %] [% old_issues.issue_id %]
TT syntax uses old_checkouts. Take a look at unit tests.
OK. Is that handy? Others might make the same mistake when converting a notice? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 [Bug 18332] Add the Koha::Objects->last method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #17)
(In reply to Jonathan Druart from comment #16)
(In reply to Jonathan Druart from comment #15)
(In reply to Marcel de Rooy from comment #13)
In the interface I used this checkin notice:
The following items have been checked in: ---- [% biblio.title %] [% old_issues.returndate %] [% old_issues.issue_id %]
TT syntax uses old_checkouts. Take a look at unit tests.
OK. Is that handy? Others might make the same mistake when converting a notice?
In any cases it's not introduced by this patchset. We discussed about that already and decided to use the "new" terminology. You should also take a look at bug 17981, I provide a very friendly way to automagically convert legacy syntax notices to the TT syntax. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61627&action=edit Bug 17964: Replace next with last We certainly always want to retrieve the last row of a given search. If it not sufficient we will need to rethink this code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #19)
We certainly always want to retrieve the last row of a given search. If it not sufficient we will need to rethink this code.
Looks okay to me now, but I am not sure if it will always do when extending this code (adding tables). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18359 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Having trouble with the unit test. Check bug 18359 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Forget Patron::Modification. The problem is the txn_do in MarkIssueReturned triggered by calling AddReturn. Since this report causes data modification when running TemplateToolkit.t, and this problem does not occur without these patches, we should solve it here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18359 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #22)
Since this report causes data modification when running TemplateToolkit.t, and this problem does not occur without these patches, we should solve it here.
Looks like it comes from bug 15854. That needs to be fixed on its own bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Depends on| |18364 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- See bug 18364. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 [Bug 18364] LOCK and UNLOCK are not transaction-safe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Bug 17964 depends on bug 17963, which changed state. Bug 17963 Summary: TT syntax for notices - Prove that AR_* are compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Bug 17964 depends on bug 18332, which changed state. Bug 18332 Summary: Add the Koha::Objects->last method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60403|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62460&action=edit Bug 17964: TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
From the CHECKIN and CHECKOUT templates you should be able to access the following information: item, biblio, biblioitem, patron and library
Test plan: Define CHECKIN and CHECKOUT notice templates. You should be able to define them using the TT syntax to produce the same generated notice messages as with the historical syntax. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60404|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62461&action=edit Bug 17964: Add old_issues If it's a CHECKIN, C4::Circulation::SendCirculationAlert set a "old_issues" key instead of "issues". Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60405|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62462&action=edit Bug 17964: Support date formatting Using the KohaDates plugin will allow us to format dates as we want, using the same filters as the ones defined in the KohaDates TT plugin. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61595|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62463&action=edit Bug 17964: [QA Follow-up] Test descriptions, typo Typo: have been checkin => checked. And five test descriptions ;) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61627|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62464&action=edit Bug 17964: Replace next with last We certainly always want to retrieve the last row of a given search. If it not sufficient we will need to rethink this code. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org