[Bug 25462] New: Shelving location should be on a new line in holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Bug ID: 25462 Summary: Shelving location should be on a new line in holdings table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: david.roberts@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In the staff client, if an item has a long shelving location description, it displays on the same line as the Home Library, which doesn't look very good. It ought to be on the next line. https://snipboard.io/YzSTDH.jpg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 104746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104746&action=edit Bug 25462: Shelving location should be on a new line in holdings table This patch moves the shelving location a new line after the Home library in the holdings table. To test: 1) Assign a shelving location with a long description to an item. 2) See that it displays on the same line as the Home Library in /cgi-bin/koha/catalogue/detail.pl 3) Apply the patch 4) Check that the shelving location is now on a new line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think instead of hardcoding a <br> here this cold be possibly solved by CSS instead (display:block?) With your patch there would always be a new line, even if there is no location. It might be something got lost there at some point as we definitely have a new line in our older versions. I am adding Owen - he might have an idea what changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #3 from David Roberts <david.roberts@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #2)
I think instead of hardcoding a <br> here this cold be possibly solved by CSS instead (display:block?) With your patch there would always be a new line, even if there is no location.
It might be something got lost there at some point as we definitely have a new line in our older versions. I am adding Owen - he might have an idea what changed.
My knowledge of CSS isn't good enough to do that, sadly! I take your point about the permanent new line though. Perhaps something like this might work instead (I haven't tested this, it's just an idea at the moment!) [% IF (item.location) %] <br /> <span class="shelvingloc"> [% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 104772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104772&action=edit Bug 25462: Show shelving location on a new line after home library (staff client) This patch updates the staff client CSS to move the shelving location a new line after the 'Home library' in list of holdings on the bibliographic detail page. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Locate a title in the staff client which has items with a shelving location. - View the detail page for that title. In the table of holdings, confirm that the shelving location information is on a separate line from the home library information. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 104773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104773&action=edit Bug 25462: Show shelving location on a new line after home library (OPAC) This patch updates the OPAC CSS to move the shelving location a new line after the 'Home library' in list of holdings on the bibliographic detail page. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Locate a title in the OPAC which has items with a shelving location. - View the detail page for that title. In the table of holdings, confirm that the shelving location information is on a separate line from the home library information. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I've attached an alternate solution that uses CSS, also including a fix for the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Careful, class "shelvingloc" is used in a lot of places : git grep -l 'class="shelvingloc' koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt I suggest you add "display: block" most specificly on items table : intranet : td.homebranch .shelvingloc opac : td.location .shelvingloc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104746|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 112996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112996&action=edit Bug 25462: Shelving location should be on a new line in holdings table This patch moves the shelving location a new line after the Home library in the holdings table. To test: 1) Assign a shelving location with a long description to an item. 2) See that it displays on the same line as the Home Library in /cgi-bin/koha/catalogue/detail.pl 3) Apply the patch 4) Check that the shelving location is now on a new line Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104772|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 112997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112997&action=edit Bug 25462: Show shelving location on a new line after home library (staff client) This patch updates the staff client CSS to move the shelving location a new line after the 'Home library' in list of holdings on the bibliographic detail page. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Locate a title in the staff client which has items with a shelving location. - View the detail page for that title. In the table of holdings, confirm that the shelving location information is on a separate line from the home library information. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104773|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 112998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112998&action=edit Bug 25462: Show shelving location on a new line after home library (OPAC) This patch updates the OPAC CSS to move the shelving location a new line after the 'Home library' in list of holdings on the bibliographic detail page. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Locate a title in the OPAC which has items with a shelving location. - View the detail page for that title. In the table of holdings, confirm that the shelving location information is on a separate line from the home library information. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tested on a sandbox on live testing youtube. All works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Careful, class "shelvingloc" is used in a lot of places, see comment 7 And should we not remove patch adding <br/> ? "Bug 25462: Shelving location should be on a new line in holdings table" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 113092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113092&action=edit Bug 25462: (follow-up) Remove <br /> as it is no longer needed Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've swung back around to this to do a bit more due diligence.. I've checked all pages with the related class and confirmed that they all look good with the updated styling... I've also added a followup to revert the first patch (added as a followup to retain David's contribution, but I'll leave it up to the RM to decide whether to squash/remove entirely the pair). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In the end this boils down to a nice small change. Found no regressions looking at a lot of pages that use the shelvingloc class. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112996|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 114770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114770&action=edit Bug 25462: Shelving location should be on a new line in holdings table This patch moves the shelving location a new line after the Home library in the holdings table. To test: 1) Assign a shelving location with a long description to an item. 2) See that it displays on the same line as the Home Library in /cgi-bin/koha/catalogue/detail.pl 3) Apply the patch 4) Check that the shelving location is now on a new line Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112997|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 114771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114771&action=edit Bug 25462: Show shelving location on a new line after home library (staff client) This patch updates the staff client CSS to move the shelving location a new line after the 'Home library' in list of holdings on the bibliographic detail page. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Locate a title in the staff client which has items with a shelving location. - View the detail page for that title. In the table of holdings, confirm that the shelving location information is on a separate line from the home library information. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112998|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 114772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114772&action=edit Bug 25462: Show shelving location on a new line after home library (OPAC) This patch updates the OPAC CSS to move the shelving location a new line after the 'Home library' in list of holdings on the bibliographic detail page. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Locate a title in the OPAC which has items with a shelving location. - View the detail page for that title. In the table of holdings, confirm that the shelving location information is on a separate line from the home library information. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113092|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 114773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114773&action=edit Bug 25462: (follow-up) Remove <br /> as it is no longer needed Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Text to go in the| |In the holdings table, the release notes| |shelving location is now | |displayed on a new line | |after the 'Home library'. Version(s)|21.05.00 |21.05.00,20.11.02 released in| | --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small but really useful enhancement, I choose to backport. Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.02 |21.05.00,20.11.02,20.05.08 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org