[Bug 17611] New: Searching for orders uses misleading column name " Pending order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Bug ID: 17611 Summary: Searching for orders uses misleading column name "Pending order" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: rbit@rbit.cz QA Contact: testopia@bugs.koha-community.org Steps to reproduce: 1) Open the Acquisition module 2) At the top of the page click "Orders search" 3) Fill-in a book title that has been already received and submit the form 4) Title is found displaying (among others) these columns: - Quantity received - Pending order The Pending order is NOT pending, in fact. The header should be renamed to "Quantity ordered". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |rbit@rbit.cz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com, | |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |sonia.bouis@univ-lyon3.fr --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ccing Sonia, would you agree with the column's header renaming or do you think it's better to update the value (quantity ordered - quantity received)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hum... in my opinion, as when we partially received an order, it creates a new order, the quantity ordered isn't so interesting. It's just important to fix the number of pending orders. Just my 2 cents, I'm not sure what would be better for the greatest number of librarians. Sonia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 --- Comment #3 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- I'd agree with Sonia. The total quantity ordered is important at the very beginning of acquisition process, but whe the order is received partially, it shoudl display the result of "ordered MINUS received", which makes more sense, I think. Or, another proposal... What if we display in the column "Pending order" a value like "2 of 5"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97262&action=edit Bug 17611: Change 'Pending order' to 'Quantity ordered' Picking Quantity ordered as it seems more in line with other pages in Koha where we show information. We always show the quantity, so it makes sense to also have this label on the 'order search' and 'copy existing order'. Order search 1) Make sure you have some orders in your acq module 2) Go to the top and do an empty orders search 3) Review the column headings of the search results 4) Find "Pending order" Order from existing order (copy) 1) Create or choose an existing open basket 2) 'Add to basket' - 'From existing orders' 3) Search to find some of your orders 4) Look at the column headings, find 'Pending order' 5) Pick some orders and fill out order information, save 6) Summary: Find 'Pending order' in the table again x) Apply the patch and make sure all 'Pending' orders above have been changed to 'Quantity ordered'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|rbit@rbit.cz |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Don't be mad at me, but after reviewing other pages in the acquisition module and testing the partial receive process, I've decided to use the 'Quantity ordered' instead of changing the content of the column. It feels more in line with the other pages in the acquisition module for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97262|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 97390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97390&action=edit Bug 17611: Change 'Pending order' to 'Quantity ordered' Picking Quantity ordered as it seems more in line with other pages in Koha where we show information. We always show the quantity, so it makes sense to also have this label on the 'order search' and 'copy existing order'. Order search 1) Make sure you have some orders in your acq module 2) Go to the top and do an empty orders search 3) Review the column headings of the search results 4) Find "Pending order" Order from existing order (copy) 1) Create or choose an existing open basket 2) 'Add to basket' - 'From existing orders' 3) Search to find some of your orders 4) Look at the column headings, find 'Pending order' 5) Pick some orders and fill out order information, save 6) Summary: Find 'Pending order' in the table again x) Apply the patch and make sure all 'Pending' orders above have been changed to 'Quantity ordered'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97390|0 |1 is obsolete| | --- Comment #7 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 98583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98583&action=edit Bug 17611: Change 'Pending order' to 'Quantity ordered' Picking Quantity ordered as it seems more in line with other pages in Koha where we show information. We always show the quantity, so it makes sense to also have this label on the 'order search' and 'copy existing order'. Order search 1) Make sure you have some orders in your acq module 2) Go to the top and do an empty orders search 3) Review the column headings of the search results 4) Find "Pending order" Order from existing order (copy) 1) Create or choose an existing open basket 2) 'Add to basket' - 'From existing orders' 3) Search to find some of your orders 4) Look at the column headings, find 'Pending order' 5) Pick some orders and fill out order information, save 6) Summary: Find 'Pending order' in the table again x) Apply the patch and make sure all 'Pending' orders above have been changed to 'Quantity ordered'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98583|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99266&action=edit Bug 17611: Change 'Pending order' to 'Quantity ordered' Picking Quantity ordered as it seems more in line with other pages in Koha where we show information. We always show the quantity, so it makes sense to also have this label on the 'order search' and 'copy existing order'. Order search 1) Make sure you have some orders in your acq module 2) Go to the top and do an empty orders search 3) Review the column headings of the search results 4) Find "Pending order" Order from existing order (copy) 1) Create or choose an existing open basket 2) 'Add to basket' - 'From existing orders' 3) Search to find some of your orders 4) Look at the column headings, find 'Pending order' 5) Pick some orders and fill out order information, save 6) Summary: Find 'Pending order' in the table again x) Apply the patch and make sure all 'Pending' orders above have been changed to 'Quantity ordered'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- String fix.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org