http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 11942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11942&action=edit Changed and statement to have boundary check first. This is one of those strange bugs where the line number for the error number is not where the error is. Fixing the condition in the while loop fixes the warning generated by the test plan already posted on this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |mtompset@hotmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11942|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11953&action=edit Bug 8714 - Poorly ordered and triggers warning in marctagstructure.pl An array boundary check was after a comparison using the array. By changing the logic which had " and ( $j < $cnt)" to be at the beginning "( $j < $cnt ) and ", the warning is no longer shown in the error log. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> ---

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

patch looks good, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 146447b Bug 8714 - Poorly ordered and triggers warning in marctagstructur admin/marctagstructure.pl * admin/marctagstructure.pl OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.