https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16675 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 52109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52109&action=edit Bug 16675: fix breakage of t/Languages.t This patch fixes test breakage introduced by the patch for bug 16088, which added caching of getlanguages(). Upon inspection, it looks like the patch for 16088 does not introduce a regression on bug 10560, so this patch adds a couple cache-clearings. To test ------- [1] Verify that t/Languages.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16675 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52109|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 52125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52125&action=edit Bug 16675: fix breakage of t/Languages.t This patch fixes test breakage introduced by the patch for bug 16088, which added caching of getlanguages(). Upon inspection, it looks like the patch for 16088 does not introduce a regression on bug 10560, so this patch adds a couple cache-clearings. To test ------- [1] Verify that t/Languages.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16675 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Assignee|chris@bigballofwax.co.nz |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16675 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |16088 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088 [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16675 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52128|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52160&action=edit Bug 16675: fix breakage of t/Languages.t This patch fixes test breakage introduced by the patch for bug 16088, which added caching of getlanguages(). Upon inspection, it looks like the patch for 16088 does not introduce a regression on bug 10560, so this patch adds a couple cache-clearings. To test ------- [1] Verify that t/Languages.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16675 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16675 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Julian Maurice from comment #7)

Frédéric, you should probably push bug 16088 as well, because it introduce Koha::Cache::Memory::Lite (which is used by this patch)

I was reluctant to, but with a failing test, I have no choice. Thanks Julian. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16675 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Frédéric Demians from comment #8)

(In reply to Julian Maurice from comment #7)

...

Frédéric, you should probably push bug 16088 as well, because it introduce Koha::Cache::Memory::Lite (which is used by this patch)

I was reluctant to, but with a failing test, I have no choice. Thanks Julian.

I do not understand: this patch (16675) fixes a test which fails because of bug 16088. -- You are receiving this mail because: You are watching all bug changes.