[Bug 23235] New: Rename Koha::Biblio->metadata with ->marc_xml to avoid ambiguity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23235 Bug ID: 23235 Summary: Rename Koha::Biblio->metadata with ->marc_xml to avoid ambiguity Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 22700 What about renaming the method in Koha::S::R::Biblio to ->marc_xml_metadata (adding the conditions in it) and Koha::Biblio->metadata to ->marc_xml (make it returns the MARX XML directly)? See bug 22700 for the discussion. However it will break (again) the reports people already have. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23235 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- It should return a Koha::Biblio::Metadata object, which is an envelope containing info about the schema, format, etc. Maybe you mean a method in Koha::Biblio::Metadata -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23235 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The problem IMO is that we have a DB structure to allow 1-N but it's not clear (reading the code) that we support only one. I think we should have "marc_xml" explicitely written in the name of the subroutine, to make it clear. Reading the code I'd say that even if you have a biblio_metadata.format with something else than "marcxml", it will be used anyway. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23235 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34828 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org