[Bug 36877] New: Patron card creator does not work when editing layout, profile or template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Bug ID: 36877 Summary: Patron card creator does not work when editing layout, profile or template Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: bibliothek@th-wildau.de QA Contact: testopia@bugs.koha-community.org 1. When trying to edit a layout in patron card creator the following error is thrown on the website: WARNING: An unsupported operation was attempted on layout 20. Please have your system administrator check the error log for details. The log says: [WARN] Unsupported operation type submitted: edit at /kohadevbox/koha/patroncards/edit-layout.pl line 271. To reproduce: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) the above warning shows up 2. When trying to edit a template it shows an empty 'New patron card template' form 3. When trying to edit a profile it shows an empty 'New printer profile' form I think this is somehow related to Bug 34478 as all 3 scripts check for an operation $op eq 'cud-edit' but the query param is just 'edit' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority Severity|normal |major Depends on| |36192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36192 | Blocks| |36192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 --- Comment #1 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 166810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166810&action=edit Bug 36877: Fix Patron card creator errors on editing layout, profile or template This patch fixes the unexpected behaviour when clicking on edit layout, edit profile or edit template in Patron card creator tool. Test plans: 1. edit layout: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) WARNING: An unsupported operation was attempted on layout 20. Please have your system administrator check the error log for details. apply patch a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) Edit patron card layout form 20 shows up 2. edit template and profile: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=templa... or http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=profil... b) click edit on an item in the table c) notice that the forms are empty apply patch and redo steps a) and b) to load the edit form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 --- Comment #2 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 166822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166822&action=edit Bug 36877: (follow-up) Fix op eq edit to op eq edit_form in edit-batch.pl Additionally removes fixme comments -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166810|0 |1 is obsolete| | Attachment #166822|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166823&action=edit Bug 36877: Fix Patron card creator errors on editing layout, profile or template This patch fixes the unexpected behaviour when clicking on edit layout, edit profile or edit template in Patron card creator tool. Test plans: 1. edit layout: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) WARNING: An unsupported operation was attempted on layout 20. Please have your system administrator check the error log for details. apply patch a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) Edit patron card layout form 20 shows up 2. edit template and profile: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=templa... or http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=profil... b) click edit on an item in the table c) notice that the forms are empty apply patch and redo steps a) and b) to load the edit form Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166824&action=edit Bug 36877: (follow-up) Fix op eq edit to op eq edit_form in edit-batch.pl Additionally removes fixme comments Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |bibliothek@th-wildau.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166823|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 166877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166877&action=edit Bug 36877: Fix Patron card creator errors on editing layout, profile or template This patch fixes the unexpected behaviour when clicking on edit layout, edit profile or edit template in Patron card creator tool. Test plans: 1. edit layout: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) WARNING: An unsupported operation was attempted on layout 20. Please have your system administrator check the error log for details. apply patch a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) Edit patron card layout form 20 shows up 2. edit template and profile: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=templa... or http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=profil... b) click edit on an item in the table c) notice that the forms are empty apply patch and redo steps a) and b) to load the edit form Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166824|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 166878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166878&action=edit Bug 36877: (follow-up) Fix op eq edit to op eq edit_form in edit-batch.pl Additionally removes fixme comments Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If the patron card create has this issue, do we expect similar problems in the label creator? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34478 CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- 23.11.x not impacted () Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Bug 36877 depends on bug 34478, which changed state. Bug 34478 Summary: Full CSRF protection https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org