[Bug 20165] New: Capitalization: Street Address should be Street address in patron search options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Bug ID: 20165 Summary: Capitalization: Street Address should be Street address in patron search options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The search options for patron search include "Street Address". This should be fixed to be "Street address" instead to follow our capitalization rules. To test: - Go to "Patrons" - Switch in top search to tab "Search patrons" - Click on + sign - Check "Search fields" pull down - Compare to same pull down in the filters at the right side -> top search option is spelled wrong, the one on the right is correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Olivia <olivialokm@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 --- Comment #1 from Olivia <olivialokm@gmail.com> --- Created attachment 83929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83929&action=edit Bug 20165 : Changed uppercase letter to a lowercase letter in the patron search search fields under the plus option. Changed "Street Address" to "Street address" in the patron search search fields under the plus sign to fit Koha's capitalization rules. To find this change: 1. Go to Patrons and switch in the search to search patrons 2. Click on the plus sign 3. Check "Search fields" pull down 4. "Street Address" should now be "Street address" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Hi Olivia. I couldn't get your patch to work. I think line 53 needs to be changed as well: 53 <option value='address'>Street Address</option> David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Olivia <olivialokm@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Olivia <olivialokm@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83929|0 |1 is obsolete| | --- Comment #3 from Olivia <olivialokm@gmail.com> --- Created attachment 84012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84012&action=edit Bug 20165 : Changed uppercase letter to a lowercase letter in the patron search search fields under the plus option. Changed "Street Address" to "Street address" in the patron search search fields under the plus sign to fit Koha's capitalization rules. To find this change: 1. Go to Patrons and switch in the search to search patrons 2. Click on the plus sign 3. Check "Search fields" pull down 4. "Street Address" should now be "Street address" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Olivia, can you take another look? I think you uploaded the same patch again, It shows the "Street Address" remaining a few lines below your change. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Olivia <olivialokm@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Olivia <olivialokm@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84012|0 |1 is obsolete| | --- Comment #5 from Olivia <olivialokm@gmail.com> --- Created attachment 84025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84025&action=edit Bug 20165: Changed uppercase letter to a lowercase letter in the patron search search fields under the plus option. Changed "Street Address" to "Street address" in the patron search search fields under the plus sign to fit Koha's capitalization rules. To find this change: 1. Go to Patrons and switch in the search to search patrons 2. Click on the plus sign 3. Check "Search fields" pull down 4. "Street Address" should now be "Street address" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84025|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 84029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84029&action=edit Bug 20165: Changed uppercase letter to a lowercase letter in the patron search search fields under the plus option. Changed "Street Address" to "Street address" in the patron search search fields under the plus sign to fit Koha's capitalization rules. To find this change: 1. Go to Patrons and switch in the search to search patrons 2. Click on the plus sign 3. Check "Search fields" pull down 4. "Street Address" should now be "Street address" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from David Nind <david@davidnind.com> --- Nice work Olivia! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |olivialokm@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84029|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84078&action=edit Bug 20165: Changed uppercase letter to a lowercase letter in the patron search search fields under the plus option. Changed "Street Address" to "Street address" in the patron search search fields under the plus sign to fit Koha's capitalization rules. To find this change: 1. Go to Patrons and switch in the search to search patrons 2. Click on the plus sign 3. Check "Search fields" pull down 4. "Street Address" should now be "Street address" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work Olivia! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #11 from Jesse Maseto <jesse@bywatersolutions.com> --- Pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I dont push to 17.11.x to minimize translation work -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org