[Bug 32199] New: Add page-section to various patron pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 Bug ID: 32199 Summary: Add page-section to various patron pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 30952 Blocks: 31757 Several patron-related pages need the page-section container: - includes/ill-list-table.inc - members/discharges.tt - members/files.tt - members/holdshistory.tt - members/notices.tt - members/purchase-suggestions.tt - members/routing-lists.tt - members/statistics.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143856&action=edit Bug 32199: Add page-section to various patron pages This patch adds a .page-section div to various patron-related pages in order to provide a consistent page structure. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Patrons -> Patron details -> - Files - Holds history - ILL request history - Notices - Purchase suggestions - Routing lists - Statistics - Staff interface home page -> Discharge requests pending -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143856|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143861&action=edit Bug 32199: Add page-section to various patron pages This patch adds a .page-section div to various patron-related pages in order to provide a consistent page structure. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Patrons -> Patron details -> - Files - Holds history - ILL request history - Notices - Purchase suggestions - Routing lists - Statistics - Staff interface home page -> Discharge requests pending Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143862&action=edit Bug 32199: (follow-up) Add page-section to circulation history Note: There is a trick here. If OnsiteCheckouts are active, the circulation history will be tabbed and not use page-section. If the pref is off, you'll see the page-section with this patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143863&action=edit Bug 32199: (follow-up) Add page-section to list of validated discharges This requires that a discharge is added to the patron account first. Then you'll see that the 'Aready validated discharges' appear within the white page section. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143861|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 143866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143866&action=edit Bug 32199: Add page-section to various patron pages This patch adds a .page-section div to various patron-related pages in order to provide a consistent page structure. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Patrons -> Patron details -> - Files - Holds history - ILL request history - Notices - Purchase suggestions - Routing lists - Statistics - Staff interface home page -> Discharge requests pending Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143861|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143866|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143861|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143867&action=edit Bug 32199: Add page-section to various patron pages This patch adds a .page-section div to various patron-related pages in order to provide a consistent page structure. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Patrons -> Patron details -> - Files - Holds history - ILL request history - Notices - Purchase suggestions - Routing lists - Statistics - Staff interface home page -> Discharge requests pending Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143862|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143868&action=edit Bug 32199: (follow-up) Add page-section to circulation history Note: There is a trick here. If OnsiteCheckouts are active, the circulation history will be tabbed and not use page-section. If the pref is off, you'll see the page-section with this patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143863|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143869&action=edit Bug 32199: (follow-up) Add page-section to list of validated discharges This requires that a discharge is added to the patron account first. Then you'll see that the 'Aready validated discharges' appear within the white page section. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143867|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 143870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143870&action=edit Bug 32199: Add page-section to various patron pages This patch adds a .page-section div to various patron-related pages in order to provide a consistent page structure. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Patrons -> Patron details -> - Files - Holds history - ILL request history - Notices - Purchase suggestions - Routing lists - Statistics - Staff interface home page -> Discharge requests pending Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143868|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 143871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143871&action=edit Bug 32199: (follow-up) Add page-section to circulation history Note: There is a trick here. If OnsiteCheckouts are active, the circulation history will be tabbed and not use page-section. If the pref is off, you'll see the page-section with this patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143869|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 143872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143872&action=edit Bug 32199: (follow-up) Add page-section to list of validated discharges This requires that a discharge is added to the patron account first. Then you'll see that the 'Aready validated discharges' appear within the white page section. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32201 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199 Bug 32199 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org