[Bug 17882] New: C4::Installer::PerlModules::version_info() drops data during error handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 Bug ID: 17882 Summary: C4::Installer::PerlModules::version_info() drops data during error handling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt@gmail.com Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org If you try something like the following when DateTime isn't installed, instead of seeing the Perl dependency information, you'll see nulls and hard-coded defaults. my $version_check = $modules->version_info('module'=>"DateTime"); This is only a problem when using version_info with the module parameter. The "all" parameter (as used by koha_perl_deps.pl) works fine. It looks like a simple copy/paste error, so I'll post a patch for this too soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17880 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 [Bug 17880] C4::Installer::PerlModules lexicographical comparison is incorrect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 58851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58851&action=edit Bug 17882 - Add missing module test to Installer_PerlModules.t Adds a test that checks the values declared for a missing Perl dependency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 58852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58852&action=edit Bug 17882 - Fix C4::Installer::PerlModules::version_info() If you're doing version_info() for a single uninstalled module, you'll currently get null values and default values instead of the values defined in C4::Installer::PerlDependencies. This patch fixes the variable name for the module, and that allows the correct data to be used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58852|0 |1 is obsolete| | --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 58853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58853&action=edit Bug 17882 - Fix C4::Installer::PerlModules::version_info() If you're doing version_info() for a single uninstalled module, you'll currently get null values and default values instead of the values defined in C4::Installer::PerlDependencies. This patch fixes the variable name for the module, and that allows the correct data to be used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58851|0 |1 is obsolete| | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 58854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58854&action=edit Bug 17882 - Add missing module test to Installer_PerlModules.t Adds a test that checks the values declared for a missing Perl dependency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58853|0 |1 is obsolete| | --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Created attachment 58855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58855&action=edit Bug 17882 - Fix C4::Installer::PerlModules::version_info() If you're doing version_info() for a single uninstalled module, you'll currently get null values and default values instead of the values defined in C4::Installer::PerlDependencies. This patch fixes the variable name for the module, and that allows the correct data to be used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Test Plan: 1) Apply patch "Bug 17882 - Add missing module test to Installer_PerlModules.t". 2) Run "perl t/Installer_PerlModules.t" 3) Note the following at the end of the test output: not ok 18 - Minimum version found for missing module # Failed test 'Minimum version found for missing module' # at t/Installer_PerlModules.t line 48. # got: undef # expected: '0.9.3' # Looks like you planned 17 tests but ran 18. # Looks like you failed 1 test of 18 run. 4) Apply patch "Bug 17882 - Fix C4::Installer::PerlModules::version_info()". 5) Run "perl t/Installer_PerlModules.t" 6) Note the following at the end of the test output: ok 18 - Minimum version found for missing module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17880 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 [Bug 17880] C4::Installer::PerlModules lexicographical comparison is incorrect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Arg... just noticed the usage doesn't show up for upgrades and installed modules... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17887 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #8 from David Cook <dcook@prosentient.com.au> --- *** This bug has been marked as a duplicate of bug 17990 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org