[Bug 22288] New: does not work in modifying items in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Bug ID: 22288 Summary: does not work in modifying items in batch Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: federicoantoniopaiz@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Target Milestone: --- Created attachment 84847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84847&action=edit screen in going through txt the inventory ( Home › Tools › Batch item modification ), it gives me as a result : Can't use string ("0") as an ARRAY ref while "strict refs" in use at /usr/share/koha/intranet/cgi-bin/tools/batchMod.pl line 251, <$fh> line 69. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What did your .txt file look like? Where there any empty lines or 0 in lines? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|does not work in modifying |Barcode file does not work |items in batch |in modifying items in batch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 --- Comment #2 from Federico Paiz <federicoantoniopaiz@gmail.com> --- Created attachment 84848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84848&action=edit txt it looks like this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 --- Comment #3 from Federico Paiz <federicoantoniopaiz@gmail.com> --- the code is fine? /usr/share/koha/intranet/cgi-bin/tools/batchMod.pl @contentlist = uniq @contentlist; if ($filecontent eq 'barcode_file') { my $existing_items = Koha::Items->search({ itemnumber =>\@contentlist }); @itemnumbers = $existing_items->get_column('itemnumber'); my %exists = map {$_=>1}@{$existing_items->get_column('barcode')}; @notfoundbarcodes = grep { !$exists{$_} } @contentlist; } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 87571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87571&action=edit Bug 22288: Correct item search in batchMod by barcode file To test: 1 - Have a list of barcodes that exist in your catalog 2 - Go to Tools->Batch item modification 3 - Attempt to modify items using the list 4 - Get an error page 5 - Apply patch 6 - Repeat 7 - Modification should work correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |bwsdonna@gmail.com, | |nick@bywatersolutions.com Depends on| |21183 Severity|enhancement |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87571|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87579&action=edit Bug 22288: Correct item search in batchMod by barcode file To test: 1 - Have a list of barcodes that exist in your catalog 2 - Go to Tools->Batch item modification 3 - Attempt to modify items using the list 4 - Get an error page 5 - Apply patch 6 - Repeat 7 - Modification should work correctly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Silly error, going straight for QA on this one.. No regressions found. Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #8 from Magnus Enger <magnus@libriotech.no> --- I can confirm that this fix also works on 18.11.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependecny, not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org