[Bug 25269] New: MARC21slim2OPACResults.xsl does not display all formats (physical descriptions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 Bug ID: 25269 Summary: MARC21slim2OPACResults.xsl does not display all formats (physical descriptions) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In MARC21slim2OPACResults.xsl we set the 'Format' or physical description by a combination of the 007 first position and 007 second position. In most cases this displays some text (example: chip cartridge or magneto-optical disc) But some set an png icon instead of any text. Like: <img src="/opac-tmpl/lib/famfamfam/world.png" alt="earth moon globe" class="format"/> These will not display at all that is because of this: <xsl:if test="string-length(normalize-space($physicalDescription))"> <span class="results_format"> <span class="label">; Format: </span><xsl:copy-of select="$physicalDescription"></xsl:copy-of> </span> </xsl:if> Without any text the string length is 0 and nothing at all displays. We need to add text along with each png icon. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- To Recreate: 1. Edit a record to have the first and second postions in the 008 = 'cb'. 2. Load the OPAC results page and this record should display: Format: chip cartridge 3. Now try first and second positions in the 008 = 'co' 4. This should an optical disc png (/opac-tmpl/lib/famfamfam/cd.png) but nothing displays because the string length is 0. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 103607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103607&action=edit Bug 25269: Add text along with icons for physical descriptions 1. Edit a record to have the first and second postions in the 008 = 'cb'. 2. Load the OPAC results page and this record should display: Format: chip cartridge 3. Now try first and second positions in the 008 = 'co' 4. This should an optical disc png (/opac-tmpl/lib/famfamfam/cd.png) but nothing displays because the string length is 0. 5. Apply patch 6. Record with first and second positions in the 008 = 'co' should now should text and icon. 7. Look at patch and make sure other changed parts also work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Component|Staff Client |OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- There are some inconsistencies between the OPAC and staff XSLT in this area. I have opened bug 25270. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 Annette <amegneys@coloradocollege.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amegneys@coloradocollege.ed | |u --- Comment #4 from Annette <amegneys@coloradocollege.edu> --- The material type "Music" has a number of different formats. When a search for a certain item returns results for different formats for the same item (e.g., Gershwin recording of "Swanee") the list could contain a sound disc, roll, and a cassette. It is helpful to be able to tell right away from the results list which formats are available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
1. Edit a record to have the first and second postions in the 008 = 'cb'.
You mean 007 right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 105092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105092&action=edit screenshot showing the optical disc when it shouldn't happen on step 4 of test plan No issues until this step:
4. This should an optical disc png (/opac-tmpl/lib/famfamfam/cd.png) but nothing displays because the string length is 0.
As the attached screenshot shows, the optical disc image is already there! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Victor, looking at the patch, I think this is about displaying the description text, not about the icons. I am setting to to FQA as I think we should fix the commit message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 007 vs. 008 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- I think this can be marked as invalid. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org