[Bug 23926] New: In EDI Order limit GIR segment to five pieces of information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 Bug ID: 23926 Summary: In EDI Order limit GIR segment to five pieces of information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org In the specification for the GIR segment it states If there are more than five items of information for one copy or for one part order, the segment may be repeated with the same copy or part-order sequence number in DE 7297 This was something we initially did not need to do as we have limited locations to store GIR data. This is no longer the case as some sites are using this for other data codes, so we need to implement the standard format -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Severity|enhancement |normal --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- note some suppliers' software cannot process orders containing incorrectly formatted GIR segments -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 94874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94874&action=edit Patch correcting GIR format and test cases To test - Tests of the functionality in t/Ediorder.t, as routine does not require db connection can run in a development environment -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Adding Kyle to the CC list as one of the few other people out there able to work on and test EDI patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #3)
Adding Kyle to the CC list as one of the few other people out there able to work on and test EDI patches.
This change will not affect the EDI plugins I maintain. In fact, in my plugins I made the GIR subfield limit configurable, as some vendors require the 5 field limit and so do not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94874|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100338&action=edit Bug 23926 Limit GIR segment to 5 pieces of info Strictly if a GIR segment contains more than 5 pieces of information the it should be encoded in repeated segments each of 5 elements or less each sharing the same copy sequence number Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm going to knock this one up to PQA as the two people most authoritative about EDI have now been involved :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #8 from Joy Nelson <joy@bywatersolutions.com> --- I get a Fail on qa when applying this patch FAIL Koha/Edifact/Order.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage FAIL spelling dont ==> don't dont ==> don't dont ==> don't dont ==> don't OK valid not backporting to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org