[Bug 39779] New: Table.row.add error in Point of Sale table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Bug ID: 39779 Summary: Table.row.add error in Point of Sale table Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Point of Sale Assignee: Laura.escamilla@bywatersolutions.com Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk To recreate: 1. In K-T-D set up POS module with a cash register and configure an item for sale. 2. Attempt to add the configured item for purchase. The console log will show: "Uncaught TypeError: table.row is undefined" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 181682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181682&action=edit Bug 39779: Updated table type To test: 1. In K-T-D set up POS module with a cash register and configure an item for sale. 2. Attempt to add the configured item for purchase. The console log will show: "Uncaught TypeError: table.row is undefined" 3. Apply the patch 4. Refresh the page. 5. Repeat step 2. You are now able to add the configured item for purchase. You can also remove it or go through with the full transaction. 6. Sign off and have an incredible day! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181682|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 181686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181686&action=edit Bug 39779: Updated table type To test: 1. In K-T-D set up POS module with a cash register and configure an item for sale. 2. Attempt to add the configured item for purchase. The console log will show: "Uncaught TypeError: table.row is undefined" 3. Apply the patch 4. Refresh the page. 5. Repeat step 2. You are now able to add the configured item for purchase. You can also remove it or go through with the full transaction. 6. Sign off and have an incredible day! :D Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181686|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181870&action=edit Bug 39779: Updated table type To test: 1. In K-T-D set up POS module with a cash register and configure an item for sale. 2. Attempt to add the configured item for purchase. The console log will show: "Uncaught TypeError: table.row is undefined" 3. Apply the patch 4. Refresh the page. 5. Repeat step 2. You are now able to add the configured item for purchase. You can also remove it or go through with the full transaction. 6. Sign off and have an incredible day! :D Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181871&action=edit Bug 39779: (QA follow-up) Undo revert and instead call .api() This patch leaves Laura's patch intact for the record, but effectively reverts it's reversion of bug 38255 in which all ajax DataTables were converted to a standard kohaTable instantiation structure. We need a DataTable() api in subsequent uses of the table and not the jQuery object that kohaTable returns so I update all calls to saleDataTable to sale_kohaTable.api() which returns us the DataTable() api instance from the dataTable jQuery object. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 [Bug 38255] Do not use dataTable constructor directly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Table.row.add error in |Table.row.add error in |Point of Sale table |point of sale table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38255 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Bug 39779 depends on bug 38255, which changed state. Bug 38255 Summary: Do not use dataTable constructor directly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |andrew.auld@openfifth.co.uk --- Comment #7 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Architectural change. Does not need documentation. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org