http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 --- Comment #1 from Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> --- Created attachment 29619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29619&action=edit When doing aquisitions and ordering from external z3950 targes, the item price is not inferred from the MARC record when the NORMARC framework is set. This patch makes GetMarcPrice treat NORMARC the same as MARC21. Test plan * Setup Koha with NORMARC framework * Add a norwegian z3950 search target (ex: z3950.bibsys.no:2100, database=BIBSYS) * Create a new basket, and add order to basket from external source * Search for a tile (ex: ISBN 8205341834) from the bibsys z3950 server * Click to order the title * Observe that vendor price is not set * Apply patch, repeat search for same book * Order, and observe the vendor price is filled in from the MARC record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30152|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30170&action=edit [PASSED QA] Bug 12554: Fix GetMarcPrice for NORMARC When doing aquisitions and ordering from external z3950 targes, the item price is not inferred from the MARC record when the NORMARC framework is set. This patch makes GetMarcPrice treat NORMARC the same as MARC21. Test plan * Setup Koha with NORMARC framework * Add a norwegian z3950 search target (ex: z3950.bibsys.no:2100, database=BIBSYS) * Create a new basket, and add order to basket from external source * Search for a tile (ex: ISBN 8205341834) from the bibsys z3950 server * Click to order the title * Observe that vendor price is not set * Apply patch, repeat search for same book * Order, and observe the vendor price is filled in from the MARC record http://bugs.koha-community.org/show_bug.cgi?id=12554 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described. No errors. Tested changing marcflavour syspref to NORMARC, and following test plan, bug exist and is fixed. Changed bug description on patch, too long :) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch adds a check for NORMARC to provide the same functionality as for MARC21. No regressions found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |12672 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm sorry I blocked this, but writing the regression tests lead to another bug, which is solved at bug 12672. Unit tests couldn't be written without that patch because they would make the GetMarcISBN tests fail (adding subfield $c to 020 or its UNIMARC counterpart). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Petter! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.