[Bug 34334] New: Item(s) in MARCdetail untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Bug ID: 34334 Summary: Item(s) in MARCdetail untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr I'm trying to find the string Item(s) for the items tab in the MARC view in the staff interface and it doesn't look like it's in the po files anymore. To get there: 1. View any record in the staff interface 2. Click "MARC" on the left --> Item(s) tab 3. Install new language 3.1. Run the following commands in the terminal (replace fr-CA by any language code) cd misc/translator ./translate install fr-CA 3.2. In the staff interface, go to Administration > System preferences 3.3. Search for language 3.4. Check the box for the new language 3.5. Click Save all I18N//L10N preferences 4. Switch the staff interface to the new language 5. Refresh the MARC view page --> Item(s) tab still in English 6. In the terminal, search the .po files for the "Item(s)" string --> String not in the files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tried adding a span tag around the word in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt (line 146), but it's still not picking it up... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Severity|enhancement |normal Status|NEW |ASSIGNED Depends on| |33185 Version|unspecified |master Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185 [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153775&action=edit Bug 34334: Item(s) in MARCdetail untranslatable This patch adds a <span> around the text "Item(s)" in the template for the MARC detail page in the staff interface. Without the span the translation tool can't detect the string. To test, apply the patch and update a translation, e.g. fr-FR:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the string is now in the .po file for translation. You should find these lines: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt:146 c-format msgid "Item(s)" msgstr "Exemplaire(s)" I found that the translation was already populated. Install the updated po file:
perl translate install fr-FR
Test the MARC detail page in your translated language to confirm that the string is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Caroline Cyr La Rose from comment #1)
I tried adding a span tag around the word in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt (line 146), but it's still not picking it up...
It worked for me! Give it a try and let me know if you're not getting the same result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153775|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 153794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153794&action=edit Bug 34334: Item(s) in MARCdetail untranslatable This patch adds a <span> around the text "Item(s)" in the template for the MARC detail page in the staff interface. Without the span the translation tool can't detect the string. To test, apply the patch and update a translation, e.g. fr-FR:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the string is now in the .po file for translation. You should find these lines: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt:146 c-format msgid "Item(s)" msgstr "Exemplaire(s)" I found that the translation was already populated. Install the updated po file:
perl translate install fr-FR
Test the MARC detail page in your translated language to confirm that the string is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item(s) in MARCdetail |'Item(s)' in MARC detail |untranslatable |view untranslatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153794|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153795&action=edit Bug 34334: Item(s) in MARCdetail untranslatable This patch adds a <span> around the text "Item(s)" in the template for the MARC detail page in the staff interface. Without the span the translation tool can't detect the string. To test, apply the patch and update a translation, e.g. fr-FR:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the string is now in the .po file for translation. You should find these lines: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt:146 c-format msgid "Item(s)" msgstr "Exemplaire(s)" I found that the translation was already populated. Install the updated po file:
perl translate install fr-FR
Test the MARC detail page in your translated language to confirm that the string is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thank you Owen! I'm stumped as to why it didn't work for me yesterday. My working hypothesis right now is that I was too tired and probably mangled the commands to translate. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.03 |23.11.00,23.05.03,22.11.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Missing 22.05.x dependencies. No backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org