[Bug 40589] New: Add table settings to recalls pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 Bug ID: 40589 Summary: Add table settings to recalls pages Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com I propose to add table settings to these pages: - Recalls queue - Recalls to pull - Overdue recalls - Recalls awaiting pickup - Old recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |Recalls function| | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40567, 40568, 27934, 40566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27934 [Bug 27934] Table sorting using title-string option is obsolete https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40566 [Bug 40566] "Home library" empty on "Recalls history" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40567 [Bug 40567] Correct eslint errors in recalls.js https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 [Bug 40568] Various corrections to recalls templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185107&action=edit Bug 40589: Add table settings to recalls pages To test, apply the patch restart services. - Enable recalls if necessary. - You should create some recalls data to test with: - Place multiple recalls from the OPAC. - Go to Circulation -> Recalls queue and use the "Actions" menu to mark multiple recalls as overdue. - Check in multiple titles with recalls. - Cancel multiple recalls or complete some recalls by checking them out to the patron who requested them. - Page to test: - Recalls queue - Recalls to pull - Overdue recalls - Recalls awaiting pickup - Old recalls - Checkout page, recalls tab - Patron details page, recalls tab - Test each modified page to confirm that DataTables features work correctly: Filtering, paging, sorting, export, column configuration. - Go to Administration -> Table settings -> Circulation -> Recalls and change the table configuration in some way for each recall table. - View each recalls page to confirm that those defaults are shown. (You may need to use your browser's developer tools to delete saved table configuration in local storage). Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Needs Signoff |Failed QA --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- This patch introduces a new occurrence of title-string (removed on bug 27934) + columnDefs: [{ type: "title-string", targets: ["title-string"] }], -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185107|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 186900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186900&action=edit Bug 40589: Add table settings to recalls pages To test, apply the patch restart services. - Enable recalls if necessary. - You should create some recalls data to test with: - Place multiple recalls from the OPAC. - Go to Circulation -> Recalls queue and use the "Actions" menu to mark multiple recalls as overdue. - Check in multiple titles with recalls. - Cancel multiple recalls or complete some recalls by checking them out to the patron who requested them. - Page to test: - Recalls queue - Recalls to pull - Overdue recalls - Recalls awaiting pickup - Old recalls - Checkout page, recalls tab - Patron details page, recalls tab - Test each modified page to confirm that DataTables features work correctly: Filtering, paging, sorting, export, column configuration. - Go to Administration -> Table settings -> Circulation -> Recalls and change the table configuration in some way for each recall table. - View each recalls page to confirm that those defaults are shown. (You may need to use your browser's developer tools to delete saved table configuration in local storage). Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186900|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191882&action=edit Bug 40589: Add table settings to recalls pages To test, apply the patch restart services. - Enable recalls if necessary. - You should create some recalls data to test with: - Place multiple recalls from the OPAC. - Go to Circulation -> Recalls queue and use the "Actions" menu to mark multiple recalls as overdue. - Check in multiple titles with recalls. - Cancel multiple recalls or complete some recalls by checking them out to the patron who requested them. - Page to test: - Recalls queue - Recalls to pull - Overdue recalls - Recalls awaiting pickup - Old recalls - Checkout page, recalls tab - Patron details page, recalls tab - Test each modified page to confirm that DataTables features work correctly: Filtering, paging, sorting, export, column configuration. - Go to Administration -> Table settings -> Circulation -> Recalls and change the table configuration in some way for each recall table. - View each recalls page to confirm that those defaults are shown. (You may need to use your browser's developer tools to delete saved table configuration in local storage). Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- I think we should start adding bKohaColumnsUseNames everywhere, and so it should be required for new additions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 Anna Leißle <anna.leissle@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anna.leissle@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #6 from Anna Leißle <anna.leissle@bsz-bw.de> --- (In reply to Owen Leonard from comment #3)
- Go to Circulation -> Recalls queue and use the "Actions" menu to mark multiple recalls as overdue. - Check in multiple titles with recalls.
There is no option to mark the recalls as overdue in the action menu, are we missing a step or a setting? The only option we can choose is cancel. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Please remember than column visibility and state will be broken if you don't set bKohaColumnsUseNames. You also need to display all the columns, always, but hide their content when needed. eg. [% UNLESS specific_patron %]<th data-colname="requested_by" class="recall-patron">Requested by</th>[% END %] This must be: <th data-colname="requested_by" class="recall-patron">Requested by</th> then you remove the date in the td. And finally you deal with the visibility in the JS part before you pass table_settings to kohaTable (`git grep force_visibility` and see also bug 41604). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 Bug 40589 depends on bug 40566, which changed state. Bug 40566 Summary: "Home library" empty on "Recalls history" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40566 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 Bug 40589 depends on bug 40567, which changed state. Bug 40567 Summary: Correct eslint errors in recalls.js https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40567 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org