[Bug 32179] New: ERM is missing page-sections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 Bug ID: 32179 Summary: ERM is missing page-sections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Depends on: 30952, 32030 Blocks: 31757 The newly added ERM module is missing appropraite page-section containers. This is required to improve contrast in table row highlighting and brings more consistency to our UI. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143791&action=edit Bug 32179: Add page-sections as appropraite to the ERM module We missed the page-section addition when ERM was updated for the new UI prior to push. Test plan 1) Start a koha-testing-docker 2) Build the ERM module with 'kshell > yarn install > yarn build_js' 3) Enable the ERM module via the system preferences 4) Enable both 'EBSCO' and 'Local' as providers 4) Check the following pages * ERM > Agreements * ERM > Licenses * ERM > eHoldings > Local > Packages * ERM > eHoldings > Local > Titles * ERM > eHoldings > Local > Titles > Add from a list * ERM > eHoldings > EBSCO > Packages * ERM > eHoldings > EBSCO > Titles 5) Apply this patch 6) Build the app again 'yarn build_js' 7) Confirm page-sections appear as expected on the pages mentioned in step 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143791|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 143793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143793&action=edit Bug 32179: Add page-sections as appropraite to the ERM module We missed the page-section addition when ERM was updated for the new UI prior to push. Test plan 1) Start a koha-testing-docker 2) Build the ERM module with 'kshell > yarn install > yarn build_js' 3) Enable the ERM module via the system preferences 4) Enable both 'EBSCO' and 'Local' as providers 4) Check the following pages * ERM > Agreements * ERM > Licenses * ERM > eHoldings > Local > Packages * ERM > eHoldings > Local > Titles * ERM > eHoldings > Local > Titles > Add from a list * ERM > eHoldings > EBSCO > Packages * ERM > eHoldings > EBSCO > Titles 5) Apply this patch 6) Build the app again 'yarn build_js' 7) Confirm page-sections appear as expected on the pages mentioned in step 4. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: Run prettier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143793|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143801&action=edit Bug 32179: Add page-sections as appropraite to the ERM module We missed the page-section addition when ERM was updated for the new UI prior to push. Test plan 1) Start a koha-testing-docker 2) Build the ERM module with 'kshell > yarn install > yarn build_js' 3) Enable the ERM module via the system preferences 4) Enable both 'EBSCO' and 'Local' as providers 4) Check the following pages * ERM > Agreements * ERM > Licenses * ERM > eHoldings > Local > Packages * ERM > eHoldings > Local > Titles * ERM > eHoldings > Local > Titles > Add from a list * ERM > eHoldings > EBSCO > Packages * ERM > eHoldings > EBSCO > Titles 5) Apply this patch 6) Build the app again 'yarn build_js' 7) Confirm page-sections appear as expected on the pages mentioned in step 4. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Minor rebase (and now I have the prettier git hook :) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179 Bug 32179 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org