[Bug 21880] New: "Relationship information" disappears when accessing paginated results in authority searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Bug ID: 21880 Summary: "Relationship information" disappears when accessing paginated results in authority searches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: arouss1980@gmail.com QA Contact: testopia@bugs.koha-community.org In the Staff client (under Home > Authorities), edit an authority and try to link it with another authority: if your search returns more than 20 results, the Relationship information section of the Authority search window disappears when you click the pagination hyperlinks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |authorities/auth_finder.pl Priority|P5 - low |P3 Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |arouss1980@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 --- Comment #1 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 82619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82619&action=edit Bug 21880: "Relationship information" disappears when accessing paginated results in authority searches When linking authorities with authorities, if you perform a search that returns >20 results, the "Relationship information" section disappears when you click on the pagination hyperlinks. This patch fixes that. Test plan: 1) In the Authorities module, edit an authority (or create a new one) and try to link it with another authority (via UNIMARC 500$a, for example). 2) When the authority finder comes up, search for something that will yield more than 20 results, then click on the pagination links -- notice how the "Relationship information" section is no longer visible. 3) Apply the patch (and restart Plack/memcached, if necessary). 4) Repeat step 2) -- "Relationship information" is now persistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21453 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21453 [Bug 21453] blinddetail-biblio-search.pl/.tt use hardcoded subfield values for MARC21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Related bug? If I have resultsperpage==2 and 3 hits, I see 2 hits on first page and 2 hits on second page.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I am trying to reproduce this under MARC21 with 400 but somehow i do not succeed to. Please clarify. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 --- Comment #5 from Andreas Roussos <arouss1980@gmail.com> --- (In reply to Marcel de Rooy from comment #3)
Related bug? If I have resultsperpage==2 and 3 hits, I see 2 hits on first page and 2 hits on second page.. Confirmed, good catch! Unfortunately, I don't know how to fix what you observed. FWIW, a similar issue has been raised (Bug 21405) to deal with broken pagination in authorities search via the main page of authorities (i.e. in Home > Authorities).
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 --- Comment #6 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 82649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82649&action=edit Cataloging authority plugin search in page 1 of results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 --- Comment #7 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 82650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82650&action=edit Cataloging authority plugin search in page 2 of results -- You are receiving this mail because: You are watching all bug changes.
I am trying to reproduce this under MARC21 with 400 but somehow i do not succeed to. Please clarify. I've set up a sandbox using ByWater Solutions' sandboxes and took a couple of screenshots for you while trying to link a PERSO_NAME authority to another authority using MARC21 tag 400. Please find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 --- Comment #8 from Andreas Roussos <arouss1980@gmail.com> --- (In reply to Marcel de Rooy from comment #4) them attached to this bug report. Basically, you need to click on the ellipsis (...) next to field 400$a, then search for something that will yield lots of results (or you can just hit 'Search' without passing any search strings). Then, if you click on any of the pagination links, you'll see that the "Relationship information" section is gone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82619|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 83173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83173&action=edit Bug 21880: "Relationship information" disappears when accessing paginated results in authority searches When linking authorities with authorities, if you perform a search that returns >20 results, the "Relationship information" section disappears when you click on the pagination hyperlinks. This patch fixes that. Test plan: 1) In the Authorities module, edit an authority (or create a new one) and try to link it with another authority (via UNIMARC 500$a, for example). 2) When the authority finder comes up, search for something that will yield more than 20 results, then click on the pagination links -- notice how the "Relationship information" section is no longer visible. 3) Apply the patch (and restart Plack/memcached, if necessary). 4) Repeat step 2) -- "Relationship information" is now persistent. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 83174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83174&action=edit Bug 21880: (follow-up) Add some uri filters Theoretically, source needs a filter. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Andreas Roussos from comment #8)
I am trying to reproduce this under MARC21 with 400 but somehow i do not succeed to. Please clarify. I've set up a sandbox using ByWater Solutions' sandboxes and took a couple of screenshots for you while trying to link a PERSO_NAME authority to another authority using MARC21 tag 400. Please find
(In reply to Marcel de Rooy from comment #4) them attached to this bug report.
Basically, you need to click on the ellipsis (...) next to field 400$a, then search for something that will yield lots of results (or you can just hit 'Search' without passing any search strings). Then, if you click on any of the pagination links, you'll see that the "Relationship information" section is gone.
Thx for additional explanation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Sending this one directly to PQA. Trivial fix adding the source parameter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- does not apply cleaning to 18.05 please rebase if needed in 18.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org