[Bug 10531] New: Basket name and PO number on receipt screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Bug ID: 10531 Summary: Basket name and PO number on receipt screen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: amitddng135@gmail.com To list the basket name or PO number on the receipt screen to identify the lot that you are receiving -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com QA Contact| |amitddng135@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com --- Comment #1 from Amit <amitddng135@gmail.com> --- Created attachment 20285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20285&action=edit Basket name and PO number on receipt screen To list the basket name or PO number on the receipt screen to identify the lot that you are receiving Test Plan: 1) Create an basket 2) Create an order 3) Click on Receive shipment button enter vendor invoice no and shipment date click on Next button. 4) Basket name and Purchase order number will display both in pending and already receive screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20285|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20636&action=edit [SIGNED-OFF] Bug 10531 - Basket name and PO number on receipt screen To list the basket name or PO number on the receipt screen to identify the lot that you are receiving Test Plan: 1) Create an basket 2) Create an order 3) Click on Receive shipment button enter vendor invoice no and shipment date click on Next button. 4) Basket name and Purchase order number will display both in pending and already receive screen. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Two minor edits on signoff: Changed "basketname" to "basket name," and converted tabs to spaces on added lines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: 1/ This patch breaks sorts on the already received table. 2/ The sort on the basket name column does not work (on the Pending orders table). 3/ Prefer to list the fields you want for the aqbasket table: + SELECT aqorders.*, biblio.*, aqbasket.* + SELECT aqorders.*, biblio.*, aqbasket.purchase_order, aqbasket.basketname Marked as Failed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- In fact, there is a js error on this page: ReferenceError: YAHOO is not defined Already exists on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #4)
In fact, there is a js error on this page: ReferenceError: YAHOO is not defined
Already exists on master.
error caused by the following line: <script type="text/javascript" src="[% yuipath %]/json/json-min.js"></script> It could be removed (see bug 10786). But this patch adds another one: TypeError: a.aoColumns[c] is undefined which does not exist on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Amit <amitddng135@gmail.com> --- Hi Jonathan, I cannot find any error in this patch. Can you please explain me in detail. Mean while i am changing the status of the patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Amit from comment #6)
Hi Jonathan,
I cannot find any error in this patch. Can you please explain me in detail. Mean while i am changing the status of the patch.
Amit, To reproduce: Open firebug, Go on acqui/parcel.pl?invoiceid=X, you will see a JS error: "TypeError: a.aoColumns[c] is undefined". When you add a new column in a table managed by DataTables, you should adapt the aoColumns values. Back to assigned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |amitddng135@gmail.com |ity.org | QA Contact|amitddng135@gmail.com | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org