[Bug 7602] New: Spent and Ordered pages require full acquisition permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Bug #: 7602 Summary: Spent and Ordered pages require full acquisition permissions Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha.sekjal@gmail.com The spent and ordered pages linked from the funds table on acquisition home page require full (all) acquisition rights. Patch will change the required permission, so that one permission in acquisition will be enough to access the pages. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-26 06:13:43 UTC --- Created attachment 7883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7883 Bug 7602: Spent and ordered pages require full acquisition permissions Changes permissions on these pages so that one acquisition permission will make it possible to access the pages. Currently pages are only accessible for users with full (all checkboxes checked) acquisition permissions. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff AssignedTo|henridamien@koha-fr.org |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7883|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2012-02-26 21:19:59 UTC --- Created attachment 7895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7895 [SIGNED-OFF] Bug 7602: Spent and ordered pages require full acquisition permissions Changes permissions on these pages so that one acquisition permission will make it possible to access the pages. Currently pages are only accessible for users with full (all checkboxes checked) acquisition permissions. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested with only one acquisitions permission (various choices) and patron can access the ordered and spent pages. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-03-01 14:51:45 UTC --- QA Comment: The proposed patch works as expected. But on the ordered.pl page, there is a link to neworderempty.pl. This one is strictly accessible if you have the order_manage permission. Shouldn't the permission be order_manage for these 2 pages ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-03-01 14:58:45 UTC --- Hi Jonathan, that's a good question. I figured that it would not hurt to make it accessible to users with 1 acq permission, because it's only a report. You can't change order or budget information from that page. As an enhancement the links could be hidden, if you lack the proper permission (order_manage). I am not sure how others think about this - perhaps we can do a quick poll? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2012-03-01 17:11:28 UTC --- I'm with Katrin, I think that it could be enhanced, but I'm not sure it should hold this patch back. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I looked at the permission table again, because I wanted to change to your suggestion. But I am not sure order_manage is the way to go. There are lots of reasons why this information could be important for people with other acq permissions: - order_receive - find out what has not been delivered yet - budget_* - checking what the money is being spent for - order_manage - ... - ... I wonder if someone without any of these permissions will have access to acquisitions at all? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 7979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7979&action=edit Bug 7602: Followup: Spent and ordered pages require full acquisition permissions Bug 7602: Followup: Spent and ordered pages require full acquisition permissions hide link to neworderempty if user does not have order_manage permission It seems this patch is a response for our problem :) What do you think about it ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's a good thing - but we should change the spent page to take permissions into account too. There is a link to the receive page that should depend on the right permission. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7979|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8029&action=edit [SIGNED-OFF] Bug 7602: Followup: Spent and ordered pages require full acquisition permissions hide link to neworderempty if user does not have order_manage permission Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Ian Walls <koha.sekjal@gmail.com> --- First patch: simple change to permissions. Passed QA Second patch: adds conditional to template to links only show if they're relevant to the user. Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Blocks| |929 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8029|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7895|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch for "spent" still missing, so obsoleting patches and changing status to reflect that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We could be more strict like only showing the link to the invoice if the user has the corresponding permission, but I will move this idea to a separate bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- After looking at the pages: The only links on the ordered page are to the vendor and to the invoice page - both are accessible with * (any acq permission). So I think there are no more changes needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org