http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9331 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9331 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Failed to mention in my commit message: I also made a couple of trivial JSHint-recommended corrections. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9331 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14341|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14349&action=edit Bug 9331 - Untranslatable strings in ajax.js This patch moves untranslatable strings from ajax.js into the template where they can be picked up by the translation script. To test that preference-related error messages continue to work, open the system preferences editor in two tabs. Log out in one tab and try to save a system preference in the other. You should see correct error messages. To test that error strings are now translatable, run "perl translate update <lang>" from misc/translator, then check if the affected strings shows up in the po file. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Still works, and is now translatable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9331 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Strings are now translatable. Moreover this patch fixes 2 JS equality and some semi-colons. Marking as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9331 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14349|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14421&action=edit Bug 9331 - Untranslatable strings in ajax.js This patch moves untranslatable strings from ajax.js into the template where they can be picked up by the translation script. To test that preference-related error messages continue to work, open the system preferences editor in two tabs. Log out in one tab and try to save a system preference in the other. You should see correct error messages. To test that error strings are now translatable, run "perl translate update <lang>" from misc/translator, then check if the affected strings shows up in the po file. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Still works, and is now translatable Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.