https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Grace period is used for |Fine grace period in |determining when a |circulation conditions is |suspension will be placed |misnamed --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- After some debugging I realized that the grace period is also substracted from the overdue days before the restriction is calculated: if ( $deltadays->subtract($grace)->is_positive() ) { So we should really kill the "Fine" from "Fine grace period". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144095&action=edit Bug 31233: Amend 'fine grace period' as it's also used for suspensions The grace period setting in circulation rules is not only used for fines, but also for suspensions. So the label 'Fine grace period' is a little misleading. This patch updates it to "Fine/suspension grace period". To test: * Go to Administration > Circulation rules * Verify the description is "Fine grace period" in the big table * Apply patch * Verify the description now changed to "Fine/suspension grace period" https://bugs.koha-community.org/show_bug.cgi?id=32261 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144095|0 |1 is obsolete| | --- Comment #3 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 144114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144114&action=edit Bug 31233: Amend 'fine grace period' as it's also used for suspensions The grace period setting in circulation rules is not only used for fines, but also for suspensions. So the label 'Fine grace period' is a little misleading. This patch updates it to "Fine/suspension grace period". To test: * Go to Administration > Circulation rules * Verify the description is "Fine grace period" in the big table * Apply patch * Verify the description now changed to "Fine/suspension grace period" https://bugs.koha-community.org/show_bug.cgi?id=32261 Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144114|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 144698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144698&action=edit Bug 31233: Amend 'fine grace period' as it's also used for suspensions The grace period setting in circulation rules is not only used for fines, but also for suspensions. So the label 'Fine grace period' is a little misleading. This patch updates it to "Fine/suspension grace period". To test: * Go to Administration > Circulation rules * Verify the description is "Fine grace period" in the big table * Apply patch * Verify the description now changed to "Fine/suspension grace period" https://bugs.koha-community.org/show_bug.cgi?id=32261 Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233 --- Comment #7 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.