[Bug 37334] New: Cannot order/sort holdings table by status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Bug ID: 37334 Summary: Cannot order/sort holdings table by status Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently one is not able to sort the holdings table by status. IN catalogue_detail.inc I see the following: 451 data: "me.lost_status", 452 className: "status", 453 searchable: false, // FIXME We are losing the ability to search on the status 454 orderable: false, 455 render: function (data, type, row, meta) { Setting orderable to true brings back the icons, but I am assuming since this wasn't fixed initially that it is not trivial. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Dani Elder <danielle.elder@law.utexas.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle.elder@law.utexas.e | |du -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #1 from Dani Elder <danielle.elder@law.utexas.edu> --- We do use this feature regularly. Thanks for fixing it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Kris <kbecker@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker@jcls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the staff biblio detail view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot order/sort holdings |Cannot filter holdings |table by status |table by status --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- On bug 33568 I clearly stated that we were loosing the ability to search on the status. """ commit 385048f27ccb5eaeeac2e90130d621305a537960 Bug 33568: Status See the FIXME in the code, we are losing the ability to search on the status, but this is really impossible to implement if we are not storing the status (DB or search engine). """ Actually the search is not impossible, tricky but feasible. However the sort is clearly not possible if we don't store the status (ie. if we keep calculating it on the fly). I think the use cases and the needs are answered with the filtering restored. I am renaming the bug to highlight that, but feel free to open a separate one if it is still problematic. But keep in mind that we need to rethink how/when/where we store and calculate the status, and it's not a trivial change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172300&action=edit Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172301&action=edit Bug 37334: Allow a column filter to be shown even searchable is off We do not want to use the usual filtering method here, we are building the query from "additional filters" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172302&action=edit Bug 37334: Restore filtering holdings per status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- I am not sure this is the best we can do, but it seems to work. I would like, before continuing (or, better, getting help to get it done), to know if Lucas and Dani are happy with this change. Does it answer your needs? There are more TODO: 1. Tests 2. POD 3. Discuss, rename "_status" (?) This is ready for testing, not to be pushed however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- I am waiting for feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks for your work here Jonathan, I really appreciate it. When I apply this patch and attempt to sort the column I get this 500 error: ==> /var/log/koha/kohadev/plack-api-error.log <== [2024/10/07 16:28:03] [ERROR] GET /api/v1/biblios/9/items: unhandled exception (DBIx::Class::Exception)<<DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me' in 'order clause' at /kohadevbox/koha/Koha/Objects.pm line 403>> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass from comment #8)
Thanks for your work here Jonathan, I really appreciate it.
When I apply this patch and attempt to sort the column I get this 500 error:
==> /var/log/koha/kohadev/plack-api-error.log <== [2024/10/07 16:28:03] [ERROR] GET /api/v1/biblios/9/items: unhandled exception (DBIx::Class::Exception)<<DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me' in 'order clause' at /kohadevbox/koha/Koha/Objects.pm line 403>>
Which column? Status is not sortable, and sort on other columns works for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9)
(In reply to Lucas Gass from comment #8)
Thanks for your work here Jonathan, I really appreciate it.
When I apply this patch and attempt to sort the column I get this 500 error:
==> /var/log/koha/kohadev/plack-api-error.log <== [2024/10/07 16:28:03] [ERROR] GET /api/v1/biblios/9/items: unhandled exception (DBIx::Class::Exception)<<DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me' in 'order clause' at /kohadevbox/koha/Koha/Objects.pm line 403>>
Which column? Status is not sortable, and sort on other columns works for me.
Sorry, this is some misunderstanding on my part. I testing the filtering of the Status column and it works great for me. I tested with all the listed statuses. I did file this additional bug for SORTING of the status column: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012 [Bug 7012] Limit to available does not exclude in-transit items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Anni Rajala <anni.rajala@turku.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anni.rajala@turku.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- ping, Lucas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #12 from David Cook <dcook@prosentient.com.au> --- I took a peek at the code, and this will -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #12)
I took a peek at the code, and this will
Slow down things? Yes maybe, but only if you filter on status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 holly@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Everything works great here except for when filtering by not_for_loan status. In that case I seem to get a 500 error: ==> /var/log/koha/kohadev/plack-api-error.log <== [2024/10/25 22:31:33] [ERROR] GET /api/v1/biblios/32/items: unhandled exception (Koha::Exceptions::Object::MethodNotCoveredByTests)<<The method Koha::ItemTypes->column is not covered by tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172300|0 |1 is obsolete| | Attachment #172301|0 |1 is obsolete| | Attachment #172302|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173499&action=edit Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173500&action=edit Bug 37334: Allow a column filter to be shown even searchable is off We do not want to use the usual filtering method here, we are building the query from "additional filters" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173501&action=edit Bug 37334: Restore filtering holdings per status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #14)
Everything works great here except for when filtering by not_for_loan status. In that case I seem to get a 500 error:
==> /var/log/koha/kohadev/plack-api-error.log <== [2024/10/25 22:31:33] [ERROR] GET /api/v1/biblios/32/items: unhandled exception (Koha::Exceptions::Object::MethodNotCoveredByTests)<<The method Koha::ItemTypes->column is not covered by tests!
Fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Ilona R <hattara@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hattara@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #18)
(In reply to Lucas Gass (lukeg) from comment #14)
Everything works great here except for when filtering by not_for_loan status. In that case I seem to get a 500 error:
==> /var/log/koha/kohadev/plack-api-error.log <== [2024/10/25 22:31:33] [ERROR] GET /api/v1/biblios/32/items: unhandled exception (Koha::Exceptions::Object::MethodNotCoveredByTests)<<The method Koha::ItemTypes->column is not covered by tests!
Fixed!
Yes, everything seems to work great now. Can we move this out of 'In discussion', happy to add my sign off at this point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173499|0 |1 is obsolete| | --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 173949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173949&action=edit Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173500|0 |1 is obsolete| | --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 173950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173950&action=edit Bug 37334: Allow a column filter to be shown even searchable is off We do not want to use the usual filtering method here, we are building the query from "additional filters" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173501|0 |1 is obsolete| | --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 173951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173951&action=edit Bug 37334: Restore filtering holdings per status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Things are working, I am signing off to keep this moving. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi Status|Signed Off |Failed QA --- Comment #24 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Tested this and while filtering seems to be working with every other status, available status returns either all items or items with other statuses. E.g. I have an item A with damaged value 2 and item B with all statuses (notforloan, damaged, withdrawn, itemlost, restricted and itype is also available for loan) as 0. Only item A is returned when I filter holdings table with "Available" status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173982&action=edit Bug 37334: Fix logic for not available Several major changes here: * the push @not_availab_itemnumbers for lost, damaged, etc. was totally wrong * not for loan is only for positive values * restricted can be NULL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Emmi Takkinen from comment #24)
Tested this and while filtering seems to be working with every other status, available status returns either all items or items with other statuses.
E.g. I have an item A with damaged value 2 and item B with all statuses (notforloan, damaged, withdrawn, itemlost, restricted and itype is also available for loan) as 0. Only item A is returned when I filter holdings table with "Available" status.
Indeed, lot of wrong logics in the previous version, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |koha-bugs@lists.koha-commun | |ity.org --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- I won't be able to work more on this soon. Feel free to test, but it's not ready for inclusion (hence the previous "In discussion" status). It's missing a lot of tests. Please take over if you are willing to make it move forward. The tests can be interesting to write but I won't have the time during the next weeks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #28 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- *** Bug 38122 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Emmi Takkinen from comment #24)
Tested this and while filtering seems to be working with every other status, available status returns either all items or items with other statuses.
E.g. I have an item A with damaged value 2 and item B with all statuses (notforloan, damaged, withdrawn, itemlost, restricted and itype is also available for loan) as 0. Only item A is returned when I filter holdings table with "Available" status.
I tried to recreate this exact scenario and it seems to work for me. However I did find flaws with the restricted and notforloan filters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174310&action=edit Bug 37334: Fix restricted and notforloan filter logic -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I am going to put this back to into discussion. Emmi, if you get a chance can you test again with my follow-up patches. Like Jonathan said, we'll still need to write a bunch of tests here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #32 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- First patch needed a minor rebase. Filtering with at least "Available", "Checked out", "In transit", "Damaged" and "Lost" status works, but "Not for loan" status doesn't return results if its value starts with -. E.g. I have authorized values 7 "Added to bundle" and -7 "Auton varastossa". Filtering first one works, second doesn't. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38122 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Emmi Takkinen from comment #32)
First patch needed a minor rebase. Filtering with at least "Available", "Checked out", "In transit", "Damaged" and "Lost" status works, but "Not for loan" status doesn't return results if its value starts with -. E.g. I have authorized values 7 "Added to bundle" and -7 "Auton varastossa". Filtering first one works, second doesn't.
Yes, I think it's the correct behaviour. C4/Reserves.pm:1322 $item->notforloan > 0 || # item with negative or zero notforloan value is holdable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m --- Comment #34 from Catrina Berka <catrina@bywatersolutions.com> --- If I filter on Not for Loan, I would expect to see ALL values, positive or negative. Libraries using negative NFL values would want to see copies that may be on order or in processing, in addition to any that are not holdable. The filtering needs to account for any value where NFL != 0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173949|0 |1 is obsolete| | --- Comment #35 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174798&action=edit Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173950|0 |1 is obsolete| | --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174799&action=edit Bug 37334: Allow a column filter to be shown even searchable is off We do not want to use the usual filtering method here, we are building the query from "additional filters" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173951|0 |1 is obsolete| | --- Comment #37 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174800&action=edit Bug 37334: Restore filtering holdings per status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173982|0 |1 is obsolete| | --- Comment #38 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174801&action=edit Bug 37334: Fix logic for not available Several major changes here: * the push @not_availab_itemnumbers for lost, damaged, etc. was totally wrong * not for loan is only for positive values * restricted can be NULL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174310|0 |1 is obsolete| | --- Comment #39 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174802&action=edit Bug 37334: Fix restricted and notforloan filter logic -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #40 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174803&action=edit Bug 37334: Return all non zero notforloan statuses -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #41 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Catrina Berka from comment #34)
If I filter on Not for Loan, I would expect to see ALL values, positive or negative. Libraries using negative NFL values would want to see copies that may be on order or in processing, in addition to any that are not holdable. The filtering needs to account for any value where NFL != 0
Rebased and added a patch, based on Catrina's comment, so the notforloan filter will return ALL nfl statuses, positive or negative. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ephetteplace@cca.edu | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #42 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I am noticing that filtering by available is returning items with a negative notforloan status when it should not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #43 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174804&action=edit Bug 37334: filter_by_available should not return notforloan statues other than 0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174813&action=edit Bug 37334: Add _status tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- There is a few more tests to write here for the 'filter_by*' routines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #46 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174814&action=edit Bug 37334: Add filter_by_checked_out tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #47 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174901&action=edit Bug 37334: Add POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #48 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Jonathan had an empty routine, I removed it. I don't think we need this? sub filter_by_for_loan { } We can already filter by not_for_loan, available, and checked_out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #49 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174902&action=edit Bug 37334: Add filter_by_in_transit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #50 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174903&action=edit Bug 37334: Add filter_by_has_holds tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #51 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Trying to write tests for filter_by_has_recalls made me realize filtering by recalls is working quite right. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #52 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #51)
Trying to write tests for filter_by_has_recalls made me realize filtering by recalls is working quite right.
It is NOT working quite right, fix incoming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38512 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #53 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #52)
(In reply to Lucas Gass (lukeg) from comment #51)
Trying to write tests for filter_by_has_recalls made me realize filtering by recalls is working quite right.
It is NOT working quite right, fix incoming.
filter_by_has_recalls needs to filter by item_level recalls only, anything else should be considered available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #54 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174955&action=edit Bug 37334: Fix filter_by_has_recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #55 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Is this ready for testing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38512 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38512 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38512 [Bug 38512] Item table status column display is wrong when record has recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |BLOCKED --- Comment #56 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Emmi Takkinen from comment #55)
Is this ready for testing?
It is blocked by Bug 38512. I think we need to make sure the display of recalls is correct before we can continue here, please test that one first! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Patch doesn't apply --- Comment #57 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This can be unblocked because Bug 38512 is PQA. It needs rebased on top of that one now, setting to patch doesn't apply and will rebase asap. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174798|0 |1 is obsolete| | --- Comment #58 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175859&action=edit Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174799|0 |1 is obsolete| | --- Comment #59 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175860&action=edit Bug 37334: Allow a column filter to be shown even searchable is off We do not want to use the usual filtering method here, we are building the query from "additional filters" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174800|0 |1 is obsolete| | --- Comment #60 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175861&action=edit Bug 37334: Restore filtering holdings per status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174801|0 |1 is obsolete| | --- Comment #61 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175862&action=edit Bug 37334: Fix logic for not available Several major changes here: * the push @not_availab_itemnumbers for lost, damaged, etc. was totally wrong * not for loan is only for positive values * restricted can be NULL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174802|0 |1 is obsolete| | --- Comment #62 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175863&action=edit Bug 37334: Fix restricted and notforloan filter logic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174803|0 |1 is obsolete| | --- Comment #63 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175864&action=edit Bug 37334: Return all non zero notforloan statuses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174804|0 |1 is obsolete| | --- Comment #64 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175865&action=edit Bug 37334: filter_by_available should not return notforloan statues other than 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174813|0 |1 is obsolete| | --- Comment #65 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175866&action=edit Bug 37334: Add _status tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174814|0 |1 is obsolete| | --- Comment #66 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175867&action=edit Bug 37334: Add filter_by_checked_out tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174901|0 |1 is obsolete| | --- Comment #67 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175868&action=edit Bug 37334: Add POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174902|0 |1 is obsolete| | --- Comment #68 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175869&action=edit Bug 37334: Add filter_by_in_transit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174903|0 |1 is obsolete| | --- Comment #69 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175870&action=edit Bug 37334: Add filter_by_has_holds tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174955|0 |1 is obsolete| | --- Comment #70 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175871&action=edit Bug 37334: Fix filter_by_has_recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #71 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Patches no longer apply. Applying: Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc). error: could not build fake ancestor Patch failed at 0001 Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-37334-Allow-embed-status-for-GET-bibliobiblioi-34QjuN.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175859|0 |1 is obsolete| | --- Comment #72 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175999&action=edit Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175860|0 |1 is obsolete| | --- Comment #73 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176000&action=edit Bug 37334: Allow a column filter to be shown even searchable is off We do not want to use the usual filtering method here, we are building the query from "additional filters" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175861|0 |1 is obsolete| | --- Comment #74 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176001&action=edit Bug 37334: Restore filtering holdings per status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175862|0 |1 is obsolete| | --- Comment #75 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176002&action=edit Bug 37334: Fix logic for not available Several major changes here: * the push @not_availab_itemnumbers for lost, damaged, etc. was totally wrong * not for loan is only for positive values * restricted can be NULL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175863|0 |1 is obsolete| | --- Comment #76 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176003&action=edit Bug 37334: Fix restricted and notforloan filter logic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175864|0 |1 is obsolete| | --- Comment #77 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176004&action=edit Bug 37334: Return all non zero notforloan statuses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175865|0 |1 is obsolete| | --- Comment #78 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176005&action=edit Bug 37334: filter_by_available should not return notforloan statues other than 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175866|0 |1 is obsolete| | --- Comment #79 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176006&action=edit Bug 37334: Add _status tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175867|0 |1 is obsolete| | --- Comment #80 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176007&action=edit Bug 37334: Add filter_by_checked_out tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175868|0 |1 is obsolete| | --- Comment #81 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176008&action=edit Bug 37334: Add POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175869|0 |1 is obsolete| | --- Comment #82 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176009&action=edit Bug 37334: Add filter_by_in_transit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175870|0 |1 is obsolete| | --- Comment #83 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176010&action=edit Bug 37334: Add filter_by_has_holds tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175871|0 |1 is obsolete| | --- Comment #84 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176011&action=edit Bug 37334: Fix filter_by_has_recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175999|0 |1 is obsolete| | --- Comment #85 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 176023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176023&action=edit Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176000|0 |1 is obsolete| | --- Comment #86 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 176024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176024&action=edit Bug 37334: Allow a column filter to be shown even searchable is off We do not want to use the usual filtering method here, we are building the query from "additional filters" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176001|0 |1 is obsolete| | --- Comment #87 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 176025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176025&action=edit Bug 37334: Restore filtering holdings per status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176002|0 |1 is obsolete| | --- Comment #88 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 176026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176026&action=edit Bug 37334: Fix logic for not available Several major changes here: * the push @not_availab_itemnumbers for lost, damaged, etc. was totally wrong * not for loan is only for positive values * restricted can be NULL Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176003|0 |1 is obsolete| | --- Comment #89 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 176027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176027&action=edit Bug 37334: Fix restricted and notforloan filter logic Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176004|0 |1 is obsolete| | --- Comment #90 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 176028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176028&action=edit Bug 37334: Return all non zero notforloan statuses Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176005|0 |1 is obsolete| | --- Comment #91 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 176029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176029&action=edit Bug 37334: filter_by_available should not return notforloan statues other than 0 Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176006|0 |1 is obsolete| | --- Comment #92 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 176030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176030&action=edit Bug 37334: Add _status tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176007|0 |1 is obsolete| | --- Comment #93 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 176031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176031&action=edit Bug 37334: Add filter_by_checked_out tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176008|0 |1 is obsolete| | --- Comment #94 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 176032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176032&action=edit Bug 37334: Add POD Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #95 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 176033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176033&action=edit Bug 37334: Add filter_by_in_transit tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176009|0 |1 is obsolete| | Attachment #176010|0 |1 is obsolete| | --- Comment #96 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 176034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176034&action=edit Bug 37334: Add filter_by_has_holds tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176011|0 |1 is obsolete| | --- Comment #97 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 176035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176035&action=edit Bug 37334: Fix filter_by_has_recalls Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #98 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Tested and now filtering with status works as intended. Also tests pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #99 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 176023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176023 Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items Review of attachment 176023: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37334&attachment=176023) ----------------------------------------------------------------- ::: Koha/Item.pm @@ +1469,5 @@
+ if ( $self->damaged ) { + push @statuses, 'damaged'; + } + if ( $self->notforloan || $self->item_type->notforloan ) { + # TODO on a big Koha::Items loop we are going to join with item_type too often, use a cache
Is the concern big enough to at least have a ticket opened to measure this? And eventually implement a cache. @@ +1487,5 @@
+ if ( $self->restricted ) { + push @statuses, 'restricted'; + } + + # TODO in_bundle?
Was that meant to be temporary or does it have a long term use? Does it warrant at least opening a follow-up ticket or it's too minor? Does it warrant some manual testing related to bundles? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #100 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #99)
Comment on attachment 176023 [details] [review] Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items
Review of attachment 176023 [details] [review]: -----------------------------------------------------------------
::: Koha/Item.pm @@ +1469,5 @@
+ if ( $self->damaged ) { + push @statuses, 'damaged'; + } + if ( $self->notforloan || $self->item_type->notforloan ) { + # TODO on a big Koha::Items loop we are going to join with item_type too often, use a cache
Is the concern big enough to at least have a ticket opened to measure this? And eventually implement a cache.
Yes, we should open a new bug report for this.
@@ +1487,5 @@
+ if ( $self->restricted ) { + push @statuses, 'restricted'; + } + + # TODO in_bundle?
Was that meant to be temporary or does it have a long term use? Does it warrant at least opening a follow-up ticket or it's too minor? Does it warrant some manual testing related to bundles?
in_bundle is a status, so that needs to be included in this bug, I think. I will add ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Failed QA --- Comment #101 from Victor Grousset/tuxayo <victor@tuxayo.net> --- To pass the tests, only these two commits are needed: Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items Bug 37334: Restore filtering holdings per status Looking the diffs of the other commits, there are substantial changes that would have been expected to be necessary for tests to pass. After that smoke test, let's look at proper coverage: https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL17:_Unit_tests_ar... These are not covered by tests: sub filter_by_has_recalls sub filter_by_available search() have very little coverage. At least having the most complex case (not_for_loan) covered would be safer. The "recalled" and "available" cases would also cover the above paragraph. Or maybe they should be tested directly and not via search(). No opinion on this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |TODO, when this is merged release notes| |if the situation hasn't | |changed, a ticket about | |measuring a performance (to | |maybe add cache) is need. | |See comment 99 and comment | |100. --- Comment #102 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Yes, we should open a new bug report for this.
ok, I'm experimenting with hijacking the release notes field to keep track of this. ------ Thanks for the existing tests. coverage of _status is perfect and so is all the other filter_by_* subs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #103 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176475&action=edit Bug 37334: Add ability to filter by in_bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #104 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176477&action=edit Bug 37334: filter_by_in_bundle tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #105 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176480&action=edit Bug 37334: Add filter_by_recall test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #106 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176481&action=edit Bug 37334: Add filter_by_available tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #107 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I have added the ability to filter by bundles w/ tests. I have also included tests for filter_by_has_recalls and filter_by_available Resetting to 'Signed off' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #108 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 38686 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #109 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Victor Grousset/tuxayo from comment #101)
These are not covered by tests: sub filter_by_has_recalls sub filter_by_available
All good, thanks :)
search() have very little coverage. At least having the most complex case (not_for_loan) covered would be safer. The "recalled" and "available" cases would also cover the above paragraph. Or maybe they should be tested directly and not via search(). No opinion on this.
Still the same issue with search() unfortunately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #110 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177321&action=edit Bug 37334: Add search tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #111 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- There aren't any test plans that I can see on here... I tried applying the patches and using the search box at the top of the holdings table to search for statuses and it doesn't find anything. Is that what this is trying to solve? To recreate: 1. Go to a record details page (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 2. Add a couple of items with different statuses (or change the status of a couple of items) 2.1. Click New > New item 2.2. Change the Not for loan status to Staff collection (or another not for loan status) 2.3. Click Add item 2.4. Repeat 2.2 and 2.3 for various not for loan statuses 2.5. Click Normal to go back to the record details page 3. Try to search for the status in the holdings 3.1. Using the small search box right above the holdings table, search for one of the statuses (e.g. "Staff") --> No results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176023|0 |1 is obsolete| | --- Comment #112 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177415&action=edit Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items To test; 0. APPLY PATCH, restart_all 1. Go to a record details page (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 2. Click the 'Show filters' button above the table 3. Now, at the top of the Status column you should see a dropdown to filter by status 4. You'll have to create several item status to test everything. 5. Add some new items/or change some item status to: DAMAGED, WITHDRAWN, NOTFORLOAN, RESTRICTED, and LOST 6. Test the status filter for each of these statuses, ensuring the work correctly. 7. Create more new items and have some that are checked out, ensure that filter works 8. Put some items into transit and make sure the 'In transit' filter works 9. Put some items on hold, both item and bib level. Make sure the 'On hold' filter works. 10. Turn on the USERecalls system preference and make some recalls, both item and bib level. Make sure the 'Recalled' filter works 11. Create some bundles, make sure the 'In bundle' status works. 12. Also make sure that the available filter is working. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176024|0 |1 is obsolete| | --- Comment #113 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177416&action=edit Bug 37334: Allow a column filter to be shown even searchable is off We do not want to use the usual filtering method here, we are building the query from "additional filters" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176025|0 |1 is obsolete| | --- Comment #114 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177417&action=edit Bug 37334: Restore filtering holdings per status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176026|0 |1 is obsolete| | --- Comment #115 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177418&action=edit Bug 37334: Fix logic for not available Several major changes here: * the push @not_availab_itemnumbers for lost, damaged, etc. was totally wrong * not for loan is only for positive values * restricted can be NULL Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176027|0 |1 is obsolete| | --- Comment #116 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177419&action=edit Bug 37334: Fix restricted and notforloan filter logic Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176028|0 |1 is obsolete| | --- Comment #117 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177420&action=edit Bug 37334: Return all non zero notforloan statuses Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176029|0 |1 is obsolete| | --- Comment #118 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177421&action=edit Bug 37334: filter_by_available should not return notforloan statues other than 0 Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176030|0 |1 is obsolete| | --- Comment #119 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177422&action=edit Bug 37334: Add _status tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176031|0 |1 is obsolete| | --- Comment #120 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177423&action=edit Bug 37334: Add filter_by_checked_out tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176032|0 |1 is obsolete| | --- Comment #121 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177424&action=edit Bug 37334: Add POD Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176033|0 |1 is obsolete| | --- Comment #122 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177425&action=edit Bug 37334: Add filter_by_in_transit tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176034|0 |1 is obsolete| | --- Comment #123 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177426&action=edit Bug 37334: Add filter_by_has_holds tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176035|0 |1 is obsolete| | --- Comment #124 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177427&action=edit Bug 37334: Fix filter_by_has_recalls Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176475|0 |1 is obsolete| | --- Comment #125 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177428&action=edit Bug 37334: Add ability to filter by in_bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176477|0 |1 is obsolete| | --- Comment #126 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177429&action=edit Bug 37334: filter_by_in_bundle tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176480|0 |1 is obsolete| | --- Comment #127 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177430&action=edit Bug 37334: Add filter_by_recall test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176481|0 |1 is obsolete| | --- Comment #128 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177431&action=edit Bug 37334: Add filter_by_available tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177321|0 |1 is obsolete| | --- Comment #129 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177432&action=edit Bug 37334: Add search tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #130 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #111)
There aren't any test plans that I can see on here... I tried applying the patches and using the search box at the top of the holdings table to search for statuses and it doesn't find anything. Is that what this is trying to solve?
I attached a test plan to the first commit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #131 from Victor Grousset/tuxayo <victor@tuxayo.net> --- For testing, one needs to run `yarn api:bundle` after applying the patch and before restarting the services. Otherwise there is an error 400 when loading the record page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #132 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Tested again with all statuses mentioned in test plan. Following statuses were filtered ok: - DAMAGED - WITHDRAWN - NOTFORLOAN - RESTRICTED - LOST - CHECKEDOUT ok - ON-SITE CHECKOUT - ON HOLD (tested when item is just in hold and when it's waiting) - IN BUNDLE These statuses still have problems: - AVAILABLE (returns nothing) - IN TRANSIT (returns available, notforloan, checkedout statuses) - RECALLED (returns all items) However tests in t/db_dependent/Koha/Items.t all pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #133 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- There's most likely something wrong with filter_by_in_transit and filter_by_has_recalls. Commenting them from filter_by_available fixes filtering for available status. In filter_by_has_recalls there is a wrong column name where itemnumbers are searched from. It should be item_id, not itemnumber: my $recalls = Koha::Recalls->search( { %$params, 'me.item_id' => [ $self->get_column('itemnumber') ], 'me.item_level' => 1, }, { columns => ['item_id'], distinct => 1 } )->_resultset->as_query; In filter_by_in_transit columns are ok, so I'm not sure what's wrong with it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #134 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- It seems that filter_by_in_transit returns every item that has row in branchtransfers table even if item is not currently in transit. E.g. it returned item from my database which was last time transferred 2021. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #135 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Emmi Takkinen from comment #132)
- AVAILABLE (returns nothing) - IN TRANSIT (returns available, notforloan, checkedout statuses)
I've only tried this: https://snipboard.io/oiQlTF.jpg https://snipboard.io/o9PfTv.jpg https://snipboard.io/tZgc0x.jpg Can you provide more detail please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #136 from Jonathan Druart <jonathan.druart@gmail.com> --- ok, forget my comment. Your previous comment answered it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #137 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177466&action=edit Bug 37334: Filter in_transit by current -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #138 from Victor Grousset/tuxayo <victor@tuxayo.net> --- When having a restricted item ($5), the item table loads indefinitely. And console says: TypeError: row.bundle_host is null Line is: if ( status == 'restricted') { nodes += '<span class="bundled">%s</span>'.format(_("In bundle: %s").format($biblio_to_html(row.bundle_host.biblio, { link: true }))); } Going back to main + yarn api:bundle ; restart_all + force refresh makes the table work. And with the patches the error happens again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #139 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #138)
When having a restricted item ($5), the item table loads indefinitely. And console says: TypeError: row.bundle_host is null
Line is: if ( status == 'restricted') { nodes += '<span class="bundled">%s</span>'.format(_("In bundle: %s").format($biblio_to_html(row.bundle_host.biblio, { link: true }))); }
Going back to main + yarn api:bundle ; restart_all + force refresh makes the table work. And with the patches the error happens again.
That looks like a bad copy/paste. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #140 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177516&action=edit Bug 37334: Fix restricted and in_bundle JS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177427|0 |1 is obsolete| | --- Comment #141 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177520&action=edit Bug 37334: Fix filter_by_has_recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177428|0 |1 is obsolete| | --- Comment #142 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 177524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177524&action=edit Bug 37334: Add ability to filter by in_bundle Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177429|0 |1 is obsolete| | --- Comment #143 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 177525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177525&action=edit Bug 37334: filter_by_in_bundle tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177430|0 |1 is obsolete| | --- Comment #144 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 177526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177526&action=edit Bug 37334: Add filter_by_recall test Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177431|0 |1 is obsolete| | --- Comment #145 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 177527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177527&action=edit Bug 37334: Add filter_by_available tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177432|0 |1 is obsolete| | --- Comment #146 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 177528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177528&action=edit Bug 37334: Add search tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177466|0 |1 is obsolete| | --- Comment #147 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 177529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177529&action=edit Bug 37334: Filter in_transit by current Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177516|0 |1 is obsolete| | --- Comment #148 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 177530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177530&action=edit Bug 37334: Fix restricted and in_bundle JS Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177520|0 |1 is obsolete| | --- Comment #149 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 177531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177531&action=edit Bug 37334: Fix filter_by_has_recalls Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #150 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Tested again and all seems to be working as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #151 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Emmi Takkinen from comment #150)
Tested again and all seems to be working as expected.
Thank you, Emmi! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177415|0 |1 is obsolete| | --- Comment #152 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177764&action=edit Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items To test; 0. APPLY PATCH, restart_all 1. Go to a record details page (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 2. Click the 'Show filters' button above the table 3. Now, at the top of the Status column you should see a dropdown to filter by status 4. You'll have to create several item status to test everything. 5. Add some new items/or change some item status to: DAMAGED, WITHDRAWN, NOTFORLOAN, RESTRICTED, and LOST 6. Test the status filter for each of these statuses, ensuring the work correctly. 7. Create more new items and have some that are checked out, ensure that filter works 8. Put some items into transit and make sure the 'In transit' filter works 9. Put some items on hold, both item and bib level. Make sure the 'On hold' filter works. 10. Turn on the USERecalls system preference and make some recalls, both item and bib level. Make sure the 'Recalled' filter works 11. Create some bundles, make sure the 'In bundle' status works. 12. Also make sure that the available filter is working. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177416|0 |1 is obsolete| | --- Comment #153 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177765&action=edit Bug 37334: Allow a column filter to be shown even searchable is off We do not want to use the usual filtering method here, we are building the query from "additional filters" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177417|0 |1 is obsolete| | --- Comment #154 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177766&action=edit Bug 37334: Restore filtering holdings per status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177418|0 |1 is obsolete| | --- Comment #155 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177767&action=edit Bug 37334: Fix logic for not available Several major changes here: * the push @not_availab_itemnumbers for lost, damaged, etc. was totally wrong * not for loan is only for positive values * restricted can be NULL Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177419|0 |1 is obsolete| | --- Comment #156 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177768&action=edit Bug 37334: Fix restricted and notforloan filter logic Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177420|0 |1 is obsolete| | --- Comment #157 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177769&action=edit Bug 37334: Return all non zero notforloan statuses Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177421|0 |1 is obsolete| | --- Comment #158 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177770&action=edit Bug 37334: filter_by_available should not return notforloan statues other than 0 Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177422|0 |1 is obsolete| | --- Comment #159 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177771&action=edit Bug 37334: Add _status tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177423|0 |1 is obsolete| | --- Comment #160 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177772&action=edit Bug 37334: Add filter_by_checked_out tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177424|0 |1 is obsolete| | --- Comment #161 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177773&action=edit Bug 37334: Add POD Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177425|0 |1 is obsolete| | --- Comment #162 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177774&action=edit Bug 37334: Add filter_by_in_transit tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177426|0 |1 is obsolete| | --- Comment #163 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177775&action=edit Bug 37334: Add filter_by_has_holds tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177524|0 |1 is obsolete| | --- Comment #164 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177776&action=edit Bug 37334: Add ability to filter by in_bundle Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177525|0 |1 is obsolete| | --- Comment #165 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177777&action=edit Bug 37334: filter_by_in_bundle tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177526|0 |1 is obsolete| | --- Comment #166 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177778&action=edit Bug 37334: Add filter_by_recall test Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177527|0 |1 is obsolete| | --- Comment #167 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177779&action=edit Bug 37334: Add filter_by_available tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177528|0 |1 is obsolete| | --- Comment #168 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177780&action=edit Bug 37334: Add search tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177529|0 |1 is obsolete| | --- Comment #169 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177781&action=edit Bug 37334: Filter in_transit by current Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177530|0 |1 is obsolete| | --- Comment #170 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177782&action=edit Bug 37334: Fix restricted and in_bundle JS Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177531|0 |1 is obsolete| | --- Comment #171 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177783&action=edit Bug 37334: Fix filter_by_has_recalls Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177415|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177416|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177417|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177418|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177419|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177420|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177421|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177422|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177423|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177424|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177425|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177426|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177427|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177428|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177429|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177430|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177431|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177432|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177765|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177766|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177767|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177768|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177770|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177771|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177772|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177773|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177774|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177776|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177777|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177780|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177781|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177782|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177783|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177415|0 |1 is obsolete| | --- Comment #172 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178620&action=edit Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items To test; 0. APPLY PATCH, restart_all 1. Go to a record details page (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 2. Click the 'Show filters' button above the table 3. Now, at the top of the Status column you should see a dropdown to filter by status 4. You'll have to create several item status to test everything. 5. Add some new items/or change some item status to: DAMAGED, WITHDRAWN, NOTFORLOAN, RESTRICTED, and LOST 6. Test the status filter for each of these statuses, ensuring the work correctly. 7. Create more new items and have some that are checked out, ensure that filter works 8. Put some items into transit and make sure the 'In transit' filter works 9. Put some items on hold, both item and bib level. Make sure the 'On hold' filter works. 10. Turn on the USERecalls system preference and make some recalls, both item and bib level. Make sure the 'Recalled' filter works 11. Create some bundles, make sure the 'In bundle' status works. 12. Also make sure that the available filter is working. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177416|0 |1 is obsolete| | --- Comment #173 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178621&action=edit Bug 37334: Allow a column filter to be shown even searchable is off We do not want to use the usual filtering method here, we are building the query from "additional filters" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177417|0 |1 is obsolete| | --- Comment #174 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178622&action=edit Bug 37334: Restore filtering holdings per status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177418|0 |1 is obsolete| | --- Comment #175 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178623&action=edit Bug 37334: Fix logic for not available Several major changes here: * the push @not_availab_itemnumbers for lost, damaged, etc. was totally wrong * not for loan is only for positive values * restricted can be NULL Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177419|0 |1 is obsolete| | --- Comment #176 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178624&action=edit Bug 37334: Fix restricted and notforloan filter logic Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177420|0 |1 is obsolete| | --- Comment #177 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178625&action=edit Bug 37334: Return all non zero notforloan statuses Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177421|0 |1 is obsolete| | --- Comment #178 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178626&action=edit Bug 37334: filter_by_available should not return notforloan statues other than 0 Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177422|0 |1 is obsolete| | --- Comment #179 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178627&action=edit Bug 37334: Add _status tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177423|0 |1 is obsolete| | --- Comment #180 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178628&action=edit Bug 37334: Add filter_by_checked_out tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177424|0 |1 is obsolete| | --- Comment #181 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178629&action=edit Bug 37334: Add POD Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177425|0 |1 is obsolete| | --- Comment #182 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178630&action=edit Bug 37334: Add filter_by_in_transit tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177426|0 |1 is obsolete| | --- Comment #183 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178631&action=edit Bug 37334: Add filter_by_has_holds tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177427|0 |1 is obsolete| | --- Comment #184 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178632&action=edit Bug 37334: Fix filter_by_has_recalls Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177428|0 |1 is obsolete| | --- Comment #185 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178633&action=edit Bug 37334: Add ability to filter by in_bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177429|0 |1 is obsolete| | --- Comment #186 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178634&action=edit Bug 37334: filter_by_in_bundle tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177430|0 |1 is obsolete| | --- Comment #187 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178635&action=edit Bug 37334: Add filter_by_recall test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177431|0 |1 is obsolete| | --- Comment #188 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178636&action=edit Bug 37334: Add filter_by_available tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177432|0 |1 is obsolete| | --- Comment #189 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178637&action=edit Bug 37334: Add search tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #190 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Rebased for current main again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38108 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 [Bug 38108] Staff interface holdings table - table navigation only shows when "Show filters" is selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38108 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 [Bug 38108] Staff interface holdings table - table navigation only shows when "Show filters" is selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia@bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #191 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180064&action=edit Bug 37334: Adjust number of tests in Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178620|0 |1 is obsolete| | --- Comment #192 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180157&action=edit Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items To test; 0. APPLY PATCH, restart_all 1. Go to a record details page (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 2. Click the 'Show filters' button above the table 3. Now, at the top of the Status column you should see a dropdown to filter by status 4. You'll have to create several item status to test everything. 5. Add some new items/or change some item status to: DAMAGED, WITHDRAWN, NOTFORLOAN, RESTRICTED, and LOST 6. Test the status filter for each of these statuses, ensuring the work correctly. 7. Create more new items and have some that are checked out, ensure that filter works 8. Put some items into transit and make sure the 'In transit' filter works 9. Put some items on hold, both item and bib level. Make sure the 'On hold' filter works. 10. Turn on the USERecalls system preference and make some recalls, both item and bib level. Make sure the 'Recalled' filter works 11. Create some bundles, make sure the 'In bundle' status works. 12. Also make sure that the available filter is working. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178621|0 |1 is obsolete| | --- Comment #193 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180158&action=edit Bug 37334: Allow a column filter to be shown even searchable is off We do not want to use the usual filtering method here, we are building the query from "additional filters" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178622|0 |1 is obsolete| | --- Comment #194 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180159&action=edit Bug 37334: Restore filtering holdings per status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178623|0 |1 is obsolete| | --- Comment #195 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180160&action=edit Bug 37334: Fix logic for not available Several major changes here: * the push @not_availab_itemnumbers for lost, damaged, etc. was totally wrong * not for loan is only for positive values * restricted can be NULL Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178624|0 |1 is obsolete| | --- Comment #196 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180161&action=edit Bug 37334: Fix restricted and notforloan filter logic Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178625|0 |1 is obsolete| | --- Comment #197 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180162&action=edit Bug 37334: Return all non zero notforloan statuses Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178626|0 |1 is obsolete| | --- Comment #198 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180163&action=edit Bug 37334: filter_by_available should not return notforloan statues other than 0 Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178627|0 |1 is obsolete| | --- Comment #199 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180164&action=edit Bug 37334: Add _status tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178628|0 |1 is obsolete| | --- Comment #200 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180165&action=edit Bug 37334: Add filter_by_checked_out tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178629|0 |1 is obsolete| | --- Comment #201 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180166&action=edit Bug 37334: Add POD Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178630|0 |1 is obsolete| | --- Comment #202 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180167&action=edit Bug 37334: Add filter_by_in_transit tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178631|0 |1 is obsolete| | --- Comment #203 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180168&action=edit Bug 37334: Add filter_by_has_holds tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178632|0 |1 is obsolete| | --- Comment #204 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180169&action=edit Bug 37334: Fix filter_by_has_recalls Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178633|0 |1 is obsolete| | --- Comment #205 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180170&action=edit Bug 37334: Add ability to filter by in_bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178634|0 |1 is obsolete| | --- Comment #206 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180171&action=edit Bug 37334: filter_by_in_bundle tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178635|0 |1 is obsolete| | --- Comment #207 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180172&action=edit Bug 37334: Add filter_by_recall test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178636|0 |1 is obsolete| | --- Comment #208 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180173&action=edit Bug 37334: Add filter_by_available tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178637|0 |1 is obsolete| | --- Comment #209 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180174&action=edit Bug 37334: Add search tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180064|0 |1 is obsolete| | --- Comment #210 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180175&action=edit Bug 37334: Adjust number of tests in Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #211 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180196&action=edit Bug 37334: Fix column offset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180157|0 |1 is obsolete| | --- Comment #212 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181161&action=edit Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items To test; 0. APPLY PATCH, restart_all 1. Go to a record details page (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 2. Click the 'Show filters' button above the table 3. Now, at the top of the Status column you should see a dropdown to filter by status 4. You'll have to create several item status to test everything. 5. Add some new items/or change some item status to: DAMAGED, WITHDRAWN, NOTFORLOAN, RESTRICTED, and LOST 6. Test the status filter for each of these statuses, ensuring the work correctly. 7. Create more new items and have some that are checked out, ensure that filter works 8. Put some items into transit and make sure the 'In transit' filter works 9. Put some items on hold, both item and bib level. Make sure the 'On hold' filter works. 10. Turn on the USERecalls system preference and make some recalls, both item and bib level. Make sure the 'Recalled' filter works 11. Create some bundles, make sure the 'In bundle' status works. 12. Also make sure that the available filter is working. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180158|0 |1 is obsolete| | --- Comment #213 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181162&action=edit Bug 37334: Allow a column filter to be shown even searchable is off We do not want to use the usual filtering method here, we are building the query from "additional filters" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180159|0 |1 is obsolete| | --- Comment #214 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181163&action=edit Bug 37334: Restore filtering holdings per status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180160|0 |1 is obsolete| | --- Comment #215 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181164&action=edit Bug 37334: Fix logic for not available Several major changes here: * the push @not_availab_itemnumbers for lost, damaged, etc. was totally wrong * not for loan is only for positive values * restricted can be NULL Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180161|0 |1 is obsolete| | --- Comment #216 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181165&action=edit Bug 37334: Fix restricted and notforloan filter logic Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180162|0 |1 is obsolete| | --- Comment #217 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181166&action=edit Bug 37334: Return all non zero notforloan statuses Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180163|0 |1 is obsolete| | --- Comment #218 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181167&action=edit Bug 37334: filter_by_available should not return notforloan statues other than 0 Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180164|0 |1 is obsolete| | --- Comment #219 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181169&action=edit Bug 37334: Add _status tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180165|0 |1 is obsolete| | --- Comment #220 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181170&action=edit Bug 37334: Add filter_by_checked_out tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180166|0 |1 is obsolete| | --- Comment #221 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181171&action=edit Bug 37334: Add POD Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180167|0 |1 is obsolete| | --- Comment #222 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181172&action=edit Bug 37334: Add filter_by_in_transit tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180168|0 |1 is obsolete| | --- Comment #223 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181173&action=edit Bug 37334: Add filter_by_has_holds tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180169|0 |1 is obsolete| | --- Comment #224 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181174&action=edit Bug 37334: Fix filter_by_has_recalls Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180170|0 |1 is obsolete| | --- Comment #225 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181175&action=edit Bug 37334: Add ability to filter by in_bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180171|0 |1 is obsolete| | --- Comment #226 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181176&action=edit Bug 37334: filter_by_in_bundle tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180172|0 |1 is obsolete| | --- Comment #227 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181177&action=edit Bug 37334: Add filter_by_recall test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180173|0 |1 is obsolete| | --- Comment #228 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181178&action=edit Bug 37334: Add filter_by_available tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180174|0 |1 is obsolete| | --- Comment #229 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181179&action=edit Bug 37334: Add search tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180175|0 |1 is obsolete| | --- Comment #230 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181180&action=edit Bug 37334: Adjust number of tests in Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180196|0 |1 is obsolete| | --- Comment #231 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181181&action=edit Bug 37334: Fix column offset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #232 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Rebased again for current main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39011 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28762 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29095 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #233 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi Lucas! I was testing this and ran into a problem when I added an item with a Restricted access status. 1. WITHOUT applying the patch, go to a record (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 2. Click New > New item 3. Under 5 - Use restrictions, choose Restricted Access 4. Click Add item 5. Click Normal --> Record and items appear OK 6. Apply patch 7. In ktd --shell, do yarn api:bundle 8. Then reset_all 9. Redo steps 1-5 --> Record appears, but items are "processing" forever -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #234 from Jonathan Druart <jonathan.druart@gmail.com> --- Confirmed. Nice one, Caroline. There is a JS error in the console: Uncaught TypeError: row.bundle_host is null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #235 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181632&action=edit Bug 37334: Correct logic for filtering by in_bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #236 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #233)
Hi Lucas! I was testing this and ran into a problem when I added an item with a Restricted access status.
1. WITHOUT applying the patch, go to a record (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 2. Click New > New item 3. Under 5 - Use restrictions, choose Restricted Access 4. Click Add item 5. Click Normal --> Record and items appear OK
6. Apply patch 7. In ktd --shell, do yarn api:bundle 8. Then reset_all 9. Redo steps 1-5 --> Record appears, but items are "processing" forever
Thanks Caroline! That should be fixed now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181161|0 |1 is obsolete| | Attachment #181162|0 |1 is obsolete| | Attachment #181163|0 |1 is obsolete| | Attachment #181164|0 |1 is obsolete| | Attachment #181165|0 |1 is obsolete| | Attachment #181166|0 |1 is obsolete| | Attachment #181167|0 |1 is obsolete| | Attachment #181169|0 |1 is obsolete| | Attachment #181170|0 |1 is obsolete| | Attachment #181171|0 |1 is obsolete| | Attachment #181172|0 |1 is obsolete| | Attachment #181173|0 |1 is obsolete| | Attachment #181174|0 |1 is obsolete| | Attachment #181175|0 |1 is obsolete| | Attachment #181176|0 |1 is obsolete| | Attachment #181177|0 |1 is obsolete| | Attachment #181178|0 |1 is obsolete| | Attachment #181179|0 |1 is obsolete| | Attachment #181180|0 |1 is obsolete| | Attachment #181181|0 |1 is obsolete| | Attachment #181632|0 |1 is obsolete| | --- Comment #237 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182359&action=edit Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items To test; 0. APPLY PATCH, restart_all 1. Go to a record details page (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 2. Click the 'Show filters' button above the table 3. Now, at the top of the Status column you should see a dropdown to filter by status 4. You'll have to create several item status to test everything. 5. Add some new items/or change some item status to: DAMAGED, WITHDRAWN, NOTFORLOAN, RESTRICTED, and LOST 6. Test the status filter for each of these statuses, ensuring the work correctly. 7. Create more new items and have some that are checked out, ensure that filter works 8. Put some items into transit and make sure the 'In transit' filter works 9. Put some items on hold, both item and bib level. Make sure the 'On hold' filter works. 10. Turn on the USERecalls system preference and make some recalls, both item and bib level. Make sure the 'Recalled' filter works 11. Create some bundles, make sure the 'In bundle' status works. 12. Also make sure that the available filter is working. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Bug 37334: Correct logic for filtering by in_bundle Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #238 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182360&action=edit Bug 37334: Allow a column filter to be shown even searchable is off We do not want to use the usual filtering method here, we are building the query from "additional filters" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #239 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182361&action=edit Bug 37334: Restore filtering holdings per status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Bug 37334: Fix column offset Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #240 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182362&action=edit Bug 37334: Fix logic for not available Several major changes here: * the push @not_availab_itemnumbers for lost, damaged, etc. was totally wrong * not for loan is only for positive values * restricted can be NULL Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #241 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182363&action=edit Bug 37334: Fix restricted and notforloan filter logic Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #242 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182364&action=edit Bug 37334: Return all non zero notforloan statuses Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #243 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182365&action=edit Bug 37334: filter_by_available should not return notforloan statues other than 0 Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #244 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182366&action=edit Bug 37334: Add _status tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #245 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182367&action=edit Bug 37334: Add filter_by_checked_out tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #246 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182368&action=edit Bug 37334: Add POD Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #247 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182369&action=edit Bug 37334: Add filter_by_in_transit tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #248 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182370&action=edit Bug 37334: Add filter_by_has_holds tests Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #249 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182371&action=edit Bug 37334: Fix filter_by_has_recalls Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #250 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182372&action=edit Bug 37334: Add ability to filter by in_bundle Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #251 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182373&action=edit Bug 37334: filter_by_in_bundle tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #252 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182374&action=edit Bug 37334: Add filter_by_recall test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #253 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182375&action=edit Bug 37334: Add filter_by_available tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #254 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182376&action=edit Bug 37334: Add search tests Bug 37334: Adjust number of tests in Items.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #255 from Jonathan Druart <jonathan.druart@gmail.com> --- I've merged the last 3 patches into the other patches, where they belong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@openfifth.c |jonathan.druart@gmail.com |o.uk | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|TODO, when this is merged |This patchset restores the release notes|if the situation hasn't |ability to filter the |changed, a ticket about |holdings table by status |measuring a performance (to |which has lost when the |maybe add cache) is need. |holdings table was upgraded |See comment 99 and comment |to use the REST API via Bug |100. |33568. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patchset restores the |This restores the ability release notes|ability to filter the |to filter the holdings |holdings table by status |table by status. This was |which has lost when the |lost when the holdings |holdings table was upgraded |table was upgraded to use |to use the REST API via Bug |the REST API (added to Koha |33568. |24.05 by bug 33568). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7012 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012 [Bug 7012] Limit to available does not exclude in-transit items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #256 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #257 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but this needs some more work for the tests to pass (see dashboard main/D12) AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Status' within the element: <th#holdings_actions.no-sort.no-export.actions.dt-orderable-none> but never did. at Context.eval (webpack://koha/./t/cypress/integration/KohaTable/Holdings_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #258 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #257)
I am sorry, but this needs some more work for the tests to pass (see dashboard main/D12)
AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Status' within the element: <th#holdings_actions.no-sort.no-export.actions.dt-orderable-none> but never did. at Context.eval (webpack://koha/./t/cypress/integration/KohaTable/Holdings_spec.ts
I am working on these tests and have asked Tomas for some help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #259 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182552&action=edit Bug 37334: Update Holdings_spec.ts test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #260 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Follow-up pushed to main, for 25.05. Thanks Lucas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 [Bug 39932] Koha::Item->_status should return an array -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #261 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I don't manage to make this work. Whenever I use the filter, I see it reaches `Koha::Items->search` with this form: `^lost$` so the `eq` never matches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #262 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #261)
I don't manage to make this work.
Whenever I use the filter, I see it reaches `Koha::Items->search` with this form: `^lost$` so the `eq` never matches.
Sorry, maybe it is because I'm on top of bug 39932. But I think it needs to be fixed on top of it for the release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #263 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #262)
(In reply to Tomás Cohen Arazi (tcohen) from comment #261)
I don't manage to make this work.
Whenever I use the filter, I see it reaches `Koha::Items->search` with this form: `^lost$` so the `eq` never matches.
I think it's because of bug 39473. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #264 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182665&action=edit Bug 37334: Fix conflict with bug 39473 Bug 39473 added ^ and $ to options of the dropdown lists from the column filters. They are removed and replaced with "exact" later in the code (using build_query). But in the case of "_status", we do no get this code as it's not a regular column (it does not have "data" attribute), but an additional filters. I don't think this fix is ideal, but we are too close to the release to rework datatables.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #265 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can someone take a look at the failing tests please? I need fixes urgently as we are so close to release now: Show filters.catalogue/detail/holdings_table Show filters Correctly init the table.catalogue/detail/holdings_table Correctly init the table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #266 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #265)
Can someone take a look at the failing tests please? I need fixes urgently as we are so close to release now:
Show filters.catalogue/detail/holdings_table Show filters Correctly init the table.catalogue/detail/holdings_table Correctly init the table
18:40:04 koha_1 | > row._status.forEach is not a function This is because of bug 39932 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #267 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 182733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182733&action=edit Bug 37334: Adjust mocked _status data (bug 39932 follow-up) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #268 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #267)
Created attachment 182733 [details] [review] Bug 37334: Adjust mocked _status data (bug 39932 follow-up)
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #269 from Andrii Nugged <nugged@gmail.com> --- In: koha-tmpl/intranet-tmpl/prog/js/datatables.js now we have this: } else if (v) { additional_filters[k] = v .replace(/^\^/, "") .replace(/\$$/, ""); } But when we search by a single letter, in v we have object: {like: 'A%'}, that's not a string and doesn't have .replace, so the browser crashes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #270 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Andrii Nugged from comment #269)
In: koha-tmpl/intranet-tmpl/prog/js/datatables.js now we have this: } else if (v) { additional_filters[k] = v .replace(/^\^/, "") .replace(/\$$/, ""); }
But when we search by a single letter, in v we have object: {like: 'A%'}, that's not a string and doesn't have .replace, so the browser crashes.
This is causing problems also with modify holds tool which I'm working on (bug 36135). When I try to search holds with it, following error is displayed in browsers console:
Uncaught TypeError: v.replace is not a function
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #271 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Emmi Takkinen from comment #270)
(In reply to Andrii Nugged from comment #269)
In: koha-tmpl/intranet-tmpl/prog/js/datatables.js now we have this: } else if (v) { additional_filters[k] = v .replace(/^\^/, "") .replace(/\$$/, ""); }
But when we search by a single letter, in v we have object: {like: 'A%'}, that's not a string and doesn't have .replace, so the browser crashes.
This is causing problems also with modify holds tool which I'm working on (bug 36135). When I try to search holds with it, following error is displayed in browsers console:
Uncaught TypeError: v.replace is not a function
Patron search and records holding table are broken due this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40002 [Bug 40002] Cannot filter patrons by "Browse by last name" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #272 from Jonathan Druart <jonathan.druart@gmail.com> --- Andrii, Emmi: I've opened bug 37334, I am on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #273 from Kristi <kkrueger@cuyahogalibrary.org> --- Is there still work needed on this patch, or has it been included in 25.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #274 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Kristi from comment #273)
Is there still work needed on this patch, or has it been included in 25.05?
Hi Kristi, this patchset has been included in 25.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #275 from Kristi <kkrueger@cuyahogalibrary.org> --- Thanks for the update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39921 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |Holds function| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38122 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 [Bug 38122] Cannot sort holdings table by status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Bug 37334 depends on bug 33568, which changed state. Bug 33568 Summary: Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #276 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 184925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184925&action=edit Bug 37334: [24.11] Allow filter holdings table by status (squashed) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #277 from Fridolin Somers <fridolin.somers@biblibre.com> --- This feature is really necessary for librarians. They use it to find available items when there are a lot of items. Also status in API may be very useful for portals. I'm working on backport to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184925|0 |1 is obsolete| | --- Comment #278 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 184974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184974&action=edit Bug 37334: [24.11] Allow filter holdings table by status (squashed) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #279 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #280 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- *** Bug 37915 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #281 from Mathieu Saby <mathsabypro@gmail.com> --- After 6 weeks of using Koha 24.11 in my library, I believe this filter should be improved. I opened https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41254 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #282 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- We noticed that filtering holdings table with status "In transit" shows every item that has been transferred even once. Meaning if there is even one row mentioning it's itemnumber in branchtransfers it is considered as "In transit". The transfers does not have to be currently active when it is considered "In transit". This also causes the "Available" status not to work properly because they are often considered as "In transit" (at least in our large consortium items transfer alot between branches and it is quite rare that item has never been transferred in it's lifetime) How to test: 1. Transfer item 1 from branch A to branch B 2. Receive/Fullfill the transfer in branch B 3. Go to items record and filter holdings table with status In transit 4. Notice that item 1 is shown even when it is actually "Available" 5. Filter holdings table with status "Available" and notice that item 1 is not shown. I have tested this in version 25.05.03 and in Open Fifth's sandbox and it happens in both of them. I will make a new bug about this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41298 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41298 [Bug 41298] Filtering holdings table with status In transit considers every item ever transferred to be "In transit" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41254 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41254 [Bug 41254] The filter for item status in item tables should be improved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41602 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41602 [Bug 41602] Cannot combine filters with holds status filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|41602 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41602 [Bug 41602] Cannot combine filters with holds status filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41602 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41602 [Bug 41602] Cannot combine filters with holds status filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 --- Comment #283 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I think this broke the change for translation that was made in catalogue_detail.inc by bug 38450. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41623 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 [Bug 41623] Missing translation string in catalogue_detail.inc (again) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #284 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #285 from David Nind <david@davidnind.com> --- Bug fix, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42349 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 [Bug 42349] Incorrect filter by recalls -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org