https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 [Bug 34709] Eliminate event handler attributes in the OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157137|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 157198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157198&action=edit Bug 34980: Remove the use of event attributes from title-actions-menu.inc in OPAC This patch updates the include file used to show actions with each search result, removing two instances of "onclick" in favor of an event handler class which was already in use elsewhere. To test, apply the patch and log in to the OPAC. - Perform a catalog search which will return results. - Test the "Save to lists" link under any search result. The "Save to lists" pop-up window should appear. - View the contents of a list which contains some titles. - Test the "Save to another list" control. The same pop-up window should be triggered. - Tag at least one title in the catalog and view the "Tag cloud" page. - Perform the same test with the "Save to lists" button in the table of our tags. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157198|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157214&action=edit Bug 34980: Remove the use of event attributes from title-actions-menu.inc in OPAC This patch updates the include file used to show actions with each search result, removing two instances of "onclick" in favor of an event handler class which was already in use elsewhere. To test, apply the patch and log in to the OPAC. - Perform a catalog search which will return results. - Test the "Save to lists" link under any search result. The "Save to lists" pop-up window should appear. - View the contents of a list which contains some titles. - Test the "Save to another list" control. The same pop-up window should be triggered. - Tag at least one title in the catalog and view the "Tag cloud" page. - Perform the same test with the "Save to lists" button in the table of our tags. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.