[Bug 10727] New: Replace carriage return with <br /> when writing hold notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Bug ID: 10727 Summary: Replace carriage return with <br /> when writing hold notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meynieux@biblibre.com QA Contact: testopia@bugs.koha-community.org This patch replaces carriage return with <br /> in the content of hold notices for printing. This is necessary to convert html file into well formatted pdf file. Test plan : - return an item reserved by a borrower that has not activated email notification - verify in message_queue table that you've got a new HOLD_PRINT notice with status 'pending' - run gather_print_notices.pl <directory> Without the patch, the script generates a html file without <br /> tags. If you run printoverdues.sh <directory>, the text in the resulting pdf file is all on one line With the patch, the script generates a html file with <br/> tags and pdf file created by printoverdues.sh is well formatted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 20330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20330&action=edit Bug 10727 : Replace carriage return with <br /> when printing hold notices This patch replaces carriage return with <br /> in the content of hold notices for printing. This is necessary to convert html file into well formatted pdf file. Test plan : - checkin an item reserved by a borrower that has not activated email notification - verify in message_queue table that you've got a new HOLD_PRINT notice with status 'pending' - run gather_print_notices.pl <directory> Without the patch, the script generates a html file without <br /> tags. If you run printoverdues.sh <directory>, the text in the resulting pdf file is all on one line With the patch, the script generates a html file with <br/> tags and pdf file created by printoverdues.sh is well formatted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |sophie.meynieux@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6030 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- In such cases, it is slightly better to say (within the loop): local $_ = $message->{'content'}; S/// ... That saves two var copies. I will make that change when signing off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20330|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 20755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20755&action=edit Bug 10727 : Replace carriage return with <br /> when printing hold notices This patch replaces carriage return with <br /> in the content of hold notices for printing. This is necessary to convert html file into well formatted pdf file. Test plan : - checkin an item reserved by a borrower that has not activated email notification - verify in message_queue table that you've got a new HOLD_PRINT notice with status 'pending' - run gather_print_notices.pl <directory> Without the patch, the script generates a html file without <br /> tags. If you run printoverdues.sh <directory>, the text in the resulting pdf file is all on one line With the patch, the script generates a html file with <br/> tags and pdf file created by printoverdues.sh is well formatted. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Please disregard my comment, wasn't too intelligent. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20755|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20830&action=edit Bug 10727 : Replace carriage return with <br /> when printing hold notices This patch replaces carriage return with <br /> in the content of hold notices for printing. This is necessary to convert html file into well formatted pdf file. Test plan : - checkin an item reserved by a borrower that has not activated email notification - verify in message_queue table that you've got a new HOLD_PRINT notice with status 'pending' - run gather_print_notices.pl <directory> Without the patch, the script generates a html file without <br /> tags. If you run printoverdues.sh <directory>, the text in the resulting pdf file is all on one line With the patch, the script generates a html file with <br/> tags and pdf file created by printoverdues.sh is well formatted. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Sophie! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Sophie! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.12 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12300 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20830|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 28502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28502&action=edit [SIGNED-OFF] Bug 12300 : Revert Bug 10727: Cancel replacing carriage return with <br /> when printing hold notices" Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors. Exact reversion of 10727. Just thinking, again you will get all text in one line [1] [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727#c0 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28502|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Comment on attachment 28502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28502 [SIGNED-OFF] Bug 12300 : Revert Bug 10727: Cancel replacing carriage return with <br /> when printing hold notices" Sorry, wrong bug -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org