[Bug 7114] New: Hiding filters on funds page messes with layout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7114 Bug #: 7114 Summary: Hiding filters on funds page messes with layout Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/admin/aqbudgets.pl?show=1&budget_period_ id=2&filter=Go# OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org Created attachment 6110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6110 screenshot When hiding the filters on the funds page using the link 'filters' navigation and main part of the page crash together. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7114 --- Comment #1 from Garry Collum <gcollum@gmail.com> 2012-01-20 16:32:45 UTC --- Created attachment 7260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7260 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7114 Garry Collum <gcollum@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |gcollum@gmail.com --- Comment #2 from Garry Collum <gcollum@gmail.com> 2012-02-09 22:26:34 UTC --- To test to to Budgets. Click on a budget to get to its funds. Click on the 'Filters' link above the Fund Filters input form. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7114 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7260|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-12 18:49:43 UTC --- Created attachment 7584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7584 [SIGNED-OFF] Bug 7114: Fixes the Funds' page display after the Filter link is clicked. On the funds page there is a Fund Filters form and a menu underneath this form. When the form is hidden the contents of the page shift to the left overlapping the menu. The menu underneath the fund filters form must have been a later edition. This patch removes the line of javascript that shifts the contents of the page after the form is hidden. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes the broken Layout when clicking on 'Filters'. I am a bit confused by the link. I think it should toggle between different descriptions and perhaps even hide all of the left navigation. This way the funds table would get more room for display. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7114 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7114 --- Comment #4 from Garry Collum <gcollum@gmail.com> 2012-02-12 20:44:42 UTC --- I think the menus under the Fund Filters box were a later addition. We could either hide the menu and make the display move all the way to the left, or we could leave the menus and just make the display scoot over to the menus. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7114 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-13 08:30:47 UTC --- Not sure how 'make the display scoot over to the menus' would look like. Do you mean diplaying the fund tabel below the text menu? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7114 --- Comment #6 from Garry Collum <gcollum@gmail.com> 2012-02-13 11:44:33 UTC --- I mean retaining the current menu of links, but moving the display as far to the left as possible without the menu overlapping the display when the form is hidden. After you explained the purpose of hiding the filters, I think my preference would be to not apply the current patch and send another patch that hides the form as well as the menu when the 'filters' link is clicked. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7114 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-13 11:48:55 UTC --- I only wondered becaue the function didn't make much sense to me as it is now. I think you are right - the navigation links were probably added later, which explains why the display problem was not spotted too. If you want to do another patch I will sign-off on it, but I think the patch as is is already an improvement. Perhaps you can toggle the link description too? (Hide/Show filters/navigation? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7114 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #8 from Ian Walls <koha.sekjal@gmail.com> 2012-02-16 16:22:43 UTC --- Correctly fixes filter-hiding CSS. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7114 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-17 09:07:41 UTC --- Removing a hardcoded styling is always good. This should never have been in the templates in fact ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7114 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org