[Bug 23611] New: Add columns configuration and export options to authorized values administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Bug ID: 23611 Summary: Add columns configuration and export options to authorized values administration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, testopia@bugs.koha-community.org I propose to add column configuration and export options to the authorized values administration page. The table would only have one toggle-able column, but I think the export options could be useful to libraries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23612 Summary|Add columns configuration |Add export option to |and export options to |authorized values |authorized values |administration |administration | --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #0)
The table would only have one toggle-able column
Now with a dependency on Bug 23612 I'm going to leave out the column configuration altogether and just include the export option. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23612 [Bug 23612] If no columns in a table can be toggled, don't show columns button -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92819&action=edit Bug 23611: Add export option to authorized values administration This patch changes the authorized values DataTables configuration to add export options. To test apply the patch and go to Administration -> Authorized values. Test the "Export" button and confirm that the data is exported correctly with each option. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92819|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 92866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92866&action=edit Exports nicely with all 4 options. Signing off. Bug 23611: Add export option to authorized values administration This patch changes the authorized values DataTables configuration to add export options. To test apply the patch and go to Administration -> Authorized values. Test the "Export" button and confirm that the data is exported correctly with each option. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patch appears to break sorting on the individual category pages (like HINGS_PF for example) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 93501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93501&action=edit Bug 23611: (follow-up) Correct ID of table The DataTable configuration wasn't working on the table showing an individual category's authorized values because of a mismatch in the table id. This patch corrects it. To test, apply the patch and view the "Authorized values" page. The initial list of categories should be displayed as a DataTable. Click through to see the values defined for any category. The resulting table of values should also be a functioning DataTable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, last request (I hope) - can you please remove the action buttons from the print view and other export options? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 93615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93615&action=edit Bug 23611: (follow-up) Exclude "actions" column from export This patch adds a missing "noExport" class to ensure that the "actions" column isn't included in export and print views. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93616&action=edit Bug 23611: Add export option to authorized values administration This patch changes the authorized values DataTables configuration to add export options. To test apply the patch and go to Administration -> Authorized values. Test the "Export" button and confirm that the data is exported correctly with each option. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93501|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93617&action=edit Bug 23611: (follow-up) Correct ID of table The DataTable configuration wasn't working on the table showing an individual category's authorized values because of a mismatch in the table id. This patch corrects it. To test, apply the patch and view the "Authorized values" page. The initial list of categories should be displayed as a DataTable. Click through to see the values defined for any category. The resulting table of values should also be a functioning DataTable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93615|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93618&action=edit Bug 23611: (follow-up) Exclude "actions" column from export This patch adds a missing "noExport" class to ensure that the "actions" column isn't included in export and print views. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #92866|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org