https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |remi.mayrand-provencher@inL |ity.org |ibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50438|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 51931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51931&action=edit Bug 16126 - Display base-level amounts on the acquisition module home page This patch will display on the acquisition module home page the information already displayed on the "manage fund" page (aqbudgets.pl). Currently, Koha display the base-level amounts only. This patch will : 1. rename the column "ordered", "spent" and "available" to "base-level [ordered|spent|available]" 2. add the column "ordered", "spent" and available with the same calculation from the "manage fund" page. TEST PLAN : 1. Go to the Administration module 2. Add a new budget (ie : Budget 2016) 3. Add a fund to this budget (ie : Book) 4. Add a child fund (ie : Adult fiction) You will have this hierarchy : Budget 2016 |____ Book |_____ Adult fiction 5. Go to the Acquisition module 6. Place an order and use the "Adult fiction" budget 7. Go back the Acquisition home page and compare the table with the table from the aqbudgets.pl page (Administration > Budget > Fund) 8. You will see : BEFORE PATCH : the base level amounts only AFTER PATCH : the base level and the total amounts Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think that the goal of this table (on the acq home page) was to display a simplified version of the table on the "all funds" view. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55810&action=edit Screenshot of current table on acq start page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |nicolas.legrand@bulac.fr, | |severine.queune@bulac.fr, | |sonia.bouis@univ-lyon3.fr --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #7)

So the table is more compact and easy to follow.

Well not really, it is less compact than before. I'd like more opinions on this one, Nicolas, Séverine or Sonia maybe (See comments 5 & 6). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #9)

(In reply to Jonathan Druart from comment #8)

...

(In reply to Tomás Cohen Arazi from comment #7)

...

So the table is more compact and easy to follow.

Well not really, it is less compact than before.

I meant it was more compact than the funds one. Of course it is adding columns to the original one! hehe

...

I'd like more opinions on this one, Nicolas, Séverine or Sonia maybe (See comments 5 & 6).

Yeah, I think it is important to listen to interested parties. My feeling is that the 'compact' one (a.k.a. 'the original') is not useful at all. Even if it was just duplicating the funds one, I think it is worth doing.

I agree with Tomas. In addition table columns can always be hidden with css as link as they are IDed/classed properly. I don't think you'll every find a library that strongly expressed how this table has too much data ; ) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, it's already possible to control visibility with the permissions on fund level. You can especially limit to the home library of the patron. I think restricting to only the library you are logged in at is too general and would not work for every library system. There are setups where a main library orders for all others. This should be configurable, but we already have a complicated permission system on the funds. I feel like we should not make it more complicated. Hiding columns/cells is often not really possible when datatables are used - this table is getting more and more complicated. So even if there are ids, it's not always easy to make it work. I feel we should have a clear concept about what is the difference (or not) between the one on acq home page and the one on the funds page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 --- Comment #14 from J Schmidt <jschmidt@switchinc.org> --- Basically our group is still interested. We want a subtotal per branch's budget on the acqui-home.pl page. Right now the total at the bottom isn't calculated correctly and is including multiple branches and their budgets.....Staff are able to view funds and dollar amounts tied to funds for any library's budget. There are permission restrictions at the point of ordering and editing. However, the viewing of budget information on a few Koha Acq pages still remains. Thanks. jls. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 --- Comment #16 from J Schmidt <jschmidt@switchinc.org> --- Hello Katrin, I hope this is possible. I don't mind being corrected. Just to clarify, one branch library wants to ONLY view their own budget from the acqui/acqui-home.pl screen. ... not any other libraries' budgets or funds (with dollar amounts)... I am not seeing any permissions where one can manage and view only their library's budget... I'll double check to see if the one branch I'm looking at today has a proper total at the bottom given how I'm logged in (as that same branch). Maybe the total at the bottom is correct for the branch EVEN THOUGH I can view the other budgets in the table as a whole. That's possible. thanks. jen. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #18 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hello, we are not using child fund in my library so we aren't really concerned. But, if the table is less compact than before it's still acceptable for me. More opinion from librarians using child fund would be better than my reply on this one.. But, concerning the discussion between Katrin and Jen, in my library, we need to see funds from all branches on acq-home page. I'm agree with Katrin, it's possible to change the display of acq-home page according to user permissions and fund setting. Sonia -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 --- Comment #19 from J Schmidt <jschmidt@switchinc.org> --- Hello, I finally had the chance to come back to this today. Thank you Katrin as I believe I have made changes to staff permissions to successfully limit the viewing of non-home library budgets. Appreciated. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA CC| |charles.farmer@inlibro.com --- Comment #20 from Charles Farmer <charles.farmer@inlibro.com> --- Doesn't apply, will submit rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64659|0 |1 is obsolete| | --- Comment #21 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Created attachment 84094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84094&action=edit Bug 16126 - Display base-level amounts on the acquisition module home page This patch will display on the acquisition module home page the information already displayed on the "manage fund" page (aqbudgets.pl). Currently, Koha display the base-level amounts only. This patch will : 1. rename the column "ordered", "spent" and "available" to "base-level [ordered|spent|available]" 2. add the column "ordered", "spent" and available with the same calculation from the "manage fund" page. TEST PLAN : 1. Go to the Administration module 2. Add a new budget (ie : Budget 2016) 3. Add a fund to this budget (ie : Book) 4. Add a child fund (ie : Adult fiction) You will have this hierarchy : Budget 2016 |____ Book |_____ Adult fiction 5. Go to the Acquisition module 6. Place an order and use the "Adult fiction" budget 7. Go back the Acquisition home page and compare the table with the table from the aqbudgets.pl page (Administration > Budget > Fund) 8. You will see : BEFORE PATCH : the base level amounts only AFTER PATCH : the base level and the total amounts Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I tested the functionality and it works as expected. It also passes the QA script. It basically adds 'base-level' information to the acquisitions page. The only difference with what is displayed on the funds page is that it doesn't add the base-level available amounts. So the table is more compact and easy to follow. I think this is a useful enhancement even if it makes this table closer to the funds one. I checked it totalizes correctly on each scenario and respects the acq workflow exactly as the funds table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #22 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 --- Comment #23 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93747&action=edit Bug 16126 - Display base-level amounts on the acquisition module home page This patch will display on the acquisition module home page the information already displayed on the "manage fund" page (aqbudgets.pl). Currently, Koha display the base-level amounts only. This patch will : 1. rename the column "ordered", "spent" and "available" to "base-level [ordered|spent|available]" 2. add the column "ordered", "spent" and available with the same calculation from the "manage fund" page. TEST PLAN : 1. Go to the Administration module 2. Add a new budget (ie : Budget 2016) 3. Add a fund to this budget (ie : Book) 4. Add a child fund (ie : Adult fiction) You will have this hierarchy : Budget 2016 |____ Book |_____ Adult fiction 5. Go to the Acquisition module 6. Place an order and use the "Adult fiction" budget 7. Go back the Acquisition home page and compare the table with the table from the aqbudgets.pl page (Administration > Budget > Fund) 8. You will see : BEFORE PATCH : the base level amounts only AFTER PATCH : the base level and the total amounts Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I tested the functionality and it works as expected. It also passes the QA script. It basically adds 'base-level' information to the acquisitions page. The only difference with what is displayed on the funds page is that it doesn't add the base-level available amounts. So the table is more compact and easy to follow. I think this is a useful enhancement even if it makes this table closer to the funds one. I checked it totalizes correctly on each scenario and respects the acq workflow exactly as the funds table. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23767 Status|Signed Off |In Discussion --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I found this after having tested bug 23767 earlier and I think we should think about merging both bugs in a way - they deal with very similar problems. I will move both to 'in Discussion' meaning that I hope you can talk to each other and figure out the best way to move those 2 forward! 1) I notice the removal of the "Total available" here. I think this is one of the things libraries really look at - would it be possible to add it back? 2) Also in my case I have the following: Parent fund, spent: 0,00 Sub fund, spent: 2,00 For Total spent: It shows on both parent and sub fund level, adding up to 2 still. = OK For Base-level spent: 2,00 shows, but is added up to 0,00 Total. So... the totals are quite confusing: 2+2 = 2 2+0 = 0 As it's the same we display on budget, maybe adopting the "italic" formatting from the budgets page could help a little here. Attaching a screnshot. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel this has been resolved by bug 23767 in a way. *** This bug has been marked as a duplicate of bug 23767 *** -- You are receiving this mail because: You are watching all bug changes.