[Bug 13577] New: The correct COLLATE set to all DB tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Bug ID: 13577 Summary: The correct COLLATE set to all DB tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 11944 added the COLLATE=utf8_unicode_ci to all DB tables. But some new tables have been created between the write of the patch set and the push to master. So these new tables don't have the correct collate. The error is: ERROR 1005 (HY000) at line 3493: Can't create table 'koha.items_search_fields' (errno: 150) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m Status|NEW |ASSIGNED Depends on| |11944 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35176&action=edit Bug 13577: Add the utf8_unicode_ci COLLATE to all tables Bug 11944 added the COLLATE=utf8_unicode_ci to all DB tables. But some new tables have been created between the write of the patch set and the push to master. So these new tables don't have the correct collate. Test plan: 0/ Reproduce the error: mysql> create database koha_test CHARACTER SET utf8 COLLATE utf8_unicode_ci; mysql koha_test < installer/data/mysql/kohastructure.sql It will boom with: ERROR 1005 (HY000) at line 3493: Can't create table `koha_test`.`items_search_fields` (errno: 150 "Foreign key constraint is incorrectly formed") 1/ Apply the patch, destroy the DB and recreate it: mysql> create database koha_test CHARACTER SET utf8 COLLATE utf8_unicode_ci; mysql> drop database koha_test; mysql koha_test < installer/data/mysql/kohastructure.sql All tables should be inserted without any error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11425 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi@cineca.it Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35176|0 |1 is obsolete| | --- Comment #2 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35182&action=edit [SIGNED OFF] Bug 13577: Add the utf8_unicode_ci COLLATE to all tables I've applied this patch against master 3.19.00.006 Everything's OK. I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The correct COLLATE set to |The correct COLLATE are not |all DB tables |set to all DB tables -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The correct COLLATE are not |The correct COLLATE is not |set to all DB tables |set to all DB tables -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35182|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35333&action=edit [PASSED QA] Bug 13577: Add the utf8_unicode_ci COLLATE to all tables Bug 11944 added the COLLATE=utf8_unicode_ci to all DB tables. But some new tables have been created between the write of the patch set and the push to master. So these new tables don't have the correct collate. Test plan: 0/ Reproduce the error: mysql> create database koha_test CHARACTER SET utf8 COLLATE utf8_unicode_ci; mysql koha_test < installer/data/mysql/kohastructure.sql It will boom with: ERROR 1005 (HY000) at line 3493: Can't create table `koha_test`.`items_search_fields` (errno: 150 "Foreign key constraint is incorrectly formed") 1/ Apply the patch, destroy the DB and recreate it: mysql> create database koha_test CHARACTER SET utf8 COLLATE utf8_unicode_ci; mysql> drop database koha_test; mysql koha_test < installer/data/mysql/kohastructure.sql All tables should be inserted without any error. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- QA Question: Should we also be fixing this via updatedatabase.pl? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think if the update is ok between stable releases and as the utf-8 patches have just been pushed, it's probably ok to skip the database update here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I wish I'd spotted this before it had been pushed.. oops. I would have said, can we do a check on whether tables are _mb4 before running the change.. I know we've got mb4 set which give minor advantages over not _mb4 encoding.. but mroe importantly, if you've already got a utf8 database (especialyl with _mb4) you shuld nto have to run the db update at all, thus saving allot of time at upgrade time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Also,.. i believe the use of ->tables is deprecated? https://metacpan.org/pod/DBI#tables -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 35384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35384&action=edit BUG 7134 [QA Followup]: Prevent utf8mb4 collation change utf8mb4 is a superset of utf8 adn thus is compatible. We should not force an entire db change upon people who have proactively set utf8 encoding before now. This patch aslo removed the deprecaed ->tables stanze in favour of the table_info stanze. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Wrong bug.. my bad. Making a new one now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35384|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13596 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org --- Comment #11 from Dobrica Pavlinusic <dpavlin@rot13.org> --- We have a minor problem with databases created with When trying to access it with mysql client from command line, I get following error in where: Illegal mix of collations (utf8_unicode_ci,IMPLICIT) and (utf8_general_ci,IMPLICIT) for operation '=' However, fix is simple: mysql> alter database koha collate = 'utf8_unicode_ci' ; I'm wondering if we should alter database collate also to avoid problems like this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Dobrica Pavlinusic from comment #11) Dobrica, could you please detail how did you get this error? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Bug 13577 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org