[Bug 31967] New: Search terms retained in header search for details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Bug ID: 31967 Summary: Search terms retained in header search for details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 26247 added a system preference to manage the Retaining of search terms in header search. But this does not work if there is only one match and you go directly to details page. This needs to be fixed in Javascript : https://git.koha-community.org/Koha-community/Koha/src/commit/b0cf6c087b9e23... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 [Bug 26247] Search terms retained in header search creates UX inconsistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED QA Contact|testopia@bugs.koha-communit |fridolin.somers@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27697 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search terms retained in |Search terms retained in |header search for details |header search when only one |page |result -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 142600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142600&action=edit Bug 31967: Search terms retained in header search when only one result Bug 26247 added a system preference to manage the Retaining of search terms in header search. But this does not work if there is only one match and you go directly to details page. Test plan : 1) Set system preference RetainCatalogSearchTerms to "Don't retain" 2) Perform a search leading to a single result. For example in KTD the ISBN 1932100083 => Without patch search bar is populated with search terms => With patch search bar is not populated with search terms -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Some librarians reported this is reaaaaaaally important since they search by scanning ISBN or item barcode. Retaining search terms does not allow to scan another barcode directly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142600|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 142601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142601&action=edit Bug 31967: Search terms retained in header search when only one result Bug 26247 added a system preference to manage the Retaining of search terms in header search. But this does not work if there is only one match and you go directly to details page. Test plan : 1) Set system preference RetainCatalogSearchTerms to "Don't retain" 2) Perform a search leading to a single result. For example in KTD the ISBN 1932100083 => Without patch search bar is populated with search terms => With patch search bar is not populated with search terms Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|fridolin.somers@biblibre.co |testopia@bugs.koha-communit |m |y.org Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142601|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142984&action=edit Bug 31967: Search terms retained in header search when only one result Bug 26247 added a system preference to manage the Retaining of search terms in header search. But this does not work if there is only one match and you go directly to details page. Test plan : 1) Set system preference RetainCatalogSearchTerms to "Don't retain" 2) Perform a search leading to a single result. For example in KTD the ISBN 1932100083 => Without patch search bar is populated with search terms => With patch search bar is not populated with search terms Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial fix, works.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Bug 31967 depends on bug 26247, which changed state. Bug 26247 Summary: Search terms retained in header search creates UX inconsistency https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org