[Bug 29312] New: Punctuation: Total number of results: 961 (300 shown) .
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 Bug ID: 29312 Summary: Punctuation: Total number of results: 961 (300 shown) . Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org This is from the results of a saved SQL report: Total number of results: 961 (300 shown) . We should either remove the extra . or remove the extra space. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 --- Comment #1 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132973&action=edit Bug 29312: Remove unnecessary point This patch removes an extra point after the number of shown results. Test plan : - don't apply patch - run a report that brings you more than 20 results, e.g. SELECT * FROM biblio LIMIT 50 - see extra ' .' after the number of shown results - apply patch - run the report again and see the point isn't displayed anymore - check the behaviour is still correct when you change the number of rows displayed - sign off ! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Assignee|koha-bugs@lists.koha-commun |severine.queune@bulac.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132973|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 135458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135458&action=edit Bug 29312: Remove unnecessary point This patch removes an extra point after the number of shown results. Test plan : - don't apply patch - run a report that brings you more than 20 results, e.g. SELECT * FROM biblio LIMIT 50 - see extra ' .' after the number of shown results - apply patch - run the report again and see the point isn't displayed anymore - check the behaviour is still correct when you change the number of rows displayed - sign off ! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18283 CC| |jonathan.druart+koha@gmail. | |com, | |nick@bywatersolutions.com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Nick, extra '.' or extra space? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 [Bug 18283] Display improvements on report results - hide code and change wording -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #3)
Nick, extra '.' or extra space?
It looks good without the dot -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Jonathan Druart from comment #3)
Nick, extra '.' or extra space?
To me, it's an information not a sentence so dot didn't seem necessary. I can change that if you prefer, though, Jonathan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135458|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135503&action=edit Bug 29312: Remove unnecessary dot This patch removes an extra point after the number of shown results. Test plan : - don't apply patch - run a report that brings you more than 20 results, e.g. SELECT * FROM biblio LIMIT 50 - see extra ' .' after the number of shown results - apply patch - run the report again and see the point isn't displayed anymore - check the behaviour is still correct when you change the number of rows displayed - sign off ! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Séverine Queune from comment #5)
(In reply to Jonathan Druart from comment #3)
Nick, extra '.' or extra space?
To me, it's an information not a sentence so dot didn't seem necessary. I can change that if you prefer, though, Jonathan.
I don't care, I am happy with both :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #4)
(In reply to Jonathan Druart from comment #3)
Nick, extra '.' or extra space?
It looks good without the dot
Thanks for your quick response! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.03 released in| | CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org