[Bug 11593] New: subtag_registry.sql files contain the same information for each language
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Bug ID: 11593 Summary: subtag_registry.sql files contain the same information for each language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr For each language in the installation, there's a mandatory subtag_registry.sql -file, that contains the language names. Each of those files contain the same language information. This is unnecessary duplication, and makes adding new install languages harder, because the same information needs to be added to each of those files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26772&action=edit Bug 11593 - subtag_registry.sql files contain the same information for each language This patch removes subtag_registry.sql from lang dirs, and put it on a new mandatory dir In that way we need to update only one file. All similar files are removed. To test: 1) Try a new install, or simply create a new database, grant permissions on it, change koha-conf.xml to use this database and go to staff page 2) Go step by step until all mandatory or optional sql files are loaded. Check that subtag_registry.sql is loaded. 3) Do it again but on other language. First install translation and repeat 2), could use de-DE or fr-FR -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26772|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32783&action=edit Bug 11593 - subtag_registry.sql files contain the same information for each language This patch removes subtag_registry.sql from lang dirs, and put it on a new mandatory dir In that way we need to update only one file. All similar files are removed. To test: 1) Try a new install, or simply create a new database, grant permissions on it, change koha-conf.xml to use this database and go to staff page 2) Go step by step until all mandatory or optional sql files are loaded. Check that subtag_registry.sql is loaded. 3) Do it again but on other language. First install translation and repeat 2), could use de-DE or fr-FR Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32783|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32806&action=edit [PASSED QA] Bug 11593 - subtag_registry.sql files contain the same information for each language This patch removes subtag_registry.sql from lang dirs, and put it on a new mandatory dir In that way we need to update only one file. All similar files are removed. To test: 1) Try a new install, or simply create a new database, grant permissions on it, change koha-conf.xml to use this database and go to staff page 2) Go step by step until all mandatory or optional sql files are loaded. Check that subtag_registry.sql is loaded. 3) Do it again but on other language. First install translation and repeat 2), could use de-DE or fr-FR Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, tested with de-DE. Thx! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32807&action=edit Bug 11593: Remove subtag_registry.txt This file is no longer needed by the web installer and can be deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bernardo, what do you think about removing the text file (see second patch)? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Katrin Fischer from comment #5)
Bernardo, what do you think about removing the text file (see second patch)?
It's only a description, could be removed... and it's already done :) I will rework Bug 12250 and complete missing language descriptions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tomas was fast :) Hope you don't mind! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org