[Bug 19194] New: Internal server error when receiving an order with no itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Bug ID: 19194 Summary: Internal server error when receiving an order with no itemtype Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org To reproduce: 1) Find a record with an item that has no itemtype (or remove the itemtype of an item) 2) Go to Acquisitions -> Find a vendor or make a new one -> create a new basket 3) Add the record from Step 1 to your basket 4) Close the basket 5) Go back to the vendor and click 'Receive shipments' 6) Put in an invoice number, click Next 7) Click the Receive link for your item 8) Confirm you see an internal server error In the error log: Can't call method "description" on an undefined value at /home/vagrant/kohaclone/acqui/orderreceive.pl line 150. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 66573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66573&action=edit Bug 19194: Check itemtype is defined when receiving an order To test: 1) Find a record with an item that has no itemtype (or remove the itemtype of an item) 2) Go to Acquisitions -> Find a vendor or make a new one -> create a new basket 3) Add the record from Step 1 to your basket 4) Close the basket 5) Go back to the vendor and click 'Receive shipments' 6) Put in an invoice number, click Next 7) Click the Receive link for your item 8) Confirm you see an internal server error 9) Apply the patch and refresh the page 10) The error should be gone and behaviour should continue as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #2 from Hugo Agud <hagud@orex.es> --- I am going to check this patch, just one quick question.. when you say itemtype you refer to items.itype right? itemtype If I am not wrong refers to tag 942$c of the bibliografic according the text I guess you're refereing to itype, please may you confirm? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66573|0 |1 is obsolete| | --- Comment #3 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 66674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66674&action=edit Bug 19194: Check itemtype is defined when receiving an order To test: 1) Find a record with an item that has no itemtype (or remove the itemtype of an item) 2) Go to Acquisitions -> Find a vendor or make a new one -> create a new basket 3) Add the record from Step 1 to your basket 4) Close the basket 5) Go back to the vendor and click 'Receive shipments' 6) Put in an invoice number, click Next 7) Click the Receive link for your item 8) Confirm you see an internal server error 9) Apply the patch and refresh the page 10) The error should be gone and behaviour should continue as expected Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Hugo Agud from comment #2)
I am going to check this patch, just one quick question.. when you say itemtype you refer to items.itype right? itemtype If I am not wrong refers to tag 942$c of the bibliografic
according the text I guess you're refereing to itype, please may you confirm?
I did mean itemtype as in tag 942c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66674|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66682&action=edit Bug 19194: Check itemtype is defined when receiving an order To test: 1) Find a record with an item that has no itemtype (or remove the itemtype of an item) 2) Go to Acquisitions -> Find a vendor or make a new one -> create a new basket 3) Add the record from Step 1 to your basket 4) Close the basket 5) Go back to the vendor and click 'Receive shipments' 6) Put in an invoice number, click Next 7) Click the Receive link for your item 8) Confirm you see an internal server error 9) Apply the patch and refresh the page 10) The error should be gone and behaviour should continue as expected Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |17843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 17843 but can easily adapt for 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.04. Depends on Bug 17843 but can easily adapt for 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Depending bug is not in 16.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 19063 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21842 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org