[Bug 28408] New: Last modification date for suggestions is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Bug ID: 28408 Summary: Last modification date for suggestions is wrong Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In the DB suggestions have a column: last_modification_date `lastmodificationdate` date DEFAULT NULL COMMENT 'date of the last modification', It is not updated when a suggestion is modified, however, the date field is: `date` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP COMMENT 'date and time the suggestion was updated', On the interface we display the first as "Last modification on" - which is confusing if you update a suggestion, and the date doesn't change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23590 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Linking this to the introducing bug 23590. The last_modification_date is linked to last_modified_by - so not all changes will udpate the date. I am not sure to make this more clear, but comments on bug 23590 indicate it is the intended behaviour. See: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590#c101 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Add the ability to change the manager of a suggestion and notify the new manager -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121482&action=edit Bug 28408: Add 'Last updated' column to suggestions table We have specific meanings for the different dates in suggestions Managed - means the status was changed or the suggestion edited, but doesn't change if item type updated Modification - implies an edit of the subscript, not updated if status changed alone Updated - this is the date field in the DB, which is actually a timestamp The cronjob purge_suggestions.pl uses teh 'date' field For a user, a suggestion can look old in the interface, but be considered recent by the script To clear the confusion we should show the timestamp as well To test: 1 - Add a suggestion 2 - In the DB, pretend you set it in the past: UPDATE suggestions SET manageddate='2021-01-01', suggesteddate='2021-01-01', date='2021-01-01 12:12:12'; 3 - Click 'Go' In Organize by: Status 4 - Note the suggestion looks old now 5 - Check the box, and click 'Update item types with:' -> Submit 6 - Prganize by status again 7 - No change? 8 - Check the DB: SELECT date FROM suggestions; 9 - The field is updated 10 - Apply patch 11 - Organize by status again 12 - See the 'Last updated' ate set to today -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121482|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 121634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121634&action=edit Bug 28408: Add 'Last updated' column to suggestions table We have specific meanings for the different dates in suggestions Managed - means the status was changed or the suggestion edited, but doesn't change if item type updated Modification - implies an edit of the subscript, not updated if status changed alone Updated - this is the date field in the DB, which is actually a timestamp The cronjob purge_suggestions.pl uses teh 'date' field For a user, a suggestion can look old in the interface, but be considered recent by the script To clear the confusion we should show the timestamp as well To test: 1 - Add a suggestion 2 - In the DB, pretend you set it in the past: UPDATE suggestions SET manageddate='2021-01-01', suggesteddate='2021-01-01', date='2021-01-01 12:12:12'; 3 - Click 'Go' In Organize by: Status 4 - Note the suggestion looks old now 5 - Check the box, and click 'Update item types with:' -> Submit 6 - Prganize by status again 7 - No change? 8 - Check the DB: SELECT date FROM suggestions; 9 - The field is updated 10 - Apply patch 11 - Organize by status again 12 - See the 'Last updated' ate set to today Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121634|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 123136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123136&action=edit Bug 28408: Add 'Last updated' column to suggestions table We have specific meanings for the different dates in suggestions Managed - means the status was changed or the suggestion edited, but doesn't change if item type updated Modification - implies an edit of the subscript, not updated if status changed alone Updated - this is the date field in the DB, which is actually a timestamp The cronjob purge_suggestions.pl uses teh 'date' field For a user, a suggestion can look old in the interface, but be considered recent by the script To clear the confusion we should show the timestamp as well To test: 1 - Add a suggestion 2 - In the DB, pretend you set it in the past: UPDATE suggestions SET manageddate='2021-01-01', suggesteddate='2021-01-01', date='2021-01-01 12:12:12'; 3 - Click 'Go' In Organize by: Status 4 - Note the suggestion looks old now 5 - Check the box, and click 'Update item types with:' -> Submit 6 - Prganize by status again 7 - No change? 8 - Check the DB: SELECT date FROM suggestions; 9 - The field is updated 10 - Apply patch 11 - Organize by status again 12 - See the 'Last updated' ate set to today Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should the bug title be updated a bit to make the issue/solution a bit clearer? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123179&action=edit Bug 28408: Add new column to the table settings config -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 [Bug 28855] Purging Suggestions test should not being on timestamp -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org