https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #234 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

which includes dropdown select / scroll behaviour improvements

:D -----

I'll be taking a look at the failing cypress tests as well.

Thanks, it's very handy we can have UI tests due to being done with Vue ^^ ------ I forgot there was also this failure in the lower level tests: t/db_dependent/Overdues.t .. 8/19 # Looks like you planned 19 tests but ran 9. I don't know if that's just the expected change from the removed tests or if there is an actual issue. --------

Inserting :undef: default most frequent delay for overdue_1: Inserting :undef:undef default most frequent notice for overdue_1: Inserting :undef:undef default most frequent mtt for overdue_1:

About this output, at first I though there where issues of undef variables. Like with the uninitialized values earlier reports. , does "all" fits better than undef? I picked it from the circulation rules page but maybe it doesn't have the same meaning? It's only about not scaring an admin about the update having an issue. -------- I tried on main to add two default actions and one action on a specific library. So 3 records in overduerules tables. And the update output is Inserting :J: overdue_1_delay: 2 Inserting :J: overdue_1_notice: AR_COMPLETED Inserting :J: overdue_1_restrict: 1 Inserting :J: overdue_1has_rules: 1 Inserting :J: overdue_2_delay: 6 Inserting :J: overdue_2_restrict: 1 Inserting :J: overdue_2has_rules: 1 Inserting :J: overdue_3_delay: 9 Inserting :J: overdue_3_notice: AR_CANCELED Inserting :J: overdue_3_restrict: 1 Inserting :J: overdue_3has_rules: 1 Inserting :HB: overdue_1_delay: 2 Inserting :HB: overdue_1_notice: ACCOUNT_DEBIT Inserting :HB: overdue_1_mtt: email,print Inserting :HB: overdue_1_restrict: 1 Inserting :HB: overdue_1has_rules: 1 Inserting :HB: overdue_2_delay: 5 Inserting :HB: overdue_2_notice: ACCOUNT_WRITEOFF Inserting :HB: overdue_2_mtt: email,print Inserting :HB: overdue_2_restrict: 1 Inserting :HB: overdue_2has_rules: 1 Inserting :HB: overdue_3_delay: 6 Inserting :HB: overdue_3_notice: PREDUEDGST Inserting :HB: overdue_3_mtt: email,print Inserting :HB: overdue_3_restrict: 1 Inserting :HB: overdue_3has_rules: 1 Inserting :undef: default most frequent delay for overdue_1: Inserting :undef:undef default most frequent notice for overdue_1: Inserting :undef:undef default most frequent mtt for overdue_1: Inserting :undef:undef default most frequent restrict for overdue_1: 0 Inserting :undef:undef default has_rules for overdue_1: 1 Inserting :undef: default most frequent delay for overdue_2: Inserting :undef:undef default most frequent notice for overdue_2: Inserting :undef:undef default most frequent mtt for overdue_2: Inserting :undef:undef default most frequent restrict for overdue_2: 0 Inserting :undef:undef default has_rules for overdue_2: 1 Inserting :undef: default most frequent delay for overdue_3: Inserting :undef:undef default most frequent notice for overdue_3: Inserting :undef:undef default most frequent mtt for overdue_3: Inserting :undef:undef default most frequent restrict for overdue_3: 0 Inserting :undef:undef default has_rules for overdue_3: 1 Inserting FFL:undef: default most frequent delay for overdue_1: 1 Inserting FFL:undef:undef default most frequent notice for overdue_1: AR_CANCELED Inserting FFL:undef:undef default most frequent mtt for overdue_1: email Inserting FFL:undef:undef default most frequent restrict for overdue_1: 1 Inserting FFL:undef:undef default has_rules for overdue_1: 1 Inserting FFL:undef: default most frequent delay for overdue_2: 2 Inserting FFL:undef:undef default most frequent notice for overdue_2: PREDUEDGST Inserting FFL:undef:undef default most frequent mtt for overdue_2: email Inserting FFL:undef:undef default most frequent restrict for overdue_2: 1 Inserting FFL:undef:undef default has_rules for overdue_2: 1 Inserting FFL:undef: default most frequent delay for overdue_3: 3 Inserting FFL:undef:undef default most frequent notice for overdue_3: ODUE Inserting FFL:undef:undef default most frequent mtt for overdue_3: email Inserting FFL:undef:undef default most frequent restrict for overdue_3: 1 Inserting FFL:undef:undef default has_rules for overdue_3: 1 Does anyone know that are expectable sizes of the overduerules table with a large network of libraries? Because even without much per-library specific rules, the output of this bug might be much longer than the rest of the upgrade and flood it. While still being very useful here to test and review. And eventually investigate issues when production upgrades will happen. Wait, for that, this should do: SELECT * FROM circulation_rules WHERE rule_name LIKE 'overdue\_%'; It's not as nice as with the explicit "frequent delay" but that might be a trade-off. Anyway it depends on how large all the current output can be. --------

I'm aiming to resubmit by Friday this week.

No worries, I hope there won't be too many hurdles. And the stuff about the upgrade output can wait the next round of patch revisions, actual testing doesn't depend on it. -- You are receiving this mail because: You are watching all bug changes.