[Bug 12062] New: Untranslatable "Reserve not found"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Bug ID: 12062 Summary: Untranslatable "Reserve not found" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr circ/hold-transfer-slip.pl: $slip = "Reserve not found"; The same file also has the title hardcoded as "Koha -- Circulation: Transfers" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27397&action=edit Bug 12062 - Untranslatable "Reserve not found" This patch rewrites transfer slip code to make some strings translatable. Also simplifies some code and parameters. To test: 1) Produce a transfer slip, no changes must be noted. 2) Update por file, new strings 'Koha -- Circulation: Transfers' and 'Reserve not found' must be present -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel@gmail.com Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This patch really ought to update the text to use the correct term: 'hold' instead of 'reserve.' While you're at it, the page title ought to conform to other pages: Koha › Circulation › Transfers Not a big deal, but consistency is good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27397|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27401&action=edit Bug 12062 - Untranslatable "Reserve not found" This patch rewrites transfer slip code to make some strings translatable. Also simplifies some code and parameters. To test: 1) Produce a transfer slip, no changes must be noted. 2) Update PO file, new strings msgid "%s %s%s%sNo hold found%s %s %s " msgid "%s%s%sNo hold found%s " msgid "Koha › Circulation › Transfers" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Owen Leonard from comment #2)
Not a big deal, but consistency is good.
Of course :) New patch to test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27401|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27430&action=edit [SIGNED-OFF] Bug 12062 - Untranslatable "Reserve not found" This patch rewrites transfer slip code to make some strings translatable. Also simplifies some code and parameters. To test: 1) Produce a transfer slip, no changes must be noted. 2) Update PO file, new strings msgid "%s %s%s%sNo hold found%s %s %s " msgid "%s%s%sNo hold found%s " msgid "Koha › Circulation › Transfers" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- printslip.tt is used by circ/transfer-slip.pl, members/printslip.pl and opac/sco/printslip.pl as well as circ/hold-transfer-slip.pl The fixed title will not work here. You'll need to add a flag and title for each of these scripts to the template so each can have a separate translatable title. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27780&action=edit Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27780|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27782&action=edit Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #9 from paxed <pasi.kallinen@pttk.fi> --- <title>Koha › Members › Print receipt for [%- borrowernumber -%]</title> The [%- will eat away the space between the "for" and the borrowernumber. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27782|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27818&action=edit Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to paxed from comment #9)
<title>Koha › Members › Print receipt for [%- borrowernumber -%]</title>
The [%- will eat away the space between the "for" and the borrowernumber.
Thanks, now is fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12043 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Not sure it is pertinent, but bug 12043 impacts the same templates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27818|0 |1 is obsolete| | --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 29463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29463&action=edit Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The QA script points out a problem with these patches: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt OK tt_valid FAIL valid_template parse error - /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt line 3: unexpected end of directive [% IF ( caller = 'hold-transfer' %] I am fixing this in a follow up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27430|0 |1 is obsolete| | Attachment #29463|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29515&action=edit [PASSED QA] Bug 12062 - Untranslatable "Reserve not found" This patch rewrites transfer slip code to make some strings translatable. Also simplifies some code and parameters. To test: 1) Produce a transfer slip, no changes must be noted. 2) Update PO file, new strings msgid "%s %s%s%sNo hold found%s %s %s " msgid "%s%s%sNo hold found%s " msgid "Koha › Circulation › Transfers" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29516&action=edit [PASSED QA] Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29517&action=edit Bug 12062: Follow up - adds missing ) With this patch, patches pass QA script and unit tests. Tested printing different slips successfully. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Bernardo and Katrina! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org