[Bug 20253] New: Optionally use buyer's purchase order number from Edifact quote in basketname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Bug ID: 20253 Summary: Optionally use buyer's purchase order number from Edifact quote in basketname Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Current default behaviour is to use the filename of the QUOTE in the basketname. This would instead use the buyer's purchase order number (segment RFF with a qualifier ON) instead so that this would be searchable. This should be optional as even when supplied many (most) sites do not have meaningful or distinctive data in the field (e.g. 'Books for branch X'). Logical is to add it as a vendor option -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Jeremy Evans <jeremy.evans@phe.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@phe.gov.uk --- Comment #1 from Jeremy Evans <jeremy.evans@phe.gov.uk> --- We would support this. We have recently started using EDI and one of the issues is not being able to see the basket name from the vendor in Koha. We enter a basket name on the vendor site based on site/date etc so we can tell from the basket name which site the order was placed for and the date. The quote in Koha only shows the file name. When we confirm the order, the actual order sent back to the vendor uses the Koha OrderID as the basket name. So we end up with 3 different references depending if it is a quote or order and whether you look in the vendor system or Koha so not easy to cross-check between the vendor and Koha. Ideally we would want to retain the vendor basketID in the Quote seen in Koha (or at least be able to see/search sort by this). It would also be useful to be able to use this as the basis for the orderID sent back to the vendor though it needs to be unique so would need koha to add some suffix to the order & quote don't have exactly the same refence on the vendor system -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Optionally use buyer's |Optionally use buyer's |purchase order number from |purchase order number from |Edifact quote in basketname |EDIFACT quote in basket | |name -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdunne-howrie@westminster.g | |ov.uk --- Comment #2 from Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> --- We also support this and would like to see this happen to automate the process and allow file names to be used for different purposes. Although, ideally, we'd want to see the order reference added in as the basket ID as opposed to the basket name. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183859&action=edit Bug 20253: Add tests for RFF+ON segment handling and basket naming This patch adds tests for: 1. RFF+ON (Purchase Order Number) segment parsing in EDIFACT messages 2. Vendor configuration for basket naming preferences 3. Basket naming logic in QUOTE processing Test coverage includes: - Message-level RFF+ON segment extraction - Validation that RFF+ON processing stops at LIN segments - Multiple RFF segment handling - Database field storage and constraints - Basket naming configuration logic - Fallback behavior when purchase order number unavailable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183860&action=edit Bug 20253: Add basket_name_source field to vendor_edi_accounts table This patch adds a new ENUM field 'basket_name_source' to the vendor_edi_accounts table to allow configuration of how basket names are generated from EDIFACT quotes. Options: - 'filename' (default): Use the EDIFACT filename as basket name - 'purchase_order_number': Use RFF+ON segment value as basket name Changes: - Added atomicupdate for existing installations - Updated kohastructure.sql for new installations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183861&action=edit Bug 20253: Optionally use buyer's purchase order number from EDIFACT quote in basket name This enhancement allows libraries to configure vendors to use the buyer's purchase order number (from RFF+ON segments) as the basket name instead of the EDIFACT filename, improving searchability and reference tracking. Backend Changes: - Added purchase_order_number() method to Koha::Edifact::Message to extract RFF+ON segments from message-level data (before first LIN segment) - Modified process_quote() in Koha::EDI to use purchase order number for basket naming when configured, with fallback to filename Frontend Changes: - Updated admin/edi_accounts.pl to handle basket_name_source parameter - Added "Basket name source" dropdown to EDI accounts template with options: - "Quote filename" (default) - "Purchase order number (RFF+ON)" Test Plan: 1. Apply patches and run database update 2. Go to Administration > Acquisitions > EDI accounts 3. Create or edit a vendor EDI account 4. Verify "Basket name source" dropdown appears with options: - "Quote filename" (default) - "Purchase order number (RFF+ON)" 5. Set to "Purchase order number (RFF+ON)" and save 6. Process an EDIFACT quote file that contains RFF+ON segments 7. Verify the created basket name uses the purchase order number instead of filename 8. Process a quote file without RFF+ON segments 9. Verify the basket name falls back to the filename 10. Test with "Quote filename" setting 11. Verify basket names use filenames regardless of RFF+ON presence 12. Run tests: prove t/Edifact_RFF_ON.t t/db_dependent/Koha/EDI.t The feature is optional and backward compatible - existing behavior is unchanged unless explicitly configured. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183862&action=edit Bug 20253: (follow-up) Add RFF+ON segments to outgoing ORDER messages When vendors are configured to use purchase order numbers for basket naming, the purchase order number should be included in outgoing ORDER messages as an RFF+ON (Reference - Order Number) segment for proper EDI workflow continuity. This follow-up ensures that: 1. Purchase order numbers from incoming QUOTE messages are preserved 2. The same purchase order numbers are sent back in ORDER messages 3. Vendors receive the reference numbers they expect for order processing Implementation: - Added _get_purchase_order_number() method to extract PO number from basket name when vendor is configured with basket_name_source = 'purchase_order_number' - Modified order_msg_header() to include RFF+ON segment when PO number available - Added comprehensive tests for RFF+ON segment generation in ORDER messages Test Plan: 1. Apply patches 2. Configure a vendor EDI account with "Basket name source" = "Purchase order number" 3. Process a QUOTE message containing RFF+ON segment 4. Verify basket is created with purchase order number as name 5. Generate ORDER message from the basket 6. Verify ORDER message contains RFF+ON segment with the purchase order number 7. Run tests: prove t/db_dependent/Koha/Edifact/Order.t This completes the round-trip EDI workflow for purchase order number handling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183859|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183953&action=edit Bug 20253: Add tests for RFF+ON segment handling and basket naming This patch adds tests for: 1. RFF+ON (Purchase Order Number) segment parsing in EDIFACT messages 2. Vendor configuration for basket naming preferences 3. Basket naming logic in QUOTE processing Test coverage includes: - Message-level RFF+ON segment extraction - Validation that RFF+ON processing stops at LIN segments - Multiple RFF segment handling - Database field storage and constraints - Basket naming configuration logic - Fallback behavior when purchase order number unavailable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183860|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183954&action=edit Bug 20253: Add basket_name_source field to vendor_edi_accounts table This patch adds a new ENUM field 'basket_name_source' to the vendor_edi_accounts table to allow configuration of how basket names are generated from EDIFACT quotes. Options: - 'filename' (default): Use the EDIFACT filename as basket name - 'purchase_order_number': Use RFF+ON segment value as basket name Changes: - Added atomicupdate for existing installations - Updated kohastructure.sql for new installations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183861|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183955&action=edit Bug 20253: Optionally use buyer's purchase order number from EDIFACT quote in basket name This enhancement allows libraries to configure vendors to use the buyer's purchase order number (from RFF+ON segments) as the basket name instead of the EDIFACT filename, improving searchability and reference tracking. Backend Changes: - Added purchase_order_number() method to Koha::Edifact::Message to extract RFF+ON segments from message-level data (before first LIN segment) - Modified process_quote() in Koha::EDI to use purchase order number for basket naming when configured, with fallback to filename Frontend Changes: - Updated admin/edi_accounts.pl to handle basket_name_source parameter - Added "Basket name source" dropdown to EDI accounts template with options: - "Quote filename" (default) - "Purchase order number (RFF+ON)" Test Plan: 1. Apply patches and run database update 2. Go to Administration > Acquisitions > EDI accounts 3. Create or edit a vendor EDI account 4. Verify "Basket name source" dropdown appears with options: - "Quote filename" (default) - "Purchase order number (RFF+ON)" 5. Set to "Purchase order number (RFF+ON)" and save 6. Process an EDIFACT quote file that contains RFF+ON segments 7. Verify the created basket name uses the purchase order number instead of filename 8. Process a quote file without RFF+ON segments 9. Verify the basket name falls back to the filename 10. Test with "Quote filename" setting 11. Verify basket names use filenames regardless of RFF+ON presence 12. Run tests: prove t/Edifact_RFF_ON.t t/db_dependent/Koha/EDI.t The feature is optional and backward compatible - existing behavior is unchanged unless explicitly configured. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183862|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183956&action=edit Bug 20253: (follow-up) Add RFF+ON segments to outgoing ORDER messages When vendors are configured to use purchase order numbers for basket naming, the purchase order number should be included in outgoing ORDER messages as an RFF+ON (Reference - Order Number) segment for proper EDI workflow continuity. This follow-up ensures that: 1. Purchase order numbers from incoming QUOTE messages are preserved 2. The same purchase order numbers are sent back in ORDER messages 3. Vendors receive the reference numbers they expect for order processing Implementation: - Added _get_purchase_order_number() method to extract PO number from basket name when vendor is configured with basket_name_source = 'purchase_order_number' - Modified order_msg_header() to include RFF+ON segment when PO number available - Added comprehensive tests for RFF+ON segment generation in ORDER messages Test Plan: 1. Apply patches 2. Configure a vendor EDI account with "Basket name source" = "Purchase order number" 3. Process a QUOTE message containing RFF+ON segment 4. Verify basket is created with purchase order number as name 5. Generate ORDER message from the basket 6. Verify ORDER message contains RFF+ON segment with the purchase order number 7. Run tests: prove t/db_dependent/Koha/Edifact/Order.t This completes the round-trip EDI workflow for purchase order number handling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183957&action=edit Bug 20253: (follow-up) Remove warnings from EDI when running tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183958&action=edit Bug 20253: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184000&action=edit Bug 20253: Remove warnings from EDI when running tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183953|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184001&action=edit Bug 20253: Add tests for RFF+ON segment handling and basket naming This patch adds tests for: 1. RFF+ON (Purchase Order Number) segment parsing in EDIFACT messages 2. Vendor configuration for basket naming preferences 3. Basket naming logic in QUOTE processing Test coverage includes: - Message-level RFF+ON segment extraction - Validation that RFF+ON processing stops at LIN segments - Multiple RFF segment handling - Database field storage and constraints - Basket naming configuration logic - Fallback behavior when purchase order number unavailable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184002&action=edit Bug 20253: Add po_is_basketname field to vendor_edi_accounts table This patch adds a new boolean field 'po_is_basketname' to the vendor_edi_accounts table to allow configuration of how basket names are used in EDIFACT. Changes: - Added atomicupdate for existing installations - Updated kohastructure.sql for new installations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183958|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184003&action=edit Bug 20253: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184004&action=edit Bug 20253: Optionally use buyer's purchase order number from EDIFACT quote as basket name This enhancement allows libraries to configure vendors to use the buyer's purchase order number (from RFF+ON segments) as the basket name instead of the EDIFACT filename, improving searchability and reference tracking. Backend Changes: - Added purchase_order_number() method to Koha::Edifact::Message to extract RFF+ON segments from message-level data (before first LIN segment) - Modified process_quote() in Koha::EDI to use purchase order number for basket naming when configured, with fallback to filename Frontend Changes: - Updated admin/edi_accounts.pl to handle po_is_basketname parameter - Added "Use purhase order numbers" option to EDI accounts template Test Plan: 1. Apply patches and run database update 2. Go to Administration > Acquisitions > EDI accounts 3. Create or edit a vendor EDI account 4. Verify "Use purchase order numbers" option appears 5. Enable "Use purchase order numbers" and save 6. Process an EDIFACT quote file that contains RFF+ON segments 7. Verify the created basket name uses the purchase order number instead of filename 8. Process a quote file without RFF+ON segments 9. Verify the basket name falls back to the filename 10. Test with "Use purchase order numbers" disabled 11. Verify basket names use filenames regardless of RFF+ON presence 12. Run tests: prove t/Edifact.t t/db_dependent/Koha/EDI.t The feature is optional and backward compatible - existing behavior is unchanged unless explicitly configured. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184005&action=edit Bug 20253: (follow-up) Add duplicate purchase order number validation When processing EDI quotes with purchase order numbers, validate that the purchase order number is unique for the vendor to prevent operational confusion. The validation: - Checks for existing baskets with the same purchase order number and vendor - Includes both open and closed baskets in the uniqueness check - Logs an error with the raw RFF+ON segment and details to the edifact_errors table - Continues processing (non-blocking) to prevent data loss - Provides system log warnings for monitoring The error logging includes: - Section: Raw RFF+ON segment (e.g., "RFF+ON:orders 23/1") - Details: Clear description of the duplicate purchase order number issue This ensures administrators can identify and resolve duplicate purchase order numbers while maintaining system functionality and audit trails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184006&action=edit Bug 20253: (follow-up) Make basket name read-only when derived from EDI purchase order number When a basket is created from an EDI quote with the vendor EDI account configured to use purchase order numbers, the basket name should be protected from changes to maintain the integrity of the purchase order number reference. This patch: - Makes the basket name field read-only in the UI when the basket was created from EDI with purchase order number setting - Adds explanatory text when the field is protected - Implements server-side protection to prevent basket name changes even if the UI is bypassed - Preserves the original purchase order number derived name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184007&action=edit Bug 20253: (follow-up) Use purchase order number in BGM segment for outgoing ORDER messages When vendors are configured to use purchase order numbers for basket naming, the purchase order number should be included in outgoing ORDER messages as the document message number in the BGM segment for proper EDI workflow continuity. According to EDIFACT specifications, the purchase order number from incoming quote messages (RFF+ON segments) should be used as the document message number in the BGM segment of outgoing ORDER messages, rather than as a separate RFF+ON segment. This follow-up ensures that: 1. Purchase order numbers from incoming QUOTE messages are preserved 2. The same purchase order numbers are sent back in ORDER messages via BGM segment 3. Vendors receive the reference numbers they expect for order processing in the correct format. Implementation: - Added get_purchase_order_number() method to extract PO number from basket name when vendor is configured with 'po_is_basketname' - Modified beginning_of_message() to accept purchase order number parameter - Uses purchase order number in BGM segment when available, falls back to basketno - Added comprehensive tests for purchase order number handling in ORDER messages Test Plan: 1. Apply patches 2. Configure a vendor EDI account with "Basket name source" = "Purchase order number" 3. Process a QUOTE message containing RFF+ON segment 4. Verify basket is created with purchase order number as name 5. Generate ORDER message from the basket 6. Verify ORDER message contains purchase order number in BGM segment 7. Run tests: prove t/db_dependent/Koha/Edifact/Order.t This completes the round-trip EDI workflow for purchase order number handling according to EDIFACT standards: Quote RFF+ON → Basket Name → Order BGM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40383 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 [Bug 40383] Modernise the EDIFACT Message display modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184001|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185221&action=edit Bug 20253: Add tests for RFF+ON segment handling and basket naming This patch adds tests for: 1. RFF+ON (Purchase Order Number) segment parsing in EDIFACT messages 2. Vendor configuration for basket naming preferences 3. Basket naming logic in QUOTE processing Test coverage includes: - Message-level RFF+ON segment extraction - Validation that RFF+ON processing stops at LIN segments - Multiple RFF segment handling - Database field storage and constraints - Basket naming configuration logic - Fallback behavior when purchase order number unavailable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184002|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185222&action=edit Bug 20253: Add po_is_basketname field to vendor_edi_accounts table This patch adds a new boolean field 'po_is_basketname' to the vendor_edi_accounts table to allow configuration of how basket names are used in EDIFACT. Changes: - Added atomicupdate for existing installations - Updated kohastructure.sql for new installations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184003|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185223&action=edit Bug 20253: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184004|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185224&action=edit Bug 20253: Optionally use buyer's purchase order number from EDIFACT quote as basket name This enhancement allows libraries to configure vendors to use the buyer's purchase order number (from RFF+ON segments) as the basket name instead of the EDIFACT filename, improving searchability and reference tracking. Backend Changes: - Added purchase_order_number() method to Koha::Edifact::Message to extract RFF+ON segments from message-level data (before first LIN segment) - Modified process_quote() in Koha::EDI to use purchase order number for basket naming when configured, with fallback to filename Frontend Changes: - Updated admin/edi_accounts.pl to handle po_is_basketname parameter - Added "Use purhase order numbers" option to EDI accounts template Test Plan: 1. Apply patches and run database update 2. Go to Administration > Acquisitions > EDI accounts 3. Create or edit a vendor EDI account 4. Verify "Use purchase order numbers" option appears 5. Enable "Use purchase order numbers" and save 6. Process an EDIFACT quote file that contains RFF+ON segments 7. Verify the created basket name uses the purchase order number instead of filename 8. Process a quote file without RFF+ON segments 9. Verify the basket name falls back to the filename 10. Test with "Use purchase order numbers" disabled 11. Verify basket names use filenames regardless of RFF+ON presence 12. Run tests: prove t/Edifact.t t/db_dependent/Koha/EDI.t The feature is optional and backward compatible - existing behavior is unchanged unless explicitly configured. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184005|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185225&action=edit Bug 20253: (follow-up) Add duplicate purchase order number validation When processing EDI quotes with purchase order numbers, validate that the purchase order number is unique for the vendor to prevent operational confusion. The validation: - Checks for existing baskets with the same purchase order number and vendor - Includes both open and closed baskets in the uniqueness check - Logs an error with the raw RFF+ON segment and details to the edifact_errors table - Continues processing (non-blocking) to prevent data loss - Provides system log warnings for monitoring The error logging includes: - Section: Raw RFF+ON segment (e.g., "RFF+ON:orders 23/1") - Details: Clear description of the duplicate purchase order number issue This ensures administrators can identify and resolve duplicate purchase order numbers while maintaining system functionality and audit trails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184006|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185226&action=edit Bug 20253: (follow-up) Make basket name read-only when derived from EDI purchase order number When a basket is created from an EDI quote with the vendor EDI account configured to use purchase order numbers, the basket name should be protected from changes to maintain the integrity of the purchase order number reference. This patch: - Makes the basket name field read-only in the UI when the basket was created from EDI with purchase order number setting - Adds explanatory text when the field is protected - Implements server-side protection to prevent basket name changes even if the UI is bypassed - Preserves the original purchase order number derived name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184007|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185227&action=edit Bug 20253: (follow-up) Use purchase order number in BGM segment for outgoing ORDER messages When vendors are configured to use purchase order numbers for basket naming, the purchase order number should be included in outgoing ORDER messages as the document message number in the BGM segment for proper EDI workflow continuity. According to EDIFACT specifications, the purchase order number from incoming quote messages (RFF+ON segments) should be used as the document message number in the BGM segment of outgoing ORDER messages, rather than as a separate RFF+ON segment. This follow-up ensures that: 1. Purchase order numbers from incoming QUOTE messages are preserved 2. The same purchase order numbers are sent back in ORDER messages via BGM segment 3. Vendors receive the reference numbers they expect for order processing in the correct format. Implementation: - Added get_purchase_order_number() method to extract PO number from basket name when vendor is configured with 'po_is_basketname' - Modified beginning_of_message() to accept purchase order number parameter - Uses purchase order number in BGM segment when available, falls back to basketno - Added comprehensive tests for purchase order number handling in ORDER messages Test Plan: 1. Apply patches 2. Configure a vendor EDI account with "Basket name source" = "Purchase order number" 3. Process a QUOTE message containing RFF+ON segment 4. Verify basket is created with purchase order number as name 5. Generate ORDER message from the basket 6. Verify ORDER message contains purchase order number in BGM segment 7. Run tests: prove t/db_dependent/Koha/Edifact/Order.t This completes the round-trip EDI workflow for purchase order number handling according to EDIFACT standards: Quote RFF+ON → Basket Name → Order BGM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185228&action=edit Bug 20253: (follow-up) Block auto_orders and UI ordering for duplicate PO numbers When po_is_basketname is enabled for a vendor, duplicate purchase order numbers should prevent both automatic ordering (auto_orders) and manual UI-triggered ordering to avoid conflicts with existing baskets. This patch implements blocking functionality that: 1. Auto-orders blocking: - Tracks baskets with PO number conflicts during quote processing - Skips auto-ordering for baskets with duplicate PO numbers - Logs clear warnings about blocked baskets 2. UI basket ordering blocking: - Adds duplicate checking in create_edi_order function - Returns detailed error information when conflicts detected - Prevents EDI order creation for conflicting baskets 3. User-friendly error handling: - Updates basket.pl to handle duplicate PO number errors - Stays on basket page to display error messages - Provides clear messaging about conflicts and resolution steps 4. Template messaging: - Adds clear error message explaining duplicate PO conflicts - Shows which existing basket uses the same PO number - Guides users on next steps to resolve the issue This ensures data integrity and prevents order processing conflicts while providing clear feedback to users about duplicate PO number issues. Test plan: 1. Set up a vendor with EDI account and enable "po_is_basketname" 2. Create a basket with a specific name (e.g., "PO12345") 3. Process an EDIFACT quote that contains the same PO number: - If auto_orders is enabled: verify the new basket is created but NOT automatically ordered - Check the logs show "Auto-order blocked" message 4. For UI testing, create another basket manually with the same name 5. Try to generate EDI order via "Generate EDI order" button 6. Verify: Error message appears stating duplicate PO number conflict 7. Verify: Basket remains open (not closed) 8. Verify: Error message shows which existing basket uses the PO number 9. Test with po_is_basketname disabled: verify normal operation continues 10. Test with unique PO numbers: verify orders process normally -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 [Bug 38489] EDI should be updated to use the new FTP/SFTP Servers management page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185221|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186860&action=edit Bug 20253: Add tests for RFF+ON segment handling and basket naming This patch adds tests for: 1. RFF+ON (Purchase Order Number) segment parsing in EDIFACT messages 2. Vendor configuration for basket naming preferences 3. Basket naming logic in QUOTE processing Test coverage includes: - Message-level RFF+ON segment extraction - Validation that RFF+ON processing stops at LIN segments - Multiple RFF segment handling - Database field storage and constraints - Basket naming configuration logic - Fallback behavior when purchase order number unavailable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185222|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186861&action=edit Bug 20253: Add po_is_basketname field to vendor_edi_accounts table This patch adds a new boolean field 'po_is_basketname' to the vendor_edi_accounts table to allow configuration of how basket names are used in EDIFACT. Changes: - Added atomicupdate for existing installations - Updated kohastructure.sql for new installations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185223|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186862&action=edit Bug 20253: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185224|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186863&action=edit Bug 20253: Optionally use buyer's purchase order number from EDIFACT quote as basket name This enhancement allows libraries to configure vendors to use the buyer's purchase order number (from RFF+ON segments) as the basket name instead of the EDIFACT filename, improving searchability and reference tracking. Backend Changes: - Added purchase_order_number() method to Koha::Edifact::Message to extract RFF+ON segments from message-level data (before first LIN segment) - Modified process_quote() in Koha::EDI to use purchase order number for basket naming when configured, with fallback to filename Frontend Changes: - Updated admin/edi_accounts.pl to handle po_is_basketname parameter - Added "Use purhase order numbers" option to EDI accounts template Test Plan: 1. Apply patches and run database update 2. Go to Administration > Acquisitions > EDI accounts 3. Create or edit a vendor EDI account 4. Verify "Use purchase order numbers" option appears 5. Enable "Use purchase order numbers" and save 6. Process an EDIFACT quote file that contains RFF+ON segments 7. Verify the created basket name uses the purchase order number instead of filename 8. Process a quote file without RFF+ON segments 9. Verify the basket name falls back to the filename 10. Test with "Use purchase order numbers" disabled 11. Verify basket names use filenames regardless of RFF+ON presence 12. Run tests: prove t/Edifact.t t/db_dependent/Koha/EDI.t The feature is optional and backward compatible - existing behavior is unchanged unless explicitly configured. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185225|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186864&action=edit Bug 20253: (follow-up) Add duplicate purchase order number validation When processing EDI quotes with purchase order numbers, validate that the purchase order number is unique for the vendor to prevent operational confusion. The validation: - Checks for existing baskets with the same purchase order number and vendor - Includes both open and closed baskets in the uniqueness check - Logs an error with the raw RFF+ON segment and details to the edifact_errors table - Continues processing (non-blocking) to prevent data loss - Provides system log warnings for monitoring The error logging includes: - Section: Raw RFF+ON segment (e.g., "RFF+ON:orders 23/1") - Details: Clear description of the duplicate purchase order number issue This ensures administrators can identify and resolve duplicate purchase order numbers while maintaining system functionality and audit trails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185226|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186865&action=edit Bug 20253: (follow-up) Make basket name read-only when derived from EDI purchase order number When a basket is created from an EDI quote with the vendor EDI account configured to use purchase order numbers, the basket name should be protected from changes to maintain the integrity of the purchase order number reference. This patch: - Makes the basket name field read-only in the UI when the basket was created from EDI with purchase order number setting - Adds explanatory text when the field is protected - Implements server-side protection to prevent basket name changes even if the UI is bypassed - Preserves the original purchase order number derived name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185227|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186866&action=edit Bug 20253: (follow-up) Use purchase order number in BGM segment for outgoing ORDER messages When vendors are configured to use purchase order numbers for basket naming, the purchase order number should be included in outgoing ORDER messages as the document message number in the BGM segment for proper EDI workflow continuity. According to EDIFACT specifications, the purchase order number from incoming quote messages (RFF+ON segments) should be used as the document message number in the BGM segment of outgoing ORDER messages, rather than as a separate RFF+ON segment. This follow-up ensures that: 1. Purchase order numbers from incoming QUOTE messages are preserved 2. The same purchase order numbers are sent back in ORDER messages via BGM segment 3. Vendors receive the reference numbers they expect for order processing in the correct format. Implementation: - Added get_purchase_order_number() method to extract PO number from basket name when vendor is configured with 'po_is_basketname' - Modified beginning_of_message() to accept purchase order number parameter - Uses purchase order number in BGM segment when available, falls back to basketno - Added comprehensive tests for purchase order number handling in ORDER messages Test Plan: 1. Apply patches 2. Configure a vendor EDI account with "Basket name source" = "Purchase order number" 3. Process a QUOTE message containing RFF+ON segment 4. Verify basket is created with purchase order number as name 5. Generate ORDER message from the basket 6. Verify ORDER message contains purchase order number in BGM segment 7. Run tests: prove t/db_dependent/Koha/Edifact/Order.t This completes the round-trip EDI workflow for purchase order number handling according to EDIFACT standards: Quote RFF+ON → Basket Name → Order BGM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185228|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186867&action=edit Bug 20253: (follow-up) Block auto_orders and UI ordering for duplicate PO numbers When po_is_basketname is enabled for a vendor, duplicate purchase order numbers should prevent both automatic ordering (auto_orders) and manual UI-triggered ordering to avoid conflicts with existing baskets. This patch implements blocking functionality that: 1. Auto-orders blocking: - Tracks baskets with PO number conflicts during quote processing - Skips auto-ordering for baskets with duplicate PO numbers - Logs clear warnings about blocked baskets 2. UI basket ordering blocking: - Adds duplicate checking in create_edi_order function - Returns detailed error information when conflicts detected - Prevents EDI order creation for conflicting baskets 3. User-friendly error handling: - Updates basket.pl to handle duplicate PO number errors - Stays on basket page to display error messages - Provides clear messaging about conflicts and resolution steps 4. Template messaging: - Adds clear error message explaining duplicate PO conflicts - Shows which existing basket uses the same PO number - Guides users on next steps to resolve the issue This ensures data integrity and prevents order processing conflicts while providing clear feedback to users about duplicate PO number issues. Test plan: 1. Set up a vendor with EDI account and enable "po_is_basketname" 2. Create a basket with a specific name (e.g., "PO12345") 3. Process an EDIFACT quote that contains the same PO number: - If auto_orders is enabled: verify the new basket is created but NOT automatically ordered - Check the logs show "Auto-order blocked" message 4. For UI testing, create another basket manually with the same name 5. Try to generate EDI order via "Generate EDI order" button 6. Verify: Error message appears stating duplicate PO number conflict 7. Verify: Basket remains open (not closed) 8. Verify: Error message shows which existing basket uses the PO number 9. Test with po_is_basketname disabled: verify normal operation continues 10. Test with unique PO numbers: verify orders process normally -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186860|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186868&action=edit Bug 20253: Add tests for RFF+ON segment handling and basket naming This patch adds tests for: 1. RFF+ON (Purchase Order Number) segment parsing in EDIFACT messages 2. Vendor configuration for basket naming preferences 3. Basket naming logic in QUOTE processing Test coverage includes: - Message-level RFF+ON segment extraction - Validation that RFF+ON processing stops at LIN segments - Multiple RFF segment handling - Database field storage and constraints - Basket naming configuration logic - Fallback behavior when purchase order number unavailable Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186861|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186869&action=edit Bug 20253: Add po_is_basketname field to vendor_edi_accounts table This patch adds a new boolean field 'po_is_basketname' to the vendor_edi_accounts table to allow configuration of how basket names are used in EDIFACT. Changes: - Added atomicupdate for existing installations - Updated kohastructure.sql for new installations Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186862|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186870&action=edit Bug 20253: DBIC Schema Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186863|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186871&action=edit Bug 20253: Optionally use buyer's purchase order number from EDIFACT quote as basket name This enhancement allows libraries to configure vendors to use the buyer's purchase order number (from RFF+ON segments) as the basket name instead of the EDIFACT filename, improving searchability and reference tracking. Backend Changes: - Added purchase_order_number() method to Koha::Edifact::Message to extract RFF+ON segments from message-level data (before first LIN segment) - Modified process_quote() in Koha::EDI to use purchase order number for basket naming when configured, with fallback to filename Frontend Changes: - Updated admin/edi_accounts.pl to handle po_is_basketname parameter - Added "Use purhase order numbers" option to EDI accounts template Test Plan: 1. Apply patches and run database update 2. Go to Administration > Acquisitions > EDI accounts 3. Create or edit a vendor EDI account 4. Verify "Use purchase order numbers" option appears 5. Enable "Use purchase order numbers" and save 6. Process an EDIFACT quote file that contains RFF+ON segments 7. Verify the created basket name uses the purchase order number instead of filename 8. Process a quote file without RFF+ON segments 9. Verify the basket name falls back to the filename 10. Test with "Use purchase order numbers" disabled 11. Verify basket names use filenames regardless of RFF+ON presence 12. Run tests: prove t/Edifact.t t/db_dependent/Koha/EDI.t The feature is optional and backward compatible - existing behavior is unchanged unless explicitly configured. Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186864|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186872&action=edit Bug 20253: (follow-up) Add duplicate purchase order number validation When processing EDI quotes with purchase order numbers, validate that the purchase order number is unique for the vendor to prevent operational confusion. The validation: - Checks for existing baskets with the same purchase order number and vendor - Includes both open and closed baskets in the uniqueness check - Logs an error with the raw RFF+ON segment and details to the edifact_errors table - Continues processing (non-blocking) to prevent data loss - Provides system log warnings for monitoring The error logging includes: - Section: Raw RFF+ON segment (e.g., "RFF+ON:orders 23/1") - Details: Clear description of the duplicate purchase order number issue This ensures administrators can identify and resolve duplicate purchase order numbers while maintaining system functionality and audit trails. Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186865|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186873&action=edit Bug 20253: (follow-up) Make basket name read-only when derived from EDI purchase order number When a basket is created from an EDI quote with the vendor EDI account configured to use purchase order numbers, the basket name should be protected from changes to maintain the integrity of the purchase order number reference. This patch: - Makes the basket name field read-only in the UI when the basket was created from EDI with purchase order number setting - Adds explanatory text when the field is protected - Implements server-side protection to prevent basket name changes even if the UI is bypassed - Preserves the original purchase order number derived name Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186866|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186874&action=edit Bug 20253: (follow-up) Use purchase order number in BGM segment for outgoing ORDER messages When vendors are configured to use purchase order numbers for basket naming, the purchase order number should be included in outgoing ORDER messages as the document message number in the BGM segment for proper EDI workflow continuity. According to EDIFACT specifications, the purchase order number from incoming quote messages (RFF+ON segments) should be used as the document message number in the BGM segment of outgoing ORDER messages, rather than as a separate RFF+ON segment. This follow-up ensures that: 1. Purchase order numbers from incoming QUOTE messages are preserved 2. The same purchase order numbers are sent back in ORDER messages via BGM segment 3. Vendors receive the reference numbers they expect for order processing in the correct format. Implementation: - Added get_purchase_order_number() method to extract PO number from basket name when vendor is configured with 'po_is_basketname' - Modified beginning_of_message() to accept purchase order number parameter - Uses purchase order number in BGM segment when available, falls back to basketno - Added comprehensive tests for purchase order number handling in ORDER messages Test Plan: 1. Apply patches 2. Configure a vendor EDI account with "Basket name source" = "Purchase order number" 3. Process a QUOTE message containing RFF+ON segment 4. Verify basket is created with purchase order number as name 5. Generate ORDER message from the basket 6. Verify ORDER message contains purchase order number in BGM segment 7. Run tests: prove t/db_dependent/Koha/Edifact/Order.t This completes the round-trip EDI workflow for purchase order number handling according to EDIFACT standards: Quote RFF+ON → Basket Name → Order BGM Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186867|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186875&action=edit Bug 20253: (follow-up) Block auto_orders and UI ordering for duplicate PO numbers When po_is_basketname is enabled for a vendor, duplicate purchase order numbers should prevent both automatic ordering (auto_orders) and manual UI-triggered ordering to avoid conflicts with existing baskets. This patch implements blocking functionality that: 1. Auto-orders blocking: - Tracks baskets with PO number conflicts during quote processing - Skips auto-ordering for baskets with duplicate PO numbers - Logs clear warnings about blocked baskets 2. UI basket ordering blocking: - Adds duplicate checking in create_edi_order function - Returns detailed error information when conflicts detected - Prevents EDI order creation for conflicting baskets 3. User-friendly error handling: - Updates basket.pl to handle duplicate PO number errors - Stays on basket page to display error messages - Provides clear messaging about conflicts and resolution steps 4. Template messaging: - Adds clear error message explaining duplicate PO conflicts - Shows which existing basket uses the same PO number - Guides users on next steps to resolve the issue This ensures data integrity and prevents order processing conflicts while providing clear feedback to users about duplicate PO number issues. Test plan: 1. Set up a vendor with EDI account and enable "po_is_basketname" 2. Create a basket with a specific name (e.g., "PO12345") 3. Process an EDIFACT quote that contains the same PO number: - If auto_orders is enabled: verify the new basket is created but NOT automatically ordered - Check the logs show "Auto-order blocked" message 4. For UI testing, create another basket manually with the same name 5. Try to generate EDI order via "Generate EDI order" button 6. Verify: Error message appears stating duplicate PO number conflict 7. Verify: Basket remains open (not closed) 8. Verify: Error message shows which existing basket uses the PO number 9. Test with po_is_basketname disabled: verify normal operation continues 10. Test with unique PO numbers: verify orders process normally Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #45 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Hannah has this running in production at Westminster and it's been rigorously tested there in production (I've never seen so much EDI traffic!) Hannah: Yes, it's working! It works really well. Thanks for doing this and add me in for signoff please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186868|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187165&action=edit Bug 20253: Add tests for RFF+ON segment handling and basket naming This patch adds tests for: 1. RFF+ON (Purchase Order Number) segment parsing in EDIFACT messages 2. Vendor configuration for basket naming preferences 3. Basket naming logic in QUOTE processing Test coverage includes: - Message-level RFF+ON segment extraction - Validation that RFF+ON processing stops at LIN segments - Multiple RFF segment handling - Database field storage and constraints - Basket naming configuration logic - Fallback behavior when purchase order number unavailable Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186869|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187166&action=edit Bug 20253: Add po_is_basketname field to vendor_edi_accounts table This patch adds a new boolean field 'po_is_basketname' to the vendor_edi_accounts table to allow configuration of how basket names are used in EDIFACT. Changes: - Added atomicupdate for existing installations - Updated kohastructure.sql for new installations Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186870|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187167&action=edit Bug 20253: DBIC Schema Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186871|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187168&action=edit Bug 20253: Optionally use buyer's purchase order number from EDIFACT quote as basket name This enhancement allows libraries to configure vendors to use the buyer's purchase order number (from RFF+ON segments) as the basket name instead of the EDIFACT filename, improving searchability and reference tracking. Backend Changes: - Added purchase_order_number() method to Koha::Edifact::Message to extract RFF+ON segments from message-level data (before first LIN segment) - Modified process_quote() in Koha::EDI to use purchase order number for basket naming when configured, with fallback to filename Frontend Changes: - Updated admin/edi_accounts.pl to handle po_is_basketname parameter - Added "Use purhase order numbers" option to EDI accounts template Test Plan: 1. Apply patches and run database update 2. Go to Administration > Acquisitions > EDI accounts 3. Create or edit a vendor EDI account 4. Verify "Use purchase order numbers" option appears 5. Enable "Use purchase order numbers" and save 6. Process an EDIFACT quote file that contains RFF+ON segments 7. Verify the created basket name uses the purchase order number instead of filename 8. Process a quote file without RFF+ON segments 9. Verify the basket name falls back to the filename 10. Test with "Use purchase order numbers" disabled 11. Verify basket names use filenames regardless of RFF+ON presence 12. Run tests: prove t/Edifact.t t/db_dependent/Koha/EDI.t The feature is optional and backward compatible - existing behavior is unchanged unless explicitly configured. Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186872|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187169&action=edit Bug 20253: (follow-up) Add duplicate purchase order number validation When processing EDI quotes with purchase order numbers, validate that the purchase order number is unique for the vendor to prevent operational confusion. The validation: - Checks for existing baskets with the same purchase order number and vendor - Includes both open and closed baskets in the uniqueness check - Logs an error with the raw RFF+ON segment and details to the edifact_errors table - Continues processing (non-blocking) to prevent data loss - Provides system log warnings for monitoring The error logging includes: - Section: Raw RFF+ON segment (e.g., "RFF+ON:orders 23/1") - Details: Clear description of the duplicate purchase order number issue This ensures administrators can identify and resolve duplicate purchase order numbers while maintaining system functionality and audit trails. Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186873|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187170&action=edit Bug 20253: (follow-up) Make basket name read-only when derived from EDI purchase order number When a basket is created from an EDI quote with the vendor EDI account configured to use purchase order numbers, the basket name should be protected from changes to maintain the integrity of the purchase order number reference. This patch: - Makes the basket name field read-only in the UI when the basket was created from EDI with purchase order number setting - Adds explanatory text when the field is protected - Implements server-side protection to prevent basket name changes even if the UI is bypassed - Preserves the original purchase order number derived name Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186874|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187171&action=edit Bug 20253: (follow-up) Use purchase order number in BGM segment for outgoing ORDER messages When vendors are configured to use purchase order numbers for basket naming, the purchase order number should be included in outgoing ORDER messages as the document message number in the BGM segment for proper EDI workflow continuity. According to EDIFACT specifications, the purchase order number from incoming quote messages (RFF+ON segments) should be used as the document message number in the BGM segment of outgoing ORDER messages, rather than as a separate RFF+ON segment. This follow-up ensures that: 1. Purchase order numbers from incoming QUOTE messages are preserved 2. The same purchase order numbers are sent back in ORDER messages via BGM segment 3. Vendors receive the reference numbers they expect for order processing in the correct format. Implementation: - Added get_purchase_order_number() method to extract PO number from basket name when vendor is configured with 'po_is_basketname' - Modified beginning_of_message() to accept purchase order number parameter - Uses purchase order number in BGM segment when available, falls back to basketno - Added comprehensive tests for purchase order number handling in ORDER messages Test Plan: 1. Apply patches 2. Configure a vendor EDI account with "Basket name source" = "Purchase order number" 3. Process a QUOTE message containing RFF+ON segment 4. Verify basket is created with purchase order number as name 5. Generate ORDER message from the basket 6. Verify ORDER message contains purchase order number in BGM segment 7. Run tests: prove t/db_dependent/Koha/Edifact/Order.t This completes the round-trip EDI workflow for purchase order number handling according to EDIFACT standards: Quote RFF+ON → Basket Name → Order BGM Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186875|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187172&action=edit Bug 20253: (follow-up) Block auto_orders and UI ordering for duplicate PO numbers When po_is_basketname is enabled for a vendor, duplicate purchase order numbers should prevent both automatic ordering (auto_orders) and manual UI-triggered ordering to avoid conflicts with existing baskets. This patch implements blocking functionality that: 1. Auto-orders blocking: - Tracks baskets with PO number conflicts during quote processing - Skips auto-ordering for baskets with duplicate PO numbers - Logs clear warnings about blocked baskets 2. UI basket ordering blocking: - Adds duplicate checking in create_edi_order function - Returns detailed error information when conflicts detected - Prevents EDI order creation for conflicting baskets 3. User-friendly error handling: - Updates basket.pl to handle duplicate PO number errors - Stays on basket page to display error messages - Provides clear messaging about conflicts and resolution steps 4. Template messaging: - Adds clear error message explaining duplicate PO conflicts - Shows which existing basket uses the same PO number - Guides users on next steps to resolve the issue This ensures data integrity and prevents order processing conflicts while providing clear feedback to users about duplicate PO number issues. Test plan: 1. Set up a vendor with EDI account and enable "po_is_basketname" 2. Create a basket with a specific name (e.g., "PO12345") 3. Process an EDIFACT quote that contains the same PO number: - If auto_orders is enabled: verify the new basket is created but NOT automatically ordered - Check the logs show "Auto-order blocked" message 4. For UI testing, create another basket manually with the same name 5. Try to generate EDI order via "Generate EDI order" button 6. Verify: Error message appears stating duplicate PO number conflict 7. Verify: Basket remains open (not closed) 8. Verify: Error message shows which existing basket uses the PO number 9. Test with po_is_basketname disabled: verify normal operation continues 10. Test with unique PO numbers: verify orders process normally Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #54 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187173&action=edit Bug 20253: (follow-up) Update tests for Bug 38489 rebase With the move to Koha::File::Transports we need to update the tests introduced in this patchset to match the others by generating a 'local' transport and using that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187165|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187874&action=edit Bug 20253: Add tests for RFF+ON segment handling and basket naming This patch adds tests for: 1. RFF+ON (Purchase Order Number) segment parsing in EDIFACT messages 2. Vendor configuration for basket naming preferences 3. Basket naming logic in QUOTE processing Test coverage includes: - Message-level RFF+ON segment extraction - Validation that RFF+ON processing stops at LIN segments - Multiple RFF segment handling - Database field storage and constraints - Basket naming configuration logic - Fallback behavior when purchase order number unavailable Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187166|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187875&action=edit Bug 20253: Add po_is_basketname field to vendor_edi_accounts table This patch adds a new boolean field 'po_is_basketname' to the vendor_edi_accounts table to allow configuration of how basket names are used in EDIFACT. Changes: - Added atomicupdate for existing installations - Updated kohastructure.sql for new installations Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187167|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187876&action=edit Bug 20253: DBIC Schema Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187168|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187877&action=edit Bug 20253: Optionally use buyer's purchase order number from EDIFACT quote as basket name This enhancement allows libraries to configure vendors to use the buyer's purchase order number (from RFF+ON segments) as the basket name instead of the EDIFACT filename, improving searchability and reference tracking. Backend Changes: - Added purchase_order_number() method to Koha::Edifact::Message to extract RFF+ON segments from message-level data (before first LIN segment) - Modified process_quote() in Koha::EDI to use purchase order number for basket naming when configured, with fallback to filename Frontend Changes: - Updated admin/edi_accounts.pl to handle po_is_basketname parameter - Added "Use purhase order numbers" option to EDI accounts template Test Plan: 1. Apply patches and run database update 2. Go to Administration > Acquisitions > EDI accounts 3. Create or edit a vendor EDI account 4. Verify "Use purchase order numbers" option appears 5. Enable "Use purchase order numbers" and save 6. Process an EDIFACT quote file that contains RFF+ON segments 7. Verify the created basket name uses the purchase order number instead of filename 8. Process a quote file without RFF+ON segments 9. Verify the basket name falls back to the filename 10. Test with "Use purchase order numbers" disabled 11. Verify basket names use filenames regardless of RFF+ON presence 12. Run tests: prove t/Edifact.t t/db_dependent/Koha/EDI.t The feature is optional and backward compatible - existing behavior is unchanged unless explicitly configured. Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187169|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187878&action=edit Bug 20253: (follow-up) Add duplicate purchase order number validation When processing EDI quotes with purchase order numbers, validate that the purchase order number is unique for the vendor to prevent operational confusion. The validation: - Checks for existing baskets with the same purchase order number and vendor - Includes both open and closed baskets in the uniqueness check - Logs an error with the raw RFF+ON segment and details to the edifact_errors table - Continues processing (non-blocking) to prevent data loss - Provides system log warnings for monitoring The error logging includes: - Section: Raw RFF+ON segment (e.g., "RFF+ON:orders 23/1") - Details: Clear description of the duplicate purchase order number issue This ensures administrators can identify and resolve duplicate purchase order numbers while maintaining system functionality and audit trails. Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187170|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187879&action=edit Bug 20253: (follow-up) Make basket name read-only when derived from EDI purchase order number When a basket is created from an EDI quote with the vendor EDI account configured to use purchase order numbers, the basket name should be protected from changes to maintain the integrity of the purchase order number reference. This patch: - Makes the basket name field read-only in the UI when the basket was created from EDI with purchase order number setting - Adds explanatory text when the field is protected - Implements server-side protection to prevent basket name changes even if the UI is bypassed - Preserves the original purchase order number derived name Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187171|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187880&action=edit Bug 20253: (follow-up) Use purchase order number in BGM segment for outgoing ORDER messages When vendors are configured to use purchase order numbers for basket naming, the purchase order number should be included in outgoing ORDER messages as the document message number in the BGM segment for proper EDI workflow continuity. According to EDIFACT specifications, the purchase order number from incoming quote messages (RFF+ON segments) should be used as the document message number in the BGM segment of outgoing ORDER messages, rather than as a separate RFF+ON segment. This follow-up ensures that: 1. Purchase order numbers from incoming QUOTE messages are preserved 2. The same purchase order numbers are sent back in ORDER messages via BGM segment 3. Vendors receive the reference numbers they expect for order processing in the correct format. Implementation: - Added get_purchase_order_number() method to extract PO number from basket name when vendor is configured with 'po_is_basketname' - Modified beginning_of_message() to accept purchase order number parameter - Uses purchase order number in BGM segment when available, falls back to basketno - Added comprehensive tests for purchase order number handling in ORDER messages Test Plan: 1. Apply patches 2. Configure a vendor EDI account with "Basket name source" = "Purchase order number" 3. Process a QUOTE message containing RFF+ON segment 4. Verify basket is created with purchase order number as name 5. Generate ORDER message from the basket 6. Verify ORDER message contains purchase order number in BGM segment 7. Run tests: prove t/db_dependent/Koha/Edifact/Order.t This completes the round-trip EDI workflow for purchase order number handling according to EDIFACT standards: Quote RFF+ON → Basket Name → Order BGM Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187172|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187881&action=edit Bug 20253: (follow-up) Block auto_orders and UI ordering for duplicate PO numbers When po_is_basketname is enabled for a vendor, duplicate purchase order numbers should prevent both automatic ordering (auto_orders) and manual UI-triggered ordering to avoid conflicts with existing baskets. This patch implements blocking functionality that: 1. Auto-orders blocking: - Tracks baskets with PO number conflicts during quote processing - Skips auto-ordering for baskets with duplicate PO numbers - Logs clear warnings about blocked baskets 2. UI basket ordering blocking: - Adds duplicate checking in create_edi_order function - Returns detailed error information when conflicts detected - Prevents EDI order creation for conflicting baskets 3. User-friendly error handling: - Updates basket.pl to handle duplicate PO number errors - Stays on basket page to display error messages - Provides clear messaging about conflicts and resolution steps 4. Template messaging: - Adds clear error message explaining duplicate PO conflicts - Shows which existing basket uses the same PO number - Guides users on next steps to resolve the issue This ensures data integrity and prevents order processing conflicts while providing clear feedback to users about duplicate PO number issues. Test plan: 1. Set up a vendor with EDI account and enable "po_is_basketname" 2. Create a basket with a specific name (e.g., "PO12345") 3. Process an EDIFACT quote that contains the same PO number: - If auto_orders is enabled: verify the new basket is created but NOT automatically ordered - Check the logs show "Auto-order blocked" message 4. For UI testing, create another basket manually with the same name 5. Try to generate EDI order via "Generate EDI order" button 6. Verify: Error message appears stating duplicate PO number conflict 7. Verify: Basket remains open (not closed) 8. Verify: Error message shows which existing basket uses the PO number 9. Test with po_is_basketname disabled: verify normal operation continues 10. Test with unique PO numbers: verify orders process normally Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187173|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187882&action=edit Bug 20253: (follow-up) Update tests for Bug 38489 rebase With the move to Koha::File::Transports we need to update the tests introduced in this patchset to match the others by generating a 'local' transport and using that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #64 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187883&action=edit Bug 20253: (follow-up) Fix undefined variable $b and test plan count In bug 40587 we renamed a variable from $b to $basketno. After rebasing, the auto-orders blocking code had a bug where it referenced an undefined variable $b instead of $basketno when checking for PO number conflicts. This caused warnings: "Use of uninitialized value $Koha::EDI::b in exists" This patch: - Renames $b to $basketno throughout the conflict checking code - Updates test plan from 7 to 8 to match actual subtest count Test plan: 1. Run prove t/db_dependent/Koha/EDI.t 2. Verify all tests pass without warnings 3. Confirm auto-orders blocking works correctly for duplicate PO numbers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187876|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #65 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188423&action=edit Bug 20253: Add tests for RFF+ON segment handling and basket naming This patch adds tests for: 1. RFF+ON (Purchase Order Number) segment parsing in EDIFACT messages 2. Vendor configuration for basket naming preferences 3. Basket naming logic in QUOTE processing Test coverage includes: - Message-level RFF+ON segment extraction - Validation that RFF+ON processing stops at LIN segments - Multiple RFF segment handling - Database field storage and constraints - Basket naming configuration logic - Fallback behavior when purchase order number unavailable Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #66 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188424&action=edit Bug 20253: Add po_is_basketname field to vendor_edi_accounts table This patch adds a new boolean field 'po_is_basketname' to the vendor_edi_accounts table to allow configuration of how basket names are used in EDIFACT. Changes: - Added atomicupdate for existing installations - Updated kohastructure.sql for new installations Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #67 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188425&action=edit Bug 20253: Optionally use buyer's purchase order number from EDIFACT quote as basket name This enhancement allows libraries to configure vendors to use the buyer's purchase order number (from RFF+ON segments) as the basket name instead of the EDIFACT filename, improving searchability and reference tracking. Backend Changes: - Added purchase_order_number() method to Koha::Edifact::Message to extract RFF+ON segments from message-level data (before first LIN segment) - Modified process_quote() in Koha::EDI to use purchase order number for basket naming when configured, with fallback to filename Frontend Changes: - Updated admin/edi_accounts.pl to handle po_is_basketname parameter - Added "Use purhase order numbers" option to EDI accounts template Test Plan: 1. Apply patches and run database update 2. Go to Administration > Acquisitions > EDI accounts 3. Create or edit a vendor EDI account 4. Verify "Use purchase order numbers" option appears 5. Enable "Use purchase order numbers" and save 6. Process an EDIFACT quote file that contains RFF+ON segments 7. Verify the created basket name uses the purchase order number instead of filename 8. Process a quote file without RFF+ON segments 9. Verify the basket name falls back to the filename 10. Test with "Use purchase order numbers" disabled 11. Verify basket names use filenames regardless of RFF+ON presence 12. Run tests: prove t/Edifact.t t/db_dependent/Koha/EDI.t The feature is optional and backward compatible - existing behavior is unchanged unless explicitly configured. Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #68 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188426&action=edit Bug 20253: (follow-up) Add duplicate purchase order number validation When processing EDI quotes with purchase order numbers, validate that the purchase order number is unique for the vendor to prevent operational confusion. The validation: - Checks for existing baskets with the same purchase order number and vendor - Includes both open and closed baskets in the uniqueness check - Logs an error with the raw RFF+ON segment and details to the edifact_errors table - Continues processing (non-blocking) to prevent data loss - Provides system log warnings for monitoring The error logging includes: - Section: Raw RFF+ON segment (e.g., "RFF+ON:orders 23/1") - Details: Clear description of the duplicate purchase order number issue This ensures administrators can identify and resolve duplicate purchase order numbers while maintaining system functionality and audit trails. Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #69 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188427&action=edit Bug 20253: (follow-up) Make basket name read-only when derived from EDI purchase order number When a basket is created from an EDI quote with the vendor EDI account configured to use purchase order numbers, the basket name should be protected from changes to maintain the integrity of the purchase order number reference. This patch: - Makes the basket name field read-only in the UI when the basket was created from EDI with purchase order number setting - Adds explanatory text when the field is protected - Implements server-side protection to prevent basket name changes even if the UI is bypassed - Preserves the original purchase order number derived name Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #70 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188428&action=edit Bug 20253: (follow-up) Use purchase order number in BGM segment for outgoing ORDER messages When vendors are configured to use purchase order numbers for basket naming, the purchase order number should be included in outgoing ORDER messages as the document message number in the BGM segment for proper EDI workflow continuity. According to EDIFACT specifications, the purchase order number from incoming quote messages (RFF+ON segments) should be used as the document message number in the BGM segment of outgoing ORDER messages, rather than as a separate RFF+ON segment. This follow-up ensures that: 1. Purchase order numbers from incoming QUOTE messages are preserved 2. The same purchase order numbers are sent back in ORDER messages via BGM segment 3. Vendors receive the reference numbers they expect for order processing in the correct format. Implementation: - Added get_purchase_order_number() method to extract PO number from basket name when vendor is configured with 'po_is_basketname' - Modified beginning_of_message() to accept purchase order number parameter - Uses purchase order number in BGM segment when available, falls back to basketno - Added comprehensive tests for purchase order number handling in ORDER messages Test Plan: 1. Apply patches 2. Configure a vendor EDI account with "Basket name source" = "Purchase order number" 3. Process a QUOTE message containing RFF+ON segment 4. Verify basket is created with purchase order number as name 5. Generate ORDER message from the basket 6. Verify ORDER message contains purchase order number in BGM segment 7. Run tests: prove t/db_dependent/Koha/Edifact/Order.t This completes the round-trip EDI workflow for purchase order number handling according to EDIFACT standards: Quote RFF+ON â Basket Name â Order BGM Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #71 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188429&action=edit Bug 20253: (follow-up) Block auto_orders and UI ordering for duplicate PO numbers When po_is_basketname is enabled for a vendor, duplicate purchase order numbers should prevent both automatic ordering (auto_orders) and manual UI-triggered ordering to avoid conflicts with existing baskets. This patch implements blocking functionality that: 1. Auto-orders blocking: - Tracks baskets with PO number conflicts during quote processing - Skips auto-ordering for baskets with duplicate PO numbers - Logs clear warnings about blocked baskets 2. UI basket ordering blocking: - Adds duplicate checking in create_edi_order function - Returns detailed error information when conflicts detected - Prevents EDI order creation for conflicting baskets 3. User-friendly error handling: - Updates basket.pl to handle duplicate PO number errors - Stays on basket page to display error messages - Provides clear messaging about conflicts and resolution steps 4. Template messaging: - Adds clear error message explaining duplicate PO conflicts - Shows which existing basket uses the same PO number - Guides users on next steps to resolve the issue This ensures data integrity and prevents order processing conflicts while providing clear feedback to users about duplicate PO number issues. Test plan: 1. Set up a vendor with EDI account and enable "po_is_basketname" 2. Create a basket with a specific name (e.g., "PO12345") 3. Process an EDIFACT quote that contains the same PO number: - If auto_orders is enabled: verify the new basket is created but NOT automatically ordered - Check the logs show "Auto-order blocked" message 4. For UI testing, create another basket manually with the same name 5. Try to generate EDI order via "Generate EDI order" button 6. Verify: Error message appears stating duplicate PO number conflict 7. Verify: Basket remains open (not closed) 8. Verify: Error message shows which existing basket uses the PO number 9. Test with po_is_basketname disabled: verify normal operation continues 10. Test with unique PO numbers: verify orders process normally Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #72 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188430&action=edit Bug 20253: (follow-up) Update tests for Bug 38489 rebase With the move to Koha::File::Transports we need to update the tests introduced in this patchset to match the others by generating a 'local' transport and using that. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #73 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188431&action=edit Bug 20253: (follow-up) Fix undefined variable $b and test plan count In bug 40587 we renamed a variable from $b to $basketno. After rebasing, the auto-orders blocking code had a bug where it referenced an undefined variable $b instead of $basketno when checking for PO number conflicts. This caused warnings: "Use of uninitialized value $Koha::EDI::b in exists" This patch: - Renames $b to $basketno throughout the conflict checking code - Updates test plan from 7 to 8 to match actual subtest count Test plan: 1. Run prove t/db_dependent/Koha/EDI.t 2. Verify all tests pass without warnings 3. Confirm auto-orders blocking works correctly for duplicate PO numbers Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #74 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188432&action=edit Bug 20253: DBIC Schema [DO NOT PUSH] Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #75 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- This patch adds tests for: 1. RFF+ON (Purchase Order Number) segment parsing in EDIFACT messages 2. Vendor configuration for basket naming preferences 3. Basket naming logic in QUOTE processing Test coverage includes: - Message-level RFF+ON segment extraction - Validation that RFF+ON processing stops at LIN segments - Multiple RFF segment handling - Database field storage and constraints - Basket naming configuration logic - Fallback behavior when purchase order number unavailable Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184000|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187874|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187875|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187877|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187878|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187881|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187883|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #76 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #77 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Martin, can you have a look here: https://jenkins.koha-community.org/view/main/job/Koha_Main_MariaDB_update/29... I think there is now some mismatch of schema and DB. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #78 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189038&action=edit Bug 20253: (follow-up) Sync db_rev column order Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #79 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #80 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 --- Comment #81 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189260&action=edit Bug 20253: (follow-up) Re-add missing is_boolean flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Passed QA --- Comment #82 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Follow-up added to fix dbic is_boolean flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Keywords|additional_work_needed | --- Comment #83 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main still need release notes here :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Libraries can now configure release notes| |EDI vendor accounts to use | |the buyer's purchase order | |number from EDIFACT quote | |messages (RFF+ON segments) | |as the basket name instead | |of the EDIFACT filename, | |dramatically improving | |searchability and | |cross-referencing between | |Koha and vendor systems. | | | |**The problem:** | | | |Previously, when processing | |EDIFACT quotes, Koha would | |use the filename as the | |basket name. This created | |several challenges: | |- Different reference | |numbers in Koha vs vendor | |systems made cross-checking | |difficult | |- Baskets created from | |quotes showed generic | |filenames rather than | |meaningful purchase order | |numbers | |- Staff entered purchase | |order numbers on vendor | |websites but couldn't | |easily find corresponding | |baskets in Koha | |- Three different | |references could exist for | |the same order depending on | |whether viewing quotes, | |orders, or the vendor | |system | | | |**The solution:** | | | |EDI vendor accounts now | |have a "Use purchase order | |numbers" option that, when | |enabled: | |- Extracts the purchase | |order number from incoming | |QUOTE messages (RFF+ON | |segment) | |- Uses this number as the | |basket name in Koha | |- Includes the purchase | |order number in outgoing | |ORDER messages (BGM | |segment) according to | |EDIFACT standards | |- Maintains reference | |consistency throughout the | |complete ordering workflow | | | |**Key features:** | | | |- **Complete round-trip | |workflow**: Purchase order | |number flows from QUOTE → | |Basket Name → ORDER message | |- **Duplicate detection**: | |Validates purchase order | |numbers are unique per | |vendor, with error logging | |for conflicts | |- **Protected basket | |names**: Basket names | |derived from purchase order | |numbers are read-only to | |maintain integrity | |- **Automatic order | |blocking**: Prevents | |automatic and manual | |ordering for baskets with | |duplicate purchase order | |numbers | |- **Fallback handling**: If | |no purchase order number is | |found in the QUOTE, falls | |back to using the filename | |- **Optional feature**: | |Completely backwards | |compatible - existing | |behaviour unchanged unless | |explicitly configured | | | |**For acquisitions staff:** | | | |1. Go to Administration → | |Acquisitions → EDI accounts | |2. Edit a vendor EDI | |account | |3. Enable "Use purchase | |order numbers" | |4. Save the configuration | | | |After this: | |- Baskets created from | |EDIFACT quotes will use the | |purchase order number as | |the basket name | |- You can easily search for | |and identify baskets using | |the same reference numbers | |you use with vendors | |- The basket name field | |will be read-only (to | |preserve the purchase order | |number reference) | |- If duplicate purchase | |order numbers are detected, | |you'll receive clear error | |messages preventing | |conflicts | | | |**Technical workflow:** | | | |Quote RFF+ON segment → | |Basket Name → Order BGM | |segment | | | |This follows EDIFACT | |specifications where the | |purchase order number from | |incoming quote messages | |should be used as the | |document message number in | |the BGM segment of outgoing | |ORDER messages. | | | |**Sponsored by:** | |Westminster City Council, | |Royal Borough of Kensington | |and Chelsea, OpenFifth Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Libraries can now configure |Libraries can now configure release notes|EDI vendor accounts to use |EDI vendor accounts to use |the buyer's purchase order |the buyer's purchase order |number from EDIFACT quote |number from EDIFACT quote |messages (RFF+ON segments) |messages (RFF+ON segments) |as the basket name instead |as the basket name instead |of the EDIFACT filename, |of the EDIFACT filename, |dramatically improving |dramatically improving |searchability and |searchability and |cross-referencing between |cross-referencing between |Koha and vendor systems. |Koha and vendor systems. | | |**The problem:** |**For acquisitions staff:** | | |Previously, when processing |1. Go to Administration → |EDIFACT quotes, Koha would |Acquisitions → EDI accounts |use the filename as the |2. Edit a vendor EDI |basket name. This created |account |several challenges: |3. Enable "Use purchase |- Different reference |order numbers" |numbers in Koha vs vendor |4. Save the configuration |systems made cross-checking | |difficult |After this: |- Baskets created from |- Baskets created from |quotes showed generic |EDIFACT quotes will use the |filenames rather than |purchase order number as |meaningful purchase order |the basket name |numbers |- You can easily search for |- Staff entered purchase |and identify baskets using |order numbers on vendor |the same reference numbers |websites but couldn't |you use with vendors |easily find corresponding |- The basket name field |baskets in Koha |will be read-only (to |- Three different |preserve the purchase order |references could exist for |number reference) |the same order depending on |- If duplicate purchase |whether viewing quotes, |order numbers are detected, |orders, or the vendor |you'll receive clear error |system |messages preventing | |conflicts |**The solution:** | | |**Technical workflow:** |EDI vendor accounts now | |have a "Use purchase order |Quote RFF+ON segment → |numbers" option that, when |Basket Name → Order BGM |enabled: |segment |- Extracts the purchase | |order number from incoming |This follows EDIFACT |QUOTE messages (RFF+ON |specifications where the |segment) |purchase order number from |- Uses this number as the |incoming quote messages |basket name in Koha |should be used as the |- Includes the purchase |document message number in |order number in outgoing |the BGM segment of outgoing |ORDER messages (BGM |ORDER messages. |segment) according to | |EDIFACT standards | |- Maintains reference | |consistency throughout the | |complete ordering workflow | | | |**Key features:** | | | |- **Complete round-trip | |workflow**: Purchase order | |number flows from QUOTE → | |Basket Name → ORDER message | |- **Duplicate detection**: | |Validates purchase order | |numbers are unique per | |vendor, with error logging | |for conflicts | |- **Protected basket | |names**: Basket names | |derived from purchase order | |numbers are read-only to | |maintain integrity | |- **Automatic order | |blocking**: Prevents | |automatic and manual | |ordering for baskets with | |duplicate purchase order | |numbers | |- **Fallback handling**: If | |no purchase order number is | |found in the QUOTE, falls | |back to using the filename | |- **Optional feature**: | |Completely backwards | |compatible - existing | |behaviour unchanged unless | |explicitly configured | | | |**For acquisitions staff:** | | | |1. Go to Administration → | |Acquisitions → EDI accounts | |2. Edit a vendor EDI | |account | |3. Enable "Use purchase | |order numbers" | |4. Save the configuration | | | |After this: | |- Baskets created from | |EDIFACT quotes will use the | |purchase order number as | |the basket name | |- You can easily search for | |and identify baskets using | |the same reference numbers | |you use with vendors | |- The basket name field | |will be read-only (to | |preserve the purchase order | |number reference) | |- If duplicate purchase | |order numbers are detected, | |you'll receive clear error | |messages preventing | |conflicts | | | |**Technical workflow:** | | | |Quote RFF+ON segment → | |Basket Name → Order BGM | |segment | | | |This follows EDIFACT | |specifications where the | |purchase order number from | |incoming quote messages | |should be used as the | |document message number in | |the BGM segment of outgoing | |ORDER messages. | | | |**Sponsored by:** | |Westminster City Council, | |Royal Borough of Kensington | |and Chelsea, OpenFifth | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to main |Needs documenting --- Comment #84 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42001 [Bug 42001] Add duplicate purchase order number detection on EDI quote import -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42010 [Bug 42010] Include escaping when using PO numbers in EDI acqusitions -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org