[Bug 29797] New: Background job detail for batch delete items not listing the itemnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Bug ID: 29797 Summary: Background job detail for batch delete items not listing the itemnumbers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 28445 If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129019&action=edit Bug 29797: Fix display of itemnumbers on the background job detail view If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Test plan: 1. Check an item out 2. Use the batch delete items tool to delete the item that is checked out and another one. 3. On the confirmation view, use the dev tool of your browser to remove the "disabled" property of the disabled checkbox and select both items. 4. Submit 5. Go to the detail view of the background job and confirm that you see the itemnumber of the item that has failed to be deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129019|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 129588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129588&action=edit Bug 29797: Fix display of itemnumbers on the background job detail view If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Test plan: 1. Check an item out 2. Use the batch delete items tool to delete the item that is checked out and another one. 3. On the confirmation view, use the dev tool of your browser to remove the "disabled" property of the disabled checkbox and select both items. 4. Submit 5. Go to the detail view of the background job and confirm that you see the itemnumber of the item that has failed to be deleted Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129588|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 129589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129589&action=edit Bug 29797: Fix display of itemnumbers on the background job detail view If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Also add a space character between itemnumbers. Test plan: 1. Check an item out 2. Use the batch delete items tool to delete the item that is checked out and another one. 3. On the confirmation view, use the dev tool of your browser to remove the "disabled" property of the disabled checkbox and select both items. 4. Submit 5. Go to the detail view of the background job and confirm that you see the itemnumber of the item that has failed to be deleted Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> ---
Also add a space character between itemnumbers. I tested with 2 items impossible to delete and notices that itemnumbers do not have a separator. Very small fix so I made it will signing.
BTW : Do we even need this itemnumber list ? It is not clear for user that those are itemnumbers and not barcodes. We have a message for each item in "Detailed messages". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129589|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129599&action=edit Bug 29797: Fix display of itemnumbers on the background job detail view If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Also add a space character between itemnumbers. Test plan: 1. Check an item out 2. Use the batch delete items tool to delete the item that is checked out and another one. 3. On the confirmation view, use the dev tool of your browser to remove the "disabled" property of the disabled checkbox and select both items. 4. Submit 5. Go to the detail view of the background job and confirm that you see the itemnumber of the item that has failed to be deleted Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, works as described now. I agree, itemnumbers may not be the best thing to output.. but trying to output something more meaningful to the end-user may well result in gaps.. itemnumber is definitively going to be defined. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org