[Bug 26298] New: If MaxItemsToProcessForBatchMod is set to 1000, the max is actually 999
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Bug ID: 26298 Summary: If MaxItemsToProcessForBatchMod is set to 1000, the max is actually 999 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org So this is similar to bug 10163, but I don't think it's the same thing. I noticed that if you have 1000 in MaxItemsToProcessForBatchMod, and you try to process 1000 items, there's an error message "Too many items (1000): You are not allowed to edit more than 1000 items in a batch." The message itself is a bit confusing because 1000 is not "more than" 1000. And you're probably thinking "well, just put 999 items in your file and voilà!", but if you batch modify using the reports, the options are 10, 20, 50, 100, 200, 300, 400, 500, and 1000. If you have a lot of batches to do, the difference between 500 and 1000 is double the work. To reproduce: 1- Set MaxItemsToProcessForBatchMod to 1000 2- Go to Reports 3- Make a report for itemnumbers that will give you at least 1000 items (ex. SELECT itemnumber FROM items) 4- Save and run the report 5- In "Rows per page", choose 1000 6- Click on "Batch operations with 1000 visible records" > Batch item modification 7- Notice that the item modification form isn't there and that the message says "Too many items (1000): You are not allowed to edit more than 1000 items in a batch." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10163 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #1 from Donna <bwsdonna@gmail.com> --- While I can do a workaround by changing the syspref for MaxItemsToProcessForBatchMod to 1001, this seems a bit silly. The button in reports states "Batch with 1000 visible records" so that is what the behavior should be. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Martha Fuerst <mfuerst@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst@hmcpl.org --- Comment #2 from Martha Fuerst <mfuerst@hmcpl.org> --- Confirmed that this is also an issue when you paste a list of barcodes into the batch modification tool as opposed to getting to it from the report results. -Marti Fuerst, Huntsville-Madison County Public Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115988&action=edit Bug 26298: Don't set too_many_items_to_process if equal to limit In the code we prepare items for display if less than or equal to the pref, but we don't allow the edit if greater than or equal to the pref. The second case should be only 'greater than' To test: 1- Set MaxItemsToProcessForBatchMod to 1000 2- Go to Reports 3- Make a report for itemnumbers that will give you at least 1000 items (ex. SELECT itemnumber FROM items) 4- Save and run the report 5- In "Rows per page", choose 1000 6- Click on "Batch operations with 1000 visible records" > Batch item modification 7- Notice that the item modification form isn't there and that the message says "Too many items (1000): You are not allowed to edit more than 1000 items in a batch." 8- Apply patch 9- Restart all the things 10- Run the report again and display 1000 rows 11- Click on "Batch operations with 1000 visible records" > Batch item modification 12 - Sucess! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115988|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115994&action=edit Bug 26298: Don't set too_many_items_to_process if equal to limit In the code we prepare items for display if less than or equal to the pref, but we don't allow the edit if greater than or equal to the pref. The second case should be only 'greater than' To test: 1- Set MaxItemsToProcessForBatchMod to 1000 2- Go to Reports 3- Make a report for itemnumbers that will give you at least 1000 items (ex. SELECT itemnumber FROM items) 4- Save and run the report 5- In "Rows per page", choose 1000 6- Click on "Batch operations with 1000 visible records" > Batch item modification 7- Notice that the item modification form isn't there and that the message says "Too many items (1000): You are not allowed to edit more than 1000 items in a batch." 8- Apply patch 9- Restart all the things 10- Run the report again and display 1000 rows 11- Click on "Batch operations with 1000 visible records" > Batch item modification 12 - Sucess! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115994|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 116018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116018&action=edit Bug 26298: Don't set too_many_items_to_process if equal to limit In the code we prepare items for display if less than or equal to the pref, but we don't allow the edit if greater than or equal to the pref. The second case should be only 'greater than' To test: 1- Set MaxItemsToProcessForBatchMod to 1000 2- Go to Reports 3- Make a report for itemnumbers that will give you at least 1000 items (ex. SELECT itemnumber FROM items) 4- Save and run the report 5- In "Rows per page", choose 1000 6- Click on "Batch operations with 1000 visible records" > Batch item modification 7- Notice that the item modification form isn't there and that the message says "Too many items (1000): You are not allowed to edit more than 1000 items in a batch." 8- Apply patch 9- Restart all the things 10- Run the report again and display 1000 rows 11- Click on "Batch operations with 1000 visible records" > Batch item modification 12 - Sucess! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in| |19.11.15 CC| |victor@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org