[Bug 13757] New: Make patron attributes editable in the opac if set to be visible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Bug ID: 13757 Summary: Make patron attributes editable in the opac if set to be visible Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: david.roberts@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Following on from Bug 12718 where Patron Extended Attributes were made visible in the My Details page of the OPAC, it would be useful if these could be editable by the patron, instead of just viewable. This should only apply to any attributes that are configured to display in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- This would be very useful, e.g. for managing newsletters. I think we should have two settings in /cgi-bin/koha/admin/patron-attr-types.pl - Viewable but not not editable: Display in OPAC: [] Check to display this attribute on a patron's details page in the OPAC. - Viewable and editable: Edit in OPAC: [] Check to display and allow to edit this attribute on a patron's details page in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |jweaver@bywatersolutions.co | |m CC| |nengard@gmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #2 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 42254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42254&action=edit Bug 13757 - Make patron attributes editable in the OPAC (1/2) This patch adds an opac_editable property of borrower attribute types that can be set in the interface. Test plan: 1. Repeat the following with a new and existing borrower attribute type: 2. Verify that "Editable in OPAC" can only be checked if "Display in OPAC" is checked. 3. Verify that this new property is correctly saved. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #3 from Marc Véron <veron@veron.ch> --- Hi Jesse, I tested this first patch because I'm looking forward for this enhancement. After applying I can no longer create new attributes. This is what I get in intranet-error.log after I hit "Save": [Thu Sep 03 15:24:22 2015] [error] [client 10.0.0.85] [Thu Sep 3 15:24:22 2015] patron-attr-types.pl: DBD::mysql::st bind_param failed: Illegal parameter number at /usr/share/kohaclone/C4/Members/AttributeTypes.pm line 243., referer: http://10.0.0.31:8080/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribu... [Thu Sep 03 15:24:22 2015] [error] [client 10.0.0.85] [Thu Sep 3 15:24:22 2015] patron-attr-types.pl: DBD::mysql::st execute failed: Column count doesn't match value count at row 1 at /usr/share/kohaclone/C4/Members/AttributeTypes.pm line 244., referer: http://10.0.0.31:8080/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribu... [Thu Sep 03 15:24:22 2015] [error] [client 10.0.0.85] [Thu Sep 3 15:24:22 2015] patron-attr-types.pl: Argument "" isn't numeric in numeric gt (>) at /usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt line 336., referer: http://10.0.0.31:8080/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribu... [Thu Sep 03 15:24:22 2015] [error] [client 10.0.0.85] [Thu Sep 3 15:24:22 2015] patron-attr-types.pl: Argument "" isn't numeric in numeric gt (>) at /usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt line 336., referer: http://10.0.0.31:8080/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribu... However, I can set and save the value "Display in OPAC" on existing entries (and I see them in the table borrower_attribute_types). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make patron attributes |Make patron attributes |editable in the opac if set |editable in the opac if set |to be visible |to 'editable in OPAC' CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Jeremy Evans <Jeremy.evans@nibsc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Jeremy.evans@nibsc.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #4 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 42626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42626&action=edit Bug 13757 - (followup) fix creation of patron attributes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #5 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 42627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42627&action=edit Bug 13757 - Make patron attributes editable in the OPAC (2/2) This patch makes attributes marked as OPAC-editable editable from the OPAC. NOTE: This needs to be extended to work with the modifications system, and thus only works for new patrons. Test plan: 1) Create attributes that cover the spectrum of possible attribute types; repeatable, unique, dropdown, etc. 2) Verify that all of these attributes are correctly validated and saved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org