http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12271 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12271 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28287|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 28298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28298&action=edit [SIGNED-OFF] Bug 12271 - valid-templates.t does not test bootstrap opac templates valid-templates.t actually tests the templates and includes of only the "prog" theme at opac and intranet. It does not test the opac templates and includes of bootstrap theme, nor ccsr. This is critical since this test is used for patch integrations in release maintenance. This patch adds the test of bootstrap opac theme. I did not manage to add the ccsr theme since it is not a real theme, meaning it has no templates and not all includes. Test by runnning perl xt/author/valid-templates.t and looking at the logs. The should be 902 test lignes. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Now there are 902 lines, bootstrap tested (1 error detected!) No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|chris@bigballofwax.co.nz |fridolyn.somers@biblibre.co | |m --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Frido, please remember to assign the bugs to yourself :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12271 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Katrin Fischer from comment #5)

I am not sure about this one - I see more errors in:

not ok 782 - /home/katrin/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head- close.inc not ok 784 - /home/katrin/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom. inc not ok 773 - /home/katrin/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/search/ results.tt not ok 752 - /home/katrin/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results- grouped.tt

was me not runnig the test right, found same 'not ok' files, only different number not ok 714 - /home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt not ok 766 - /home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/search/results.tt not ok 779 - /home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc not ok 792 - /home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12271 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- After writing a couple follow-ups to (a) exclude a couple templates that cannot be tested independently in the Bootstrap theme and (b) correct errors to two templates found by the tests of the additional templates, I've judged this important enough to push directly to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12271 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07. Thanks Bernardo, Katrin and Galen. This will provide better templates ;) -- You are receiving this mail because: You are watching all bug changes.