[Bug 16568] New: Talking Tech generates phone notifications for all overdue actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Bug ID: 16568 Summary: Talking Tech generates phone notifications for all overdue actions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Regardless of whether the phone transport has been selected for a given overdue action or not, the Talking Tech outbound script generates and sends a line for that action. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 51719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51719&action=edit Bug 16568 - Talking Tech generates phone notifications for all overdue actions Regardless of whether the phone transport has been selected for a given overdue action or not, the Talking Tech outbound script generates and sends a line for that action. Test Plan: 1) Enable Talking Tech 2) Create one or more overdue actions without a phone transport selected and one or more with the phone transport selected 3) Generate the overdues csv file to send to Itive 4) Note the csv file has lines for actions that do not have the phone transport selected 5) Apply this patch 6) Repeat step 3 7) Note the csv file now only has lines for actions that have the phone transport selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Chris Rohde <crohde@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Patch tested with a sandbox, by Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51719|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 63529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63529&action=edit Bug 16568 - Talking Tech generates phone notifications for all overdue actions Regardless of whether the phone transport has been selected for a given overdue action or not, the Talking Tech outbound script generates and sends a line for that action. Test Plan: 1) Enable Talking Tech 2) Create one or more overdue actions without a phone transport selected and one or more with the phone transport selected 3) Generate the overdues csv file to send to Itive 4) Note the csv file has lines for actions that do not have the phone transport selected 5) Apply this patch 6) Repeat step 3 7) Note the csv file now only has lines for actions that have the phone transport selected Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63529|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 63564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63564&action=edit Bug 16568 - Talking Tech generates phone notifications for all overdue actions Regardless of whether the phone transport has been selected for a given overdue action or not, the Talking Tech outbound script generates and sends a line for that action. Test Plan: 1) Enable Talking Tech 2) Create one or more overdue actions without a phone transport selected and one or more with the phone transport selected 3) Generate the overdues csv file to send to Itive 4) Note the csv file has lines for actions that do not have the phone transport selected 5) Apply this patch 6) Repeat step 3 7) Note the csv file now only has lines for actions that have the phone transport selected Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good to me (trivial change). Another point is moving these larger queries out of the scripts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org