[Bug 5066] New: Incorrect use of localtime function when calling _session_log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5066 Summary: Incorrect use of localtime function when calling _session_log Change sponsored?: --- Product: Koha Version: rel_3_0 Platform: All OS/Version: All Status: ASSIGNED Severity: trivial Priority: PATCH-Sent Component: Authentication AssignedTo: m.de.rooy@rijksmuseum.nl ReportedBy: m.de.rooy@rijksmuseum.nl QAContact: koha-bugs@lists.koha-community.org CC: dpavlin@rot13.org Estimated Hours: 0.0 The function localtime is called a couple of times in C4/Auth.pm in list context rather than scalar context. Patch sent for 3.0.x -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5066 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2010-11-04 09:22:40 UTC --- Problem still occurred on one place in code. Patch sent for master (3.4). diff --git a/C4/Auth.pm b/C4/Auth.pm index 6ba852d..58ce63e 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -717,7 +717,7 @@ sub checkauth { ( $return, $cardnumber ) = checkpw( $dbh, $userid, $password, $query ); } if ($return) { - _session_log(sprintf "%20s from %16s logged in at %30s.\n", $userid,$ENV{'REMOTE_ADDR'},localtime); + _session_log(sprintf "%20s from %16s logged in at %30s.\n", $userid,$ENV{'REMOTE_ADDR'},scalar localtime); if ( $flags = haspermission( $userid, $flagsrequired ) ) { $loggedin = 1; } -- -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5066 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_0 |HEAD -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5066 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2010-11-18 01:25:54 UTC --- Patch pushed please test and close -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5066 --- Comment #3 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-11-18 03:15:30 UTC --- This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5066 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5066 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5066 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2010-12-17 14:42:43 UTC --- *** Bug 3295 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org