[Bug 26008] New: Remove the use of jquery.checkboxes plugin from OPAC cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 Bug ID: 26008 Summary: Remove the use of jquery.checkboxes plugin from OPAC cart Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 26005 Blocks: 26006 As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should replaced in the OPAC cart, for handling checkbox actions like "select all" and "clear all." The plugin is very old and unmaintained. We should use our own JS to replace it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26005 [Bug 26005] OPAC cart display fails with error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107024&action=edit Bug 26008: Remove the use of jquery.checkboxes plugin from OPAC cart This patch removes the use of the jquery.checkboxes plugin from the OPAC cart and replaces its functionality with "plain" jQuery. To test, apply the patch and add some items to the Cart in the OPAC. - Open the Cart window in the OPAC by clicking the "Cart" link in the header. - Test that the "Select all" and "Clear all" links work correctly to check and uncheck all checkboxes. - Controls like "Remove" and "Place hold" should be enabled or disabled according to whether there are any checked checkboxes. - Test that manually checking a checkbox correctly enables or disables the link options too. - Test that the "Remove" or "Place hold" controls work correctly, applying to only the checked checkboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107024|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 107648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107648&action=edit Bug 26008: Remove the use of jquery.checkboxes plugin from OPAC cart This patch removes the use of the jquery.checkboxes plugin from the OPAC cart and replaces its functionality with "plain" jQuery. To test, apply the patch and add some items to the Cart in the OPAC. - Open the Cart window in the OPAC by clicking the "Cart" link in the header. - Test that the "Select all" and "Clear all" links work correctly to check and uncheck all checkboxes. - Controls like "Remove" and "Place hold" should be enabled or disabled according to whether there are any checked checkboxes. - Test that manually checking a checkbox correctly enables or disables the link options too. - Test that the "Remove" or "Place hold" controls work correctly, applying to only the checked checkboxes. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107648|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108020&action=edit Bug 26008: Remove the use of jquery.checkboxes plugin from OPAC cart This patch removes the use of the jquery.checkboxes plugin from the OPAC cart and replaces its functionality with "plain" jQuery. To test, apply the patch and add some items to the Cart in the OPAC. - Open the Cart window in the OPAC by clicking the "Cart" link in the header. - Test that the "Select all" and "Clear all" links work correctly to check and uncheck all checkboxes. - Controls like "Remove" and "Place hold" should be enabled or disabled according to whether there are any checked checkboxes. - Test that manually checking a checkbox correctly enables or disables the link options too. - Test that the "Remove" or "Place hold" controls work correctly, applying to only the checked checkboxes. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should not we remove the checkboxed class on the 2 forms of opac-basket.tt? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 108154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108154&action=edit (follow-up) Removed checkboxed class Bug 26008: (follow-up) Removed checkboxed class This patch removes the "checkboxed" class which was previously associated with the jquery.checkboxes plugin and is now obsolete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x. for 20.05.03 I did not see the commit for the follow up in master, has that been pushed yet? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I've squashed them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | CC| |aleisha@catalyst.net.nz Status|Pushed to master |Pushed to stable --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org