[Bug 38066] New: New authority finder footer blocks page content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Bug ID: 38066 Summary: New authority finder footer blocks page content Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org Depends on: 35857 Bug 35857 gave the authority lookup popup window a floating footer with the choose, clear form, and close window buttons, but it didn't give the window contents enough space to display it without blocking content. Steps to reproduce: 1. Cataloging - New record 2. Tab 6 - in 650 subfield a type the letter a and click the postcard with a pencil Tag editor icon to the right of the input 3. In the popup window, scroll to the bottom Expected result: The paging controls at the bottom of the first page of results, and the "Back to top" arrow are completely visible Actual result: Half the "Back to top" arrow and maybe 20% of the paging controls are visible Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 [Bug 35857] Update display of Clear and Cancel links in the authority search pop-up window -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|New authority finder footer |Popup window footers can |blocks page content |block page content -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173079&action=edit Bug 38066: Popup window footers can block page content The staff interface's default <body> padding is enough to accommmodate the langugage-selection footer but not the taller fixed footer on pop-up window pages. This patch adds some CSS to increase the padding on those pages to prevent page content from being obscured by the footer navigation. The patch also adjusts the CSS of the "Back to top" arrow so that it isn't hidden by fixed footer. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, go to Cataloging -> New record. - In tab one, click the plugin button on tag 100 subfield a. - Perform an authority search which will return results. - Scroll down to the bottom of the window and confirm that the last lines of the search results are not obscured by the footer. This change should apply to all pop-up windows which include the same fixed footer markup, e.g. any cataloging plugin; the transfer order window; vendor search when adding a subscription, etc. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173079|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 173080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173080&action=edit Bug 38066: Popup window footers can block page content The staff interface's default <body> padding is enough to accommmodate the langugage-selection footer but not the taller fixed footer on pop-up window pages. This patch adds some CSS to increase the padding on those pages to prevent page content from being obscured by the footer navigation. The patch also adjusts the CSS of the "Back to top" arrow so that it isn't hidden by fixed footer. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, go to Cataloging -> New record. - In tab one, click the plugin button on tag 100 subfield a. - Perform an authority search which will return results. - Scroll down to the bottom of the window and confirm that the last lines of the search results are not obscured by the footer. This change should apply to all pop-up windows which include the same fixed footer markup, e.g. any cataloging plugin; the transfer order window; vendor search when adding a subscription, etc. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the display of release notes| |some dialog boxes, such as | |the authority record search | |plugin when editing 100$a, | |so that the content at the | |bottom (such as search | |results) is not obscured by | |the footer navigation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173080|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173504&action=edit Bug 38066: Popup window footers can block page content The staff interface's default <body> padding is enough to accommmodate the langugage-selection footer but not the taller fixed footer on pop-up window pages. This patch adds some CSS to increase the padding on those pages to prevent page content from being obscured by the footer navigation. The patch also adjusts the CSS of the "Back to top" arrow so that it isn't hidden by fixed footer. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, go to Cataloging -> New record. - In tab one, click the plugin button on tag 100 subfield a. - Perform an authority search which will return results. - Scroll down to the bottom of the window and confirm that the last lines of the search results are not obscured by the footer. This change should apply to all pop-up windows which include the same fixed footer markup, e.g. any cataloging plugin; the transfer order window; vendor search when adding a subscription, etc. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Popup window footers can |Pop-up window footers can |block page content |block page content -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #6 from Andrii Nugged <nugged@gmail.com> --- Can't build my .deb on 24.05.x because of: Message: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Error: Undefined variable. 5025 │ z-index: $zindex-tooltip; ... is it because it's not fully backported, or I missed some steps in build? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 --- Comment #7 from Andrii Nugged <nugged@gmail.com> --- To append to last comment about backport to 24.05.x: I changed: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss -– @@ -5022,7 +5022,7 @@ div .suggestion_note { position: fixed; bottom: 40px; right: 40px; - z-index: $zindex-tooltip; + z-index: 1080; } @media only screen and ( max-width: 1200px ) { -– and managed to build .deb -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Andrii Nugged from comment #6)
Can't build my .deb on 24.05.x because of:
Message: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Error: Undefined variable. 5025 │ z-index: $zindex-tooltip;
... is it because it's not fully backported, or I missed some steps in build?
I shouldn't have backported this to 24.05.x because there is no $zindex-tooltip in that version, I am reverting this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.06 |24.11.00 released in| | --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This one is now reverted from 24.05.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.06 |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org