[Bug 17094] New: Methods of Koha::Object[s] -based classed should not return DBIx::Class objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Bug ID: 17094 Summary: Methods of Koha::Object[s]-based classed should not return DBIx::Class objects Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org For instance the 2 methods get_shares and get_contents from Koha::Virtualshelf return DBIx::Class objects instead of Koha::Virtualshelfshares and Koha::Virtualshelfcontents objects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17091 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091 [Bug 17091] Add AUTOLOAD to Koha::Objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54239&action=edit Bug 17094: Add delete to the Koha::Objects AUTOLOAD method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54240&action=edit Bug 17094: Make Koha::Virtualshelf methods return Koha::Objects-based objects Instead of DBIx::Class objects. Test plan: 1/ Add content to a list and share it with another patron 2/ Try to view the list with the other patron 3/ download and send a shelf and check if the biblio list is correct 4/ prove t/db_dependent/Virtualshelves.t should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleishaamohia@hotmail.com --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- fatal: sha1 information is lacking or useless (Koha/Objects.pm). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #3)
fatal: sha1 information is lacking or useless (Koha/Objects.pm).
Did you apply all the dependencies? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54239|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54795&action=edit [SIGNED-OFF] Bug 17094: Add delete to the Koha::Objects AUTOLOAD method Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54240|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54796&action=edit [SIGNED-OFF] Bug 17094: Make Koha::Virtualshelf methods return Koha::Objects-based objects Instead of DBIx::Class objects. Test plan: 1/ Add content to a list and share it with another patron 2/ Try to view the list with the other patron 3/ download and send a shelf and check if the biblio list is correct 4/ prove t/db_dependent/Virtualshelves.t should return green Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54795|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 54795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54795 [SIGNED-OFF] Bug 17094: Add delete to the Koha::Objects AUTOLOAD method Moved to bug 17091 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 [Bug 17249] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesFromField -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54796|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56345&action=edit [PASSED QA] Bug 17094: Make Koha::Virtualshelf methods return Koha::Objects-based objects Instead of DBIx::Class objects. Test plan: 1/ Add content to a list and share it with another patron 2/ Try to view the list with the other patron 3/ download and send a shelf and check if the biblio list is correct 4/ prove t/db_dependent/Virtualshelves.t should return green Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #9 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 16.11 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org