[Bug 32292] New: suggestions in Columns.pm are not translated to real labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Bug ID: 32292 Summary: suggestions in Columns.pm are not translated to real labels Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr, jonathan.druart+koha@gmail.com When looking at Column.pm, you can see that all the columns are translated to nice display messages, but not the ones for suggestions. They are direct copies of the names of the database columns. This means that 'collectiontitle' and similar show up in translations creating some confusion. Should these not also be nice labels? suggestions=> { "author" => __("author"), "copyrightdate" => __("copyrightdate"), "isbn" => __("isbn"), "publishercode" => __("publishercode"), "collectiontitle" => __("collectiontitle"), "place" => __("place"), "quantity" => __("quantity"), "itemtype" => __("itemtype"), "branchcode" => __("branchcode"), "patronreason" => __("patronreason"), "note" => __("note"), "title" => __("title"), } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29695 Keywords| |Academy --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Yes, I think so. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 [Bug 29695] Centralize columns' descriptions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144137&action=edit Bug 32292: Add column descriptions to subscriptions table / complete items table * Adds proper labels to the database columns for suggestions * Adds missing item columns: * coded_location_qualifier * deleted_on * exclude_form_local_holds_priority * Fixes spelling of item type, Uniform resource identifier To test: * Go to reports > Guided reports * Select acquisition or another module using the items * Make sure all entries for the tables items up with nice descriptions * Changes to subscriptions: verify reading the patch, these don't seem to show up yet in guided reports. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144138&action=edit Bug 32292: Add column descriptions to aqorders table This adds nice descriptions to the aqorders database columns. To test: * Go to Guided reports * Start a new report for acquisitions module * Verify that all aqorders columns show with nice descriptions None should be missing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144139&action=edit Bug 32292: Add column descriptions to biblio table This adds nice descriptions to the aqorders database columns. To test: * Go to Guided reports * Start a new report for acquisitions module * Verify that all aqorders columns show with nice descriptions None should be missing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144140&action=edit Bug 32291: Add missing column descriptions to borrowers table Adds missing column descriptions for new features etc. to the existing entry for borrowres columns descriptions. To test: * Go to reports > Guided reports * Select patrons module * Make sure all entries for the tables items and suggestions show up with nice descriptions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This completes and adds release notes| |column descriptions that | |show up when creating a new | |guided report for following | |tables: | |* items | |* borrowers | |* biblio | |* aqorders | |* | |suggestions Summary|suggestions in Columns.pm |Update and add database |are not translated to real |column descriptions used in |labels |guided reports --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fell down the rabbit hole a little bit here... will file some bugs for other tables still missing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32313 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32313 [Bug 32313] Complete database column descriptions for cataloguing module in guided reports -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144141&action=edit Bug 32292: Fix POD POD had a typo in suggestions and was missing the new aqorders. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32314 [Bug 32314] Complete database column descriptions for accounts module in guided reports -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32315 [Bug 32315] Complete database column descriptions for serials module in guided reports -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Blocks| |32312 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 [Bug 32312] Complete database column descriptions for circulation module in guided reports -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144137|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 144410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144410&action=edit Bug 32292: Add column descriptions to subscriptions table / complete items table * Adds proper labels to the database columns for suggestions * Adds missing item columns: * coded_location_qualifier * deleted_on * exclude_form_local_holds_priority * Fixes spelling of item type, Uniform resource identifier To test: * Go to reports > Guided reports * Select acquisition or another module using the items * Make sure all entries for the tables items up with nice descriptions * Changes to subscriptions: verify reading the patch, these don't seem to show up yet in guided reports. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144138|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 144411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144411&action=edit Bug 32292: Add column descriptions to aqorders table This adds nice descriptions to the aqorders database columns. To test: * Go to Guided reports * Start a new report for acquisitions module * Verify that all aqorders columns show with nice descriptions None should be missing. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144139|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 144412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144412&action=edit Bug 32292: Add column descriptions to biblio table This adds nice descriptions to the aqorders database columns. To test: * Go to Guided reports * Start a new report for acquisitions module * Verify that all aqorders columns show with nice descriptions None should be missing. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144140|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 144413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144413&action=edit Bug 32291: Add missing column descriptions to borrowers table Adds missing column descriptions for new features etc. to the existing entry for borrowres columns descriptions. To test: * Go to reports > Guided reports * Select patrons module * Make sure all entries for the tables items and suggestions show up with nice descriptions https://bugs.koha-community.org/show_bug.cgi?id=32292 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144141|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 144414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144414&action=edit Bug 32292: Fix POD POD had a typo in suggestions and was missing the new aqorders. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | --- Comment #13 from David Nind <david@davidnind.com> --- Testing notes using KTD (koha-testing-docker): 1. Added Katrin as the assignee :) 2. I couldn't see the suggestions descriptions or fields in any of the guided reports available - I am assuming that they are used/show elsewhere in Koha, and not just the guided reports. 3. I confused myself when testing, so I recorded what this bug takes care of for each of the guided reports, and the other bugs that will fix the remaining descriptions. 4. This bug takes care of all descriptions for items, acqorders, biblio, and borrowers. 5. These bugs will take care of all the other descriptions: - Bug 32312: Circulation - statistics (remaining items) - Bug 32313: Catalog - biblioitems (remaining items) - Bug 32314: Accounts - accountlines (all missing) - Bug 32315: Serials - serial (all missing), serialitems (all missing), subscription (most missing), subscriptionhistory (all missing), subscriptionroutinglist (all missing), acqbooksellers (all missing) 6. Bugs by guided report category: Circulation: - statistics: some missing, bug 32312 - items: OK, fixed by this bug - biblioitems: some missing, bug 32313 Catalog: - items: OK, fixed by this bug - biblioitems: some missing, bug 32313 - biblio: OK, fixed by this bug Patrons: - borrowers: OK, fixed by this bug Acquisitions: - acqorders: OK, fixed by this bug - biblio: OK, fixed by this bug - items: OK, fixed by this bug Accounts: - borrowers: OK, fixed by this bug - accountlines: all missing, bug 32314 Serials: - serial: all missing, bug 32315 - serialitems: all missing, bug 32315 - subscription: most missing, bug 32315 - subscriptionhistory: all missing, bug 32315 - subscriptionroutinglist: all missing, bug 32315 - biblioitems: some missing, bug 32313 - biblio: OK, fixed by this bug - acqbooksellers: all missing, bug 32315 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #13)
Testing notes using KTD (koha-testing-docker):
1. Added Katrin as the assignee :)
Hope Nick doesn't see this :) Great summary, thx David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25441 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144410|0 |1 is obsolete| | Attachment #144411|0 |1 is obsolete| | Attachment #144412|0 |1 is obsolete| | Attachment #144413|0 |1 is obsolete| | Attachment #144414|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145853&action=edit Bug 32292: Add column descriptions to subscriptions table / complete items table * Adds proper labels to the database columns for suggestions * Adds missing item columns: * coded_location_qualifier * deleted_on * exclude_form_local_holds_priority * Fixes spelling of item type, Uniform resource identifier To test: * Go to reports > Guided reports * Select acquisition or another module using the items * Make sure all entries for the tables items up with nice descriptions * Changes to subscriptions: verify reading the patch, these don't seem to show up yet in guided reports. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145854&action=edit Bug 32292: Add column descriptions to aqorders table This adds nice descriptions to the aqorders database columns. To test: * Go to Guided reports * Start a new report for acquisitions module * Verify that all aqorders columns show with nice descriptions None should be missing. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145855&action=edit Bug 32292: Add column descriptions to biblio table This adds nice descriptions to the aqorders database columns. To test: * Go to Guided reports * Start a new report for acquisitions module * Verify that all aqorders columns show with nice descriptions None should be missing. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145856&action=edit Bug 32292: Add missing column descriptions to borrowers table Adds missing column descriptions for new features etc. to the existing entry for borrowres columns descriptions. To test: * Go to reports > Guided reports * Select patrons module * Make sure all entries for the tables items and suggestions show up with nice descriptions Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145857&action=edit Bug 32292: Fix POD POD had a typo in suggestions and was missing the new aqorders. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work, nice cleanup again. Minor fix applied to one patch to fix the bug number typo. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 145868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145868&action=edit Bug 32292: Tidy and sort keys This patch does a perltidy on the data structure, but also organizes keys alphabetically to ease maintenance. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 --- Comment #23 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org